[PATCH] rpctrace: implement -E

2013-03-01 Thread Pino Toscano
Hi, attached there is a patch for rpctrace to implement the -E option, as available for strace. This makes it possible to pass -Evar=value to set/change an envvar of the process, and -Evar to unset it. Side question: do we have git hooks to automatically close bugs and tasks with commits? Tha

Re: [PATCH] rpctrace: implement -E

2013-03-01 Thread Samuel Thibault
Pino Toscano, le Fri 01 Mar 2013 16:27:03 +0100, a écrit : > Side question: do we have git hooks to automatically close bugs and > tasks with commits? I don't know. > + newval = *(equal + 1) != 0 ? equal + 1 : ""; Why checking against *(equal+1) == 0 ? using equal+1 in the == 0 ca

Re: connect() access bytes after socket address

2013-03-01 Thread Roland McGrath
> I agree. I've worked on a patch, pushed to topgit for later submission. I hope you did it by adding a common helper function (or perhaps it needs to be macro declaring a local VLA) for at least the cases other than bind. bind needs to be a little different since it needs to do a split, but still

Re: connect() access bytes after socket address

2013-03-01 Thread Samuel Thibault
Roland McGrath, le Fri 01 Mar 2013 09:39:17 -0800, a écrit : > > I agree. I've worked on a patch, pushed to topgit for later submission. > > I hope you did it by adding a common helper function I didn't bother, but I can indeed, probably to glibc/include/sys/socket.h, or some other file? > (or p

Re: connect() access bytes after socket address

2013-03-01 Thread Roland McGrath
> I didn't bother, but I can indeed, probably to > glibc/include/sys/socket.h, or some other file? It's only needed for Hurd, so but it in some non-installed Hurd-only header. > > (or perhaps it needs to be macro declaring a local VLA) > > I rather used strndupa, provided by glibc/include/string

Re: [PATCH] rpctrace: implement -E

2013-03-01 Thread Pino Toscano
Alle venerdì 1 marzo 2013, Samuel Thibault ha scritto: > Pino Toscano, le Fri 01 Mar 2013 16:27:03 +0100, a écrit : > > Side question: do we have git hooks to automatically close bugs and > > tasks with commits? > > I don't know. Hm ok. > > + newval = *(equal + 1) != 0 ? equal + 1 :

Re: connect() access bytes after socket address

2013-03-01 Thread Samuel Thibault
Roland McGrath, le Fri 01 Mar 2013 09:57:11 -0800, a écrit : > > I didn't bother, but I can indeed, probably to > > glibc/include/sys/socket.h, or some other file? > > It's only needed for Hurd, so but it in some non-installed Hurd-only header. So for instance: #define _hurd_sun_path_dupa(__addr

Re: connect() access bytes after socket address

2013-03-01 Thread Samuel Thibault
Samuel Thibault, le Fri 01 Mar 2013 19:17:56 +0100, a écrit : > Roland McGrath, le Fri 01 Mar 2013 09:57:11 -0800, a écrit : > > > I didn't bother, but I can indeed, probably to > > > glibc/include/sys/socket.h, or some other file? > > > > It's only needed for Hurd, so but it in some non-installed

Re: [PATCH] rpctrace: implement -E

2013-03-01 Thread Samuel Thibault
Pino Toscano, le Fri 01 Mar 2013 19:08:29 +0100, a écrit : > Right, small harmless leftover from earlier code. Fixed now. It loops good, please push. Samuel

Re: connect() access bytes after socket address

2013-03-01 Thread Roland McGrath
Could be. I need to see the full patch changing all the cases to give a real opinion about the details.