Re: feature-mtab-translator (v3)

2013-07-19 Thread Justus Winter
Quoting Richard Braun (2013-07-19 17:41:55) > On Fri, Jul 19, 2013 at 05:25:02PM +0200, Justus Winter wrote: > > Richard mentioned that revealing mount points does not seem to be a > > concern on Linux, but arguably on Hurd an active translator is more > > common than a mount on linux. > > Well, t

[PATCH 16/17] XXX this looks wrong to me, please have a look

2013-07-19 Thread Justus Winter
--- libfshelp/start-translator-long.c |1 + 1 file changed, 1 insertion(+) diff --git a/libfshelp/start-translator-long.c b/libfshelp/start-translator-long.c index 55fb0ff..9680871 100644 --- a/libfshelp/start-translator-long.c +++ b/libfshelp/start-translator-long.c @@ -293,6 +293,7 @@ fshe

Re: feature-mtab-translator (v3)

2013-07-19 Thread Richard Braun
On Fri, Jul 19, 2013 at 05:25:02PM +0200, Justus Winter wrote: > Richard mentioned that revealing mount points does not seem to be a > concern on Linux, but arguably on Hurd an active translator is more > common than a mount on linux. Well, that's irrelevant. What matters is that on Linux, mount p

[PATCH 14/17] trans/symlink.c: add fsys_get_source

2013-07-19 Thread Justus Winter
--- trans/symlink.c |7 +++ 1 file changed, 7 insertions(+) diff --git a/trans/symlink.c b/trans/symlink.c index 5e9e09a..946c950 100644 --- a/trans/symlink.c +++ b/trans/symlink.c @@ -229,3 +229,10 @@ S_fsys_get_children (mach_port_t server, { return EOPNOTSUPP; } + +error_t +S_fsys

[PATCH 15/17] hurd: add fsys_get_source

2013-07-19 Thread Justus Winter
--- hurd/fsys.defs |7 +++ 1 file changed, 7 insertions(+) diff --git a/hurd/fsys.defs b/hurd/fsys.defs index 4b649d9..27ada29 100644 --- a/hurd/fsys.defs +++ b/hurd/fsys.defs @@ -135,3 +135,10 @@ routine fsys_get_children ( server: fsys_t; RPT out children: data_

[PATCH 11/17] libdiskfs: add fsys_get_source

2013-07-19 Thread Justus Winter
--- libdiskfs/Makefile |4 ++-- libdiskfs/diskfs.h |6 ++ libdiskfs/fsys-get-source.c | 35 +++ libdiskfs/get-source.c | 29 + 4 files changed, 72 insertions(+), 2 deletions(-) create mode 100644 li

[PATCH 12/17] libnetfs: add fsys_get_source

2013-07-19 Thread Justus Winter
--- libnetfs/Makefile |5 +++-- libnetfs/fsys-get-source.c | 35 +++ libnetfs/get-source.c | 28 libnetfs/netfs.h |6 ++ 4 files changed, 72 insertions(+), 2 deletions(-) create mode 100644 libnet

[PATCH 10/17] hurd: add fsys_get_children

2013-07-19 Thread Justus Winter
--- hurd/fsys.defs |8 1 file changed, 8 insertions(+) diff --git a/hurd/fsys.defs b/hurd/fsys.defs index 979a6cf..4b649d9 100644 --- a/hurd/fsys.defs +++ b/hurd/fsys.defs @@ -127,3 +127,11 @@ routine fsys_get_options ( server: fsys_t; RPT out options: data_t,

[PATCH 13/17] libtrivfs: add fsys_get_source

2013-07-19 Thread Justus Winter
--- libtrivfs/Makefile |4 ++-- libtrivfs/fsys-get-source.c | 34 ++ libtrivfs/get-source.c | 28 libtrivfs/trivfs.h |6 ++ 4 files changed, 70 insertions(+), 2 deletions(-) create mode 100644 libt

[PATCH 17/17] add mtab prototype

2013-07-19 Thread Justus Winter
--- trans/Makefile |8 +- trans/mtab.c | 682 2 files changed, 687 insertions(+), 3 deletions(-) create mode 100644 trans/mtab.c diff --git a/trans/Makefile b/trans/Makefile index b3210b6..6eb51d0 100644 --- a/trans/Makefile +++ b/t

[PATCH 09/17] trans/symlink.c: add fsys_get_children

2013-07-19 Thread Justus Winter
--- trans/symlink.c |8 1 file changed, 8 insertions(+) diff --git a/trans/symlink.c b/trans/symlink.c index 03b5100..5e9e09a 100644 --- a/trans/symlink.c +++ b/trans/symlink.c @@ -221,3 +221,11 @@ S_fsys_forward (mach_port_t server, mach_port_t requestor, { return EOPNOTSUPP; }

[PATCH 01/17] libnetfs: implement file_get_translator_cntl

2013-07-19 Thread Justus Winter
This is a trivially adapted version of libdiskfs/file-get-transcntl.c. * libnetfs/file-get-transcntl.c: New file. --- libnetfs/Makefile |2 +- libnetfs/file-get-transcntl.c | 52 + libnetfs/fsstubs.c|8 --- 3 files chan

[PATCH 07/17] libnetfs: add fsys_get_children

2013-07-19 Thread Justus Winter
--- libnetfs/Makefile |2 +- libnetfs/file-set-translator.c | 15 ++ libnetfs/fsys-get-children.c | 113 3 files changed, 129 insertions(+), 1 deletion(-) create mode 100644 libnetfs/fsys-get-children.c diff --git a/libnetfs/Make

[PATCH 08/17] libtrivfs: add fsys_get_children

2013-07-19 Thread Justus Winter
--- libtrivfs/Makefile|3 ++- libtrivfs/fsys-get-children.c | 36 2 files changed, 38 insertions(+), 1 deletion(-) create mode 100644 libtrivfs/fsys-get-children.c diff --git a/libtrivfs/Makefile b/libtrivfs/Makefile index 1c6fd5e..3163777 1

[PATCH 05/17] libfshelp: add translator-list.c

2013-07-19 Thread Justus Winter
--- libfshelp/Makefile |3 +- libfshelp/fshelp.h | 21 ++ libfshelp/translator-list.c | 161 +++ 3 files changed, 184 insertions(+), 1 deletion(-) create mode 100644 libfshelp/translator-list.c diff --git a/libfshelp/Makefile b

[PATCH 03/17] libdiskfs: track file name in struct peropen

2013-07-19 Thread Justus Winter
--- libdiskfs/dir-lookup.c | 24 libdiskfs/diskfs.h |3 +++ libdiskfs/fsys-getroot.c |3 ++- libdiskfs/peropen-make.c |8 libdiskfs/peropen-rele.c |1 + 5 files changed, 38 insertions(+), 1 deletion(-) diff --git a/libdiskfs/dir-lookup.c

[PATCH 06/17] libdiskfs: add fsys_get_children

2013-07-19 Thread Justus Winter
--- libdiskfs/Makefile|3 +- libdiskfs/dead-name.c |4 +- libdiskfs/file-set-trans.c| 15 +++ libdiskfs/fsys-get-children.c | 100 + 4 files changed, 120 insertions(+), 2 deletions(-) create mode 100644 libdiskfs/fsys-

[PATCH 04/17] libnetfs: track file name in struct peropen

2013-07-19 Thread Justus Winter
--- libnetfs/dir-lookup.c | 23 +++ libnetfs/fsys-getroot.c|6 +- libnetfs/make-peropen.c|8 libnetfs/netfs.h |2 ++ libnetfs/release-peropen.c |1 + 5 files changed, 39 insertions(+), 1 deletion(-) diff --git a/libnetfs/di

[PATCH 02/17] pfinet: Fix call to kfree_s

2013-07-19 Thread Justus Winter
kfree_s expects a pointer and a size argument. Currently the sizeof(cache) is used as size argument, this is certainly not what was intented. For reference, this code was present in Linux up to version 2.3.14 and was replaced in 2.3.15. Found using coccinelle and https://raw.github.com/coccinelle

feature-mtab-translator (v3)

2013-07-19 Thread Justus Winter
Hi, this is a updated patch series for the mtab translator. I believe I have cleanly addressed all concerns and all issues I encountered while I was testing the translator (I'm dogfooding by the way). Notable changes: * The correct path is now stored in the peropen struct. The fact that it pre

Re: [PATCH] Fix error handling macro E

2013-07-19 Thread Samuel Thibault
Justus Winter, le Fri 19 Jul 2013 08:53:53 +0200, a écrit : > Previously the macro argument err was expanded and thus potentially > evaluated multiple times. This is fine for simple values or pure > functions, but not for say iohelp_create_iouser. Fix this by > evaluating the macro argument only on