Re: [PATCH 4/5] qualify constant with the const

> Marin Ramesa writes: > On 11.09.2013 22:14:49, Samuel Thibault wrote: > Marin Ramesa, le Wed 11 Sep 2013 12:27:50 +0200, a écrit : >>> Function cnputc() should never modify it's argument so qualify it >>> with a const keyword. >>> void >>> cnputc(c) >>> - char c; >>> + co

Re: [PATCH 3/7] name_equal: return early from function if src null-terminates in the loop

On 16.09.2013 01:59:09, Samuel Thibault wrote: > > Mmm, let me unloop it a bit: > > > if (*src++ != *target++) > > return FALSE; > > if (*src == '\0' && *target != '\0') > > return FALSE; > > if (*src++ != *target++) > > return FALSE; >

Re: [PATCH 4/5] qualify constant with the const

On 11.09.2013 22:14:49, Samuel Thibault wrote: > Marin Ramesa, le Wed 11 Sep 2013 12:27:50 +0200, a écrit : > > Function cnputc() should never modify it's argument so qualify it > > with a const keyword. > > > > void > > cnputc(c) > > - char c; > > + const char c; > > Well, this is not real

Invariant sections in gnumach package?

Hello, I'm wondering about the famous invariant sections that we're supposed to be having in the gnumach package. It seems we actually don't have any actually? mach.texi says: “ with the Invariant Sections being ``Free Software Needs Free Documentation'' and ``GNU Lesser General Public License'

Re: Hacking gnumach to track parental relationship of tasks

On Mon, Sep 16, 2013 at 01:50:57AM +0200, Samuel Thibault wrote: > Richard Braun, le Thu 12 Sep 2013 10:57:25 +0200, a écrit : > > I suggest we simply disable the trap versions. > > Ah, right. > > I don't have the time to dive into the details, but in the end, couldn't > we switch to making task_

Re: Small cleanup of device name routines

Hello, Marin Ramesa, le Fri 13 Sep 2013 13:31:50 +0200, a écrit : > [PATCH 1/7] remove register qualifiers > [PATCH 2/7] small style changes for consistency > [PATCH 3/7] name_equal: return early from function if src null-terminates in > the loop > [PATCH 4/7] another small change in style for co

Re: [PATCH 3/7] name_equal: return early from function if src null-terminates in the loop

Marin Ramesa, le Fri 13 Sep 2013 13:31:53 +0200, a écrit : > Return early from function if src null-terminates in the loop before > the target does. This is to prevent pointers going to addresses beyond > null-termination. Mmm, let me unloop it a bit: > if (*src++ != *target++) >

Re: Hacking gnumach to track parental relationship of tasks

Richard Braun, le Thu 12 Sep 2013 10:57:25 +0200, a écrit : > On Thu, Sep 12, 2013 at 10:38:31AM +0200, Samuel Thibault wrote: > > Richard Braun, le Thu 12 Sep 2013 10:33:23 +0200, a écrit : > > > Then why are we discussing interposing system calls ? > > > > Because a malicious program can still u

Re: [PATCHv2 1/2] Handle notification on page eviction

Applied them both, finally! Thanks, Samuel

Re: [PATCH 4/4] Serve mounts node with a passive translator record

Justus Winter, le Mon 22 Jul 2013 17:54:39 +0200, a écrit : > Make mounts a node with a passive translator record so that the mtab > translator is started on access if it is available. Applied, thanks! Samuel

Re: mtab translator (v4)

Hello, Justus Winter, le Tue 30 Jul 2013 11:59:08 +0200, a écrit : > this is the fourth version of my mtab patch series. I consider it > feature complete. I have pushed it, thanks!! Samuel

Re: [PATCH 16/16] trans: add mtab translator

Justus Winter, le Tue 30 Jul 2013 11:59:24 +0200, a écrit : > + if (strncmp (device, "device:", 7) == 0) > +asprintf (path, "/dev/%s", &device[7]); > + else if (strncmp (device, "/dev/", 5) == 0) > +*path = strdup (device); > + else if (looks_like_block_device (device)) > +asprintf

Re: [PATCH 3/7] libihash: add HURD_IHASH_ITERATE_ITEMS macro

Justus Winter, le Thu 05 Sep 2013 18:38:39 +0200, a écrit : > Add a macro HURD_IHASH_ITERATE_ITEMS that iterates over all elements > in the hash table making both the key and the value available. That makes sense indeed, applied. Samuel

Re: [PATCH 2/7] proc: Remove unused declaration of zombie_list

Justus Winter, le Thu 05 Sep 2013 18:38:38 +0200, a écrit : > * proc/proc.h (zombie_list): Remove declaration. Applied, obviously :) Samuel

Re: [PATCH 1/7] proc: remove unused file exc-reply.defs

Uh, indeed, it even seems syntaxically incorrect :) Applied, thanks, Samuel

Re: [PATCH] Make start_code and end_code available in /proc/*/stat

Justus Winter, le Mon 05 Aug 2013 12:11:30 +0200, a écrit : > This makes killall5 actually kill any processes not marked as > important. Applied, thanks! Samuel

Re: [PATCH 15/17] hurd: add proc_{get,set}_code

> [PATCH 14/17] proc: keep track of {start,end}_code > [PATCH 15/17] hurd: add proc_{get,set}_code > [PATCH 16/17] exec: keep track of the range where executable s I have applied them, thanks! Samuel

Re: [PATCH 1/2] Try to re-open network device on transmission error

Hello, This doesn't seem to be really taking into account my previous comments: “ It seems there are other things done on ether_port in setup_ethernet_device. I however guess these could be moved into ethernet_open(), so that we can indeed merely call it on device_write() errors. Probably we al

Re: [PATCH 2/2] Look up device file name on device_open

Hello, rekado, le Thu 12 Sep 2013 14:10:55 +0800, a écrit : > A fresh `master_device' port is now obtained when accessing the device > file, not only on translator startup. This ensures that the device > can be re-opened after netdde has died. Applied to the incubator, thanks. Could you however

Re: [PATCH 1/2] remove register qualifiers

Both applied, thanks. Samuel

Re: [PATCH] remove libz/libbz2 entry from contributing page

Hello, rekado, le Sat 14 Sep 2013 09:44:08 +0800, a écrit : > According to [1], the preferred way is to remove support for unzipping > from the exec translator and implement this feature through other > translators. > -* Use libz and libbz2 in exec. See `hurd/exec/unzip.c` etc., they should be >