Hey,
On 25/10/13 17:34, Thomas Schwinge wrote:
> Hi!
>
> On Fri, 25 Oct 2013 15:54:43 +0200, Justus Winter
> <4win...@informatik.uni-hamburg.de> wrote:
>> what you're suggesting is not
>> possible. Labels can only be placed in front of a statement and a
>> declaration is not a statement. Well, t
> Clang does not support nested functions [1], and there is no plan to
> support them upstream. As such, any file that uses nested functions
> (or any gcc extension not supported by clang) is excluded from the
> analysis (see e.g. [2]). Richard has no special love for them, iiuc
> b/c the semantic
Hi!
On Fri, 25 Oct 2013 13:45:47 +0200, Justus Winter
<4win...@informatik.uni-hamburg.de> wrote:
> * configure.ac: Properly escape the test for X11/keysymdef.h using
> AC_LANG_SOURCE.
OK to push. Fixup for commit d028b59ccaac609f5d9e01907df30f9cecd2595e.
The generated configure file is identi
Hi!
On Fri, 25 Oct 2013 15:54:43 +0200, Justus Winter
<4win...@informatik.uni-hamburg.de> wrote:
> what you're suggesting is not
> possible. Labels can only be placed in front of a statement and a
> declaration is not a statement. Well, that's what gcc told me...
D'oh. :-)
> Quoting Thomas Sc
At Fri, 25 Oct 2013 15:54:43 +0200,
Justus Winter wrote:
>
> Quoting Thomas Schwinge (2013-10-25 15:27:10)
> > > --- a/libports/create-internal.c
> > > +++ b/libports/create-internal.c
> > > @@ -109,10 +109,11 @@ _ports_create_port_internal (struct port_class
> > > *class,
> > >err = EINTR;
>
Hi!
On Tue, 22 Oct 2013 16:15:26 +0200, Samuel Thibault
wrote:
> Justus Winter, le Tue 22 Oct 2013 16:10:06 +0200, a écrit :
> > Quoting Samuel Thibault (2013-10-22 15:12:12)
> > > > * I installed a 250GB hard disk but it doesn't show up with the full
> > > > capacity, dunno why.
> > >
> > >
Quoting Thomas Schwinge (2013-10-25 15:27:10)
> > --- a/libports/create-internal.c
> > +++ b/libports/create-internal.c
> > @@ -109,10 +109,11 @@ _ports_create_port_internal (struct port_class *class,
> >err = EINTR;
> > lose:
> >pthread_mutex_unlock (&_ports_lock);
> > + error_t e;
> >
Hi!
On Tue, 22 Oct 2013 22:42:18 +0200, Samuel Thibault
wrote:
> Justus Winter, le Tue 22 Oct 2013 17:12:54 +0200, a écrit :
> > Note the "", on my linux box that reads "/usr/bin/clang"
> > instead. Thoughts?
>
> I've noticed that in the llvm toolchain things are
> missing/missconfigured indeed
Hi!
On Fri, 25 Oct 2013 10:30:23 +0200, Justus Winter
<4win...@informatik.uni-hamburg.de> wrote:
> Found using the Clang Static Analyzer.
>
> * libshouldbeinlibc/maptime.c (maptime_map): Fix error handling.
OK.
Grüße,
Thomas
pgp_McyTxfAEX.pgp
Description: PGP signature
Hi!
On Fri, 25 Oct 2013 15:15:22 +0200, Emilio Pozuelo Monfort
wrote:
> Minor nitpick:
>
> On 25/10/13 10:30, Justus Winter wrote:
> > Found using the Clang Static Analyzer.
> >
> > * libtrivfs/protid-clean.c (trivfs_clean_protid): Fix use-after-free error.
> > --- a/libtrivfs/protid-clean.c
Hi!
Many thanks for paying attention to such issues!
On Fri, 25 Oct 2013 10:30:22 +0200, Justus Winter
<4win...@informatik.uni-hamburg.de> wrote:
> Previously any err value set before reaching lose: was overwritten and
> thus not properly propagated.
>
> Found using the Clang Static Analyzer.
>
Minor nitpick:
On 25/10/13 10:30, Justus Winter wrote:
> Found using the Clang Static Analyzer.
>
> * libtrivfs/protid-clean.c (trivfs_clean_protid): Fix use-after-free error.
> ---
> libtrivfs/protid-clean.c |5 -
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/libtri
Hi!
On Fri, 25 Oct 2013 10:30:20 +0200, Justus Winter
<4win...@informatik.uni-hamburg.de> wrote:
> If gcc is used with optimizations -O2, -O3, or -Os, it will enable
> optimizations that assume that pointers of different type do not
> alias, i.e. point to the same address. However, we use this a
Hi!
On Fri, 25 Oct 2013 10:30:21 +0200, Justus Winter
<4win...@informatik.uni-hamburg.de> wrote:
> * exec/Makefile: Remove commented out lines related to BFD.
> * exec/hostarch.c: Remove all BFD related code.
> * exec/main.c: Likewise.
OK, given that you removed other BFD code earlier.
Grüße,
* configure.ac: Properly escape the test for X11/keysymdef.h using
AC_LANG_SOURCE.
---
configure.ac |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure.ac b/configure.ac
index 6844f6c..d822dd2 100644
--- a/configure.ac
+++ b/configure.ac
@@ -259,7 +259,7 @@ PKG_CHECK
If gcc is used with optimizations -O2, -O3, or -Os, it will enable
optimizations that assume that pointers of different type do not
alias, i.e. point to the same address. However, we use this a lot,
e.g. in code using libports.
Add -fno-strict-aliasing to CFLAGS to disable optimizations based on
t
* exec/Makefile: Remove commented out lines related to BFD.
* exec/hostarch.c: Remove all BFD related code.
* exec/main.c: Likewise.
---
exec/Makefile |3 --
exec/hostarch.c | 99 +--
exec/main.c | 19 ---
3 files changed, 1
Previously any err value set before reaching lose: was overwritten and
thus not properly propagated.
Found using the Clang Static Analyzer.
* libports/create-internal.c (_ports_create_port_internal): Fix error
handling.
---
libports/create-internal.c |7 ---
1 file changed, 4 insertion
Found using the Clang Static Analyzer.
* libtrivfs/protid-clean.c (trivfs_clean_protid): Fix use-after-free error.
---
libtrivfs/protid-clean.c |5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/libtrivfs/protid-clean.c b/libtrivfs/protid-clean.c
index 856d7af..575dec3 100
Found using the Clang Static Analyzer.
* libshouldbeinlibc/maptime.c (maptime_map): Fix error handling.
---
libshouldbeinlibc/maptime.c |2 ++
1 file changed, 2 insertions(+)
diff --git a/libshouldbeinlibc/maptime.c b/libshouldbeinlibc/maptime.c
index bc75045..cacf4b6 100644
--- a/libshouldb
20 matches
Mail list logo
