Re: Removal of register qualifiers from kern source

2013-11-12 Thread Samuel Thibault
Applied, thanks! Samuel

Re: [PATCH] libports: implement lockless management of threads

2013-11-12 Thread Samuel Thibault
Hello, OK, I believe that'll work indeed. What really makes it work is this: Justus Winter, le Mon 11 Nov 2013 21:12:34 +0100, a écrit : > + /* Decrement nreqthreads. */ > + unsigned int tc = __atomic_sub_fetch (&thread_counts, 1, > + __ATOMIC_RE

Re: [PATCH 2/5] kern (rbtree_insert_rebalance): rewrite node swap

2013-11-12 Thread Richard Braun
On Tue, Nov 12, 2013 at 12:39:40PM +0100, Samuel Thibault wrote: > Richard Braun, le Tue 12 Nov 2013 11:56:05 +0100, a écrit : > > It's not a rotation, merely a variable swap, > > Ok, but below the comment says > > /* Node is the left child of its parent. */ > > If node is not always updated at

Re: [PATCH] libports: implement lockless management of threads

2013-11-12 Thread Justus Winter
Quoting Neal H. Walfield (2013-11-11 22:02:46) > Yes, this is what I was thinking of. Awesome :) > I recall there being type defs for appropriate atomic types. If that > is still the recommended approach, please update your patch > appropriately. Right. I knew next to nothing about the gcc atom

Removal of register qualifiers from kern source

2013-11-12 Thread Marin Ramesa
Hello, Attached is a gzipped series of 32 patches which remove register qualifiers from kern source. I did not want to spam the list with 32 patches, so I'm sending them as an attachment. kern_remove_register.tar.gz Description: application/compressed-tar

Re: Pthread conformance issue with main thread

2013-11-12 Thread Richard Braun
On Tue, Nov 12, 2013 at 02:34:18PM +0100, Richard Braun wrote: > Right, I misread the specification, thanks for correcting. FYI, this means we currently have a bug with regard to that : after the main thread calls pthread_exit(), and thread destruction is actually implemented (as opposed to the cu

Re: Pthread conformance issue with main thread

2013-11-12 Thread Richard Braun
On Tue, Nov 12, 2013 at 12:42:45PM +0100, Samuel Thibault wrote: > Uh? It mandates that if the main() function returns, exit() is called, > and thus the whole process exits. But if main() calls pthread_exit(), > only the thread is terminated, not the whole process. I don't see > anything saying

Re: Pthread conformance issue with main thread

2013-11-12 Thread Samuel Thibault
Richard Braun, le Tue 12 Nov 2013 12:02:28 +0100, a écrit : > all diskfs translators, exit from the main thread after initialization. > But POSIX mandates that exiting from the main thread makes the whole > process exit too. Uh? It mandates that if the main() function returns, exit() is called, a

Re: [PATCH 2/5] kern (rbtree_insert_rebalance): rewrite node swap

2013-11-12 Thread Samuel Thibault
Richard Braun, le Tue 12 Nov 2013 11:56:05 +0100, a écrit : > On Sun, Nov 10, 2013 at 11:00:26PM +0100, Samuel Thibault wrote: > > Marin Ramesa, le Sun 10 Nov 2013 22:50:21 +0100, a écrit : > > > Value of node is never read. Simplify the node swap to one assignment > > > and remove the temporary va

Pthread conformance issue with main thread

2013-11-12 Thread Richard Braun
Hello, As part of my work on thread destruction, I noticed that some servers, all diskfs translators, exit from the main thread after initialization. But POSIX mandates that exiting from the main thread makes the whole process exit too. My intention is to first fix the Hurd servers involved and th

Re: [PATCH 2/5] kern (rbtree_insert_rebalance): rewrite node swap

2013-11-12 Thread Richard Braun
On Sun, Nov 10, 2013 at 11:00:26PM +0100, Samuel Thibault wrote: > Marin Ramesa, le Sun 10 Nov 2013 22:50:21 +0100, a écrit : > > Value of node is never read. Simplify the node swap to one assignment > > and remove the temporary variable. > > > > * kern/rbtree.c (rbtree_insert_rebalance): Simplify