Re: [PATCH 4/8] Quiet GCC warnings about set but unused variables

2013-12-12 Thread Marin Ramesa
On 12.12.2013 01:31:06, Richard Braun wrote: On Wed, Dec 11, 2013 at 09:07:38PM +0100, Marin Ramesa wrote: On 11.12.2013 18:02:50, Richard Braun wrote: On Wed, Dec 11, 2013 at 05:30:43PM +0100, Marin Ramesa wrote: - ipc_mqueue_t mqueue; + ipc_mqueue_t mqueue = mqueue; /*

manual photo editing Gimp Image Editor 2.8

2013-12-12 Thread hkouwenhoven
Dear Sir, I would love to edit photos with Gimp 2.8 Greetings, Hans Louwenhoven

[PATCH 1/6] ddb/db_break.c (db_find_breakpoint_here): remove unnecessary casts

2013-12-12 Thread Marin Ramesa
Variable addr and member address are already of db_addr_t type which is type defined as vm_offset_t. * ddb/db_break.c (db_find_breakpoint_here) (DB_PHYS_EQ) (addr, address): Remove unecessary casts. --- ddb/db_break.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 2/6] kern/lock.h: quiet GCC warnings about set but unused variables

2013-12-12 Thread Marin Ramesa
This is a better version of these two patches: http://lists.gnu.org/archive/html/bug-hurd/2013-12/msg6.html http://lists.gnu.org/archive/html/bug-hurd/2013-12/msg00375.html It uses an empty structure to represent a lock when !MACH_SLOCKS and a modified simple_unlock() to quiet GCC warnings

[PATCH 4/6] ddb/db_break.c (db_delete_cmd): remove unnecessary initialization

2013-12-12 Thread Marin Ramesa
Now that we have returns there are no more warnings from GCC about uninitialized variable. Remove unnecessary initialization of variable bkpt. * ddb/db_break.c (db_delete_cmd) (bkpt): Remove unnecessary initialization. --- ddb/db_break.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH 3/6] ddb/db_break.c (db_delete_cmd): add missing returns

2013-12-12 Thread Marin Ramesa
There is a code path when db_error() can return. Avoid, by writing returns, deleting the breakpoint when breakpoint number is not valid or there is no such breakpoint. * ddb/db_break.c (db_delete_cmd): Add missing returns. --- ddb/db_break.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

[PATCH 6/6] i386/i386/db_trace.c (db_i386_reg_value): cast to (int *) instead to (long *)

2013-12-12 Thread Marin Ramesa
This quiets the GCC warning about passing from incompatible pointer type. * i386/i386/db_trace.c (db_i386_reg_value) (db_lookup_i386_kreg) (STACK_IKS): Cast to (int *) instead to (long *). --- i386/i386/db_trace.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 5/6] ddb/db_expr.c (db_mult_expr): initialize lhs

2013-12-12 Thread Marin Ramesa
Initialize lhs to zero to avoid uninitialized usage in db_unary(). * ddb/db_expr.c (db_mult_expr) (lhs): Initialize to zero. --- ddb/db_expr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ddb/db_expr.c b/ddb/db_expr.c index eee9e4f..82ada58 100644 --- a/ddb/db_expr.c +++