Re: [PATCH] Make STARTUP_WITH_SHELL a runtime toggle -- add new set/show startup-with-shell option.

2014-01-09 Thread Pedro Alves
On 01/08/2014 09:20 PM, Thomas Schwinge wrote: Hi! On Thu, 24 Oct 2013 16:17:21 +0100, Pedro Alves pal...@redhat.com wrote: Here's what I pushed ..., and what made the Hurd port pretty unhappy. ;-) Whoops. ;-) Thanks for fixing. In the thread around

Re: [RFC] kern: simple futex for gnumach (version 11)

2014-01-09 Thread Richard Braun
On Wed, Jan 08, 2014 at 08:43:28PM +0100, Marin Ramesa wrote: As far the code is concerned I bypassed the opacity of red-black tree structures in two places, as I always get a segfault somewhere in the rbtree module. If you need to do that, it's very likely you're not using it correctly.

Re: [RFC] kern: simple futex for gnumach (version 11)

2014-01-09 Thread Marin Ramesa
On 01/09/2014 03:45:35 PM, Richard Braun wrote: +/* TODO Should be per-task. */ +static struct futex *pfutexes; Most locks are private, so yes, do work on that too. I actually did not implement this because I don't know how. How to make a variable visible only and private to a task? I tried

Re: [RFC] kern: simple futex for gnumach (version 11)

2014-01-09 Thread Diego Nieto Cid
Hi I don't really know about futexes so I will only comment on C language stuff. 2014/1/8 Marin Ramesa m...@hi.t-com.hr + +static unsigned long futex_init(task_t task, vm_offset_t address, boolean_t private_futex, struct futex *futex) +{ + unsigned long node_slot = 0; + +

Re: [RFC] kern: simple futex for gnumach (version 11)

2014-01-09 Thread Richard Braun
On Thu, Jan 09, 2014 at 02:36:18PM -0200, Diego Nieto Cid wrote: 2014/1/8 Marin Ramesa m...@hi.t-com.hr + +static unsigned long futex_init(task_t task, vm_offset_t address, boolean_t private_futex, struct futex *futex) +{ + unsigned long node_slot = 0; + + futex =

Re: [RFC] kern: simple futex for gnumach (version 11)

2014-01-09 Thread Richard Braun
On Thu, Jan 09, 2014 at 05:06:09PM +0100, Marin Ramesa wrote: On 01/09/2014 03:45:35 PM, Richard Braun wrote: +/* TODO Should be per-task. */ +static struct futex *pfutexes; Most locks are private, so yes, do work on that too. I actually did not implement this because I don't know how.

Re: [RFC] kern: simple futex for gnumach (version 11)

2014-01-09 Thread Richard Braun
On Thu, Jan 09, 2014 at 05:52:21PM +0100, Richard Braun wrote: On Thu, Jan 09, 2014 at 05:06:09PM +0100, Marin Ramesa wrote: +simple_lock(futex_shared_lock); + +thread_timeout_setup(current_thread()); +

Bug#734764: /usr/share/X11/xkb/compat/default was missing

2014-01-09 Thread Cong Zhang
Package: xkb-data Version: 2.10.1-1 Severity: important Tags: upstream After insall debian hurd from mini.iso in qemu with kvm enable, when system boot, it show can't open file compat/default, and X can't start. I copy one /usr/share/X11/xkb/compat/default from debian wheezy, and then it

Re: glibc: ELF_MACHINE_USER_ADDRESS_MASK, sysdeps/mach/hurd/dl-sysdep.c:fmh

2014-01-09 Thread Roland McGrath
Hi Roland! Hi Thomas of the past! I'm culling old unanswered messages and I can't always tell which ones are still relevant. So ignore if not helpful. Richard et moi, we wondered what ELF_MACHINE_USER_ADDRESS_MASK »Mask identifying addresses reserved for the user program, where the dynamic

Re: [RFC] kern: simple futex for gnumach (version 11)

2014-01-09 Thread Richard Braun
On Thu, Jan 09, 2014 at 09:51:51PM +0100, Marin Ramesa wrote: On 01/09/2014 05:52:21 PM, Richard Braun wrote: On Thu, Jan 09, 2014 at 05:06:09PM +0100, Marin Ramesa wrote: Shouldn't the compare be atomic. Maybe I don't understand what atomic really means but the GCC manual says this

Re: [RFC] kern: simple futex for gnumach (version 11)

2014-01-09 Thread Marin Ramesa
On 01/10/2014 01:59:55 AM, Richard Braun wrote: On Thu, Jan 09, 2014 at 09:51:51PM +0100, Marin Ramesa wrote: On 01/09/2014 05:52:21 PM, Richard Braun wrote: On Thu, Jan 09, 2014 at 05:06:09PM +0100, Marin Ramesa wrote: Shouldn't the compare be atomic. Maybe I don't understand what atomic

Re: [RFC] kern: simple futex for gnumach (version 11)

2014-01-09 Thread Marin Ramesa
On 01/09/2014 05:36:18 PM, Diego Nieto Cid wrote: Finally, why is pfutexes an array? You are always using it's last element (that is if the ARRAY_SIZE macro worked as intended). I was actually not using it, so I didn't notice the bug while testing. Thanks for the comments, the code has been