Re: [PATCH 4/5] libports: avoid realloc(3) corner case

Justus Winter, le Mon 16 Jun 2014 19:49:28 +0200, a écrit : > If the size argument is 0, realloc may either return NULL, or return a > pointer that is only valid for use with free(3). In either case, the > memory is freed. So if realloc would return NULL (it does not on > GNU), the current code w

Re: [PATCH 5/5] libdiskfs: add permission check to file_chflags

Justus Winter, le Mon 16 Jun 2014 19:49:29 +0200, a écrit : > Only root is allowed to change the high 16 bits. The TODO entry says > otherwise, but that must be a mistake. For reference, see the glibc > sources, sysdeps/mach/hurd/bits/stat.h. > > * libdiskfs/file-chflags.c (diskfs_S_file_chflags

Re: [PATCH 2/5] libshouldbeinlibc: fix dead initialization in fmt_named_interval

Justus Winter, le Mon 16 Jun 2014 19:49:26 +0200, a écrit : > Found using the Clang Static Analyzer. > > * libshouldbeinlibc/timefmt.c (fmt_named_interval): Fix dead > initialization. Ack. > --- > libshouldbeinlibc/timefmt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --gi

Re: [PATCH 3/5] trans/fakeroot: fix error handling

Justus Winter, le Mon 16 Jun 2014 19:49:27 +0200, a écrit : > Found using the Clang Static Analyzer. > > * trans/fakeroot.c (new_node): Do not leak a pointer to freed memory. > Store NULL at *np instead. This fixes a node use-after-free in > netfs_S_dir_lookup. Ack. > --- > trans/fakeroot.c |

Re: [PATCH 1/5] ftpfs: fix error handling in refresh_dir

Justus Winter, le Mon 16 Jun 2014 19:49:25 +0200, a écrit : > Found using the Clang Static Analyzer. Ack. > * ftpfs/dir.c (refresh_dir): Fix error handling. > --- > ftpfs/dir.c | 20 > 1 file changed, 12 insertions(+), 8 deletions(-) > > diff --git a/ftpfs/dir.c b/ftpfs/dir

Re: [PATCH] Add mach_debug defs rules

David Michael, le Mon 16 Jun 2014 15:08:06 -0400, a écrit : > The hard-coded /usr/include vpath will break building with sysroot > headers. Can the mach_debug defs files be handled like the others? Indeed, applied. Thanks, Samuel

Re: [PATCH] sutils: add random device targets to MAKEDEV

Pino Toscano, le Tue 17 Jun 2014 22:00:57 +0200, a écrit : > On Tuesday 17 June 2014 18:33:56 Justus Winter wrote: > > > (I'm not married to the seed file argument, in case there is a > > > better default location for it.) > > > > For the record, Debian uses /var/spool/random-seed. > > Not really

Re: [PATCH] sutils: add random device targets to MAKEDEV

On Tuesday 17 June 2014 18:33:56 Justus Winter wrote: > > (I'm not married to the seed file argument, in case there is a > > better default location for it.) > > For the record, Debian uses /var/spool/random-seed. Not really, see /etc/init.d/urandom. So far known locations on Linux distributions

Re: [PATCH] sutils: add random device targets to MAKEDEV

Hi, On Tue, Jun 17, 2014 at 12:33 PM, Justus Winter <4win...@informatik.uni-hamburg.de> wrote: > Quoting David Michael (2014-06-16 21:08:19) >> (I'm not married to the seed file argument, in case there is a >> better default location for it.) > > For the record, Debian uses /var/spool/random-seed.

Re: [PATCH] Add mach_debug defs rules

Quoting David Michael (2014-06-16 21:08:06) > * Makeconf (mach_debug_defs_names,mach_debug_defs): New variables. > * Makeconf: Add rule to generate local $(mach_debug_defs) files. > * procfs/Makefile: Remove vpath for mach_debug defs. > --- > > Hi, > > The hard-coded /usr/include vpath will break

Re: [PATCH] sutils: add random device targets to MAKEDEV

Quoting David Michael (2014-06-16 21:08:19) > * sutils/MAKEDEV.sh (random,urandom): New targets. > (std): Add random and urandom to the standard devices list. > --- > > Hi, > > With the random merge, can /dev/(u)random devices now be added to > MAKEDEV? Yes. > (I'm not married to the seed file