Re: RFC: [PATCH] trans/fakeroot.c

2015-10-11 Thread Samuel Thibault
The commit I have just pushed, which does make sense, does fix gpsd at least. Samuel

Re: RFC: [PATCH] trans/fakeroot.c

2015-10-11 Thread Samuel Thibault
Svante Signell, le Sun 11 Oct 2015 23:02:16 +0200, a écrit : > > We also see from the printout that > > nn->openmodes = 2 = O_WRITE and > > newmodes = 1 = O_READ i.e. no intersecting sets. > > > > The above condition is really happening when building (patched to > build, not related to fakeroot)

Re: RFC: [PATCH] trans/fakeroot.c

2015-10-11 Thread Svante Signell
On Thu, 2015-05-21 at 10:56 +0200, Svante Signell wrote: > On Fri, 2015-05-15 at 20:31 +0200, Samuel Thibault wrote: > > Svante Signell, le Tue 12 May 2015 09:15:46 +0200, a écrit : > > > > - if (file != MACH_PORT_NULL && (nn->openmodes & ~newmodes)) > > > + if (file != MACH_PORT_NULL &&

Re: [PATCH] hurd: align -p and -pg behavior on Linux

2015-10-11 Thread Samuel Thibault
Ping? (I don't have commit access) Samuel Thibault, le Sat 19 Sep 2015 14:00:23 +0200, a écrit : > On Linux, -p and -pg do not make gcc link against libc_p.a, only > -profile does (as documented in r11246), and thus people expect -p > and -pg to work without libc_p.a installed (it is actually eve

Re: Meta: Three-phase patch review

2015-10-11 Thread Justus Winter
Quoting Olaf Buddenhagen (2015-10-06 05:56:51) > I just stumbled upon this, and it seems to me the Hurd project could > benefit from this approach: > >http://sarah.thesharps.us/2014/09/01/the-gentle-art-of-patch-review/ I like it, and I agree with it. I'm a bit curious however why you brough