Hi! On Sun, 10 Feb 2019 20:51:39 +0100, Uros Bizjak <ubiz...@gmail.com> wrote: > On Fri, Feb 8, 2019 at 1:24 PM Uros Bizjak <ubiz...@gmail.com> wrote: > > Attached patch fixes --enable-frame-pointer handling [...]
ACK. > Please note that this fix will re-enable frame pointer for all targets > but linux* or darwin[[8912]]. However, since builds for e.g. cygwin > and mingw survived just well without frame pointers in the mean time, > we should probably list these targets as targets without frame > pointers by default. I agree, this would cause the least surprise, to simply keep the previous default of '--disable-frame-pointer'. Until such a global change is agreed on, and made... > Maintainers should decide. The GNU/Hurd maintainer has decided (and also made a decision for GNU/k*BSD); committed the attached to trunk in r271028. Grüße Thomas
From 679a49952fe543043047267cc8500c5cc1065b7b Mon Sep 17 00:00:00 2001
From: tschwinge <tschwinge@138bc75d-0d04-0410-961f-82ee72b054a4>
Date: Thu, 9 May 2019 09:51:59 +0000
Subject: [PATCH] [PR89221] Continue to default to '--disable-frame-pointer'
for x86 GNU systems
The recent trunk r270914 for PR89221 "--enable-frame-pointer does not work as
intended" fixed a scripting defect in the x86 '--enable-frame-pointer'
handling.
This has the side effect that, for example, for '--target=i686-gnu' this is now
enabled by default: 'USE_IX86_FRAME_POINTER=1' is added to 'tm_defines'. Given
that it's highly unlikely that anyone would now suddenly want
'--enable-frame-pointer' as the default for any kind of GNU system, I'm
changing the default back for GNU systems, to match that of a 'target_os' of
'linux* | darwin[8912]*'.
gcc/
PR target/89221
* configure.ac (--enable-frame-pointer): Disable by default for
GNU systems.
* configure: Regenerate.
git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@271028 138bc75d-0d04-0410-961f-82ee72b054a4
---
gcc/ChangeLog | 7 +++++++
gcc/configure | 4 ++--
gcc/configure.ac | 4 ++--
3 files changed, 11 insertions(+), 4 deletions(-)
diff --git a/gcc/ChangeLog b/gcc/ChangeLog
index 37447f854c0..ea96146b5b8 100644
--- a/gcc/ChangeLog
+++ b/gcc/ChangeLog
@@ -1,3 +1,10 @@
+2019-05-09 Thomas Schwinge <tho...@codesourcery.com>
+
+ PR target/89221
+ * configure.ac (--enable-frame-pointer): Disable by default for
+ GNU systems.
+ * configure: Regenerate.
+
2019-05-09 Alan Modra <amo...@gmail.com>
PR target/89271
diff --git a/gcc/configure b/gcc/configure
index 08cce6f1980..947d263a617 100755
--- a/gcc/configure
+++ b/gcc/configure
@@ -12197,8 +12197,8 @@ if test "${enable_frame_pointer+set}" = set; then :
else
case $target_os in
-linux* | darwin[8912]*)
- # Enable -fomit-frame-pointer by default for Linux and Darwin with DWARF2.
+linux* | gnu* | darwin[8912]*)
+ # Enable -fomit-frame-pointer by default for these systems with DWARF2.
enable_frame_pointer=no
;;
*)
diff --git a/gcc/configure.ac b/gcc/configure.ac
index 7c526b9ada4..bfcdf526e44 100644
--- a/gcc/configure.ac
+++ b/gcc/configure.ac
@@ -1884,8 +1884,8 @@ AC_ARG_ENABLE(frame-pointer,
[enable -fno-omit-frame-pointer by default for x86])], [],
[
case $target_os in
-linux* | darwin[[8912]]*)
- # Enable -fomit-frame-pointer by default for Linux and Darwin with DWARF2.
+linux* | gnu* | darwin[[8912]]*)
+ # Enable -fomit-frame-pointer by default for these systems with DWARF2.
enable_frame_pointer=no
;;
*)
--
2.17.1
signature.asc
Description: PGP signature
