Hello,
Uploaded fixed netdde, pciutils, libpciaccess, and commited this
pci-arbiter cleanup!
Samuel
Samuel Thibault, le dim. 03 nov. 2019 20:42:27 +0100, a ecrit:
> Samuel Thibault, le dim. 03 nov. 2019 20:07:46 +0100, a ecrit:
> > I tried the hack I mentioned previously (attached), to properly detect
> > that we are the PCI arbiter. Now my system boots, but that's because
> > netdde crashes inst
Samuel Thibault, le dim. 03 nov. 2019 20:07:46 +0100, a ecrit:
> I tried the hack I mentioned previously (attached), to properly detect
> that we are the PCI arbiter. Now my system boots, but that's because
> netdde crashes instead of just hanging. It looks like it does not manage
> to use the PCI
Samuel Thibault, le dim. 03 nov. 2019 18:58:57 +0100, a ecrit:
> Joan Lledó via Bug reports for the GNU Hurd, le dim. 03 nov. 2019 18:49:08
> +0100, a ecrit:
> > Take a look at hurd_pci.c:452 [1]
> >
> > /* If we can open pci cfg io ports on hurd,
> > * we are the arbiter, therefore t
Samuel Thibault, le dim. 03 nov. 2019 18:58:57 +0100, a ecrit:
> let the pci arbiter notice that it is connecting to itself,
Except that this is not an easy task, since the translator is starting
and doesn't process messages yet. A hackish way would be to have
pci-arbiter define a variable that th
Joan Lledó via Bug reports for the GNU Hurd, le dim. 03 nov. 2019 18:49:08
+0100, a ecrit:
> El 3/11/19 a les 17:10, Samuel Thibault ha escrit:
> >> +if (!devices)
> >> +return ENOMEM;
> >
> > That makes me realize: we need to closedir(dir).
>
> What do you mean?
Hi,
El 3/11/19 a les 17:10, Samuel Thibault ha escrit:
>> +if (!devices)
>> +return ENOMEM;
>
> That makes me realize: we need to closedir(dir).
What do you mean?
>> if (err) {
>> -mach_port_deallocate (mach_task_self (), pci_server_port);
>> -/*
Joan Lledó, le dim. 03 nov. 2019 18:32:31 +0100, a ecrit:
> El 3/11/19 a les 17:56, Samuel Thibault ha escrit:
> > After applying the patch, my hurd box is stuck at
> >
> > Configuring network interfaces...
>
> Could it be because GNU Mach is restricting the access to io ports to
> one process, a
Hi,
El 3/11/19 a les 17:56, Samuel Thibault ha escrit:
> After applying the patch, my hurd box is stuck at
>
> Configuring network interfaces...
Could it be because GNU Mach is restricting the access to io ports to
one process, and then when netdde tries to access, it can't b/c the
arbiter arri
Joan Lledó via Bug reports for the GNU Hurd, le dim. 03 nov. 2019 10:38:25
+0100, a ecrit:
> This patch removes all embedded pciaccess code from the arbiter
> and instead uses the external pciaccess library.
After applying the patch, my hurd box is stuck at
Configuring network interfaces...
James Clarke, le dim. 03 nov. 2019 16:38:50 +, a ecrit:
> On 3 Nov 2019, at 16:20, Samuel Thibault wrote:
> > Joan Lledó via Bug reports for the GNU Hurd, le dim. 03 nov. 2019
> > 10:38:28 +0100, a ecrit:
> >> @@ -206,7 +208,7 @@ create_fs_tree (struct pcifs * fs)
> >> e_stat = list->
On 3 Nov 2019, at 16:20, Samuel Thibault wrote:
>
> Hello,
>
> Joan Lledó via Bug reports for the GNU Hurd, le dim. 03 nov. 2019 10:38:28
> +0100, a ecrit:
>> * pci-arbiter/pcifs.c:
>>* create_dir_entry:
>> Limit to NAME_SIZE-1 when calling strncpy().
>> Fin
Hello,
Joan Lledó via Bug reports for the GNU Hurd, le dim. 03 nov. 2019 10:38:28
+0100, a ecrit:
> * pci-arbiter/pcifs.c:
> * create_dir_entry:
> Limit to NAME_SIZE-1 when calling strncpy().
> Finish entry->name with '\0'.
> * create_fs_tree:
>
Hello,
Joan Lledó via Bug reports for the GNU Hurd, le dim. 03 nov. 2019 11:00:56
+0100, a ecrit:
> +devices = realloc(pci_sys->devices, (pci_sys->num_devices + 1)
> + * sizeof(struct pci_device_private));
Yes, this looks like a simpler approach. Sure
Hello Hurd,
In order to deprecate pci_get_ndevs(), I think we only need to
ensure neither pciaccess nor pciutil call it.
I wrote this patch for libpciaccess which removes the call, I'm
sending it here for your comments, and will send it to upstream
if you think it's OK.
From: Joan Lledó
---
src/hurd_pci.c | 83 +-
1 file changed, 34 insertions(+), 49 deletions(-)
diff --git a/src/hurd_pci.c b/src/hurd_pci.c
index 28bef16..98bf83e 100644
--- a/src/hurd_pci.c
+++ b/src/hurd_pci.c
@@ -304,8 +304,8 @@ pci_device_hurd
From: Damien Zammit
This patch removes all embedded pciaccess code from the arbiter
and instead uses the external pciaccess library.
* pci-arbiter/Makefile:
* Remove pci_access.c and x86_pci.c from the sources.
* pci-arbiter/func_files.c:
* io_config_file: Use a harcoded PCI conf
From: Joan Lledó
* pci-arbiter/startup-ops.c:
* S_startup_dosync: Call pci_system_cleanup().
---
pci-arbiter/startup-ops.c | 4
1 file changed, 4 insertions(+)
diff --git a/pci-arbiter/startup-ops.c b/pci-arbiter/startup-ops.c
index f3506c42..eb387fd9 100644
--- a/pci-arbiter/start
From: Joan Lledó
* pci-arbiter/netfs_impl.c:
* netfs_attempt_write: Cast op function to pci_io_op_t
---
pci-arbiter/netfs_impl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/pci-arbiter/netfs_impl.c b/pci-arbiter/netfs_impl.c
index 0be8c370..b987a0bc 100644
--- a/p
Strange, the patches were not attached... I send them again.
From: Joan Lledó
* pci-arbiter/pcifs.c:
* create_dir_entry:
Limit to NAME_SIZE-1 when calling strncpy().
Finish entry->name with '\0'.
* create_fs_tree:
memset() to 0 the directory entry.
Limit to NAME_SIZE-1 all call
Hello,
El 27/10/19 a les 16:32, Samuel Thibault ha escrit:> Hello,
> Could you try to split your changes in separate patches?
I splitted the patch into four patches, the first one is the Damien's
original patch adapted to the current head + a changelog.
The other three patches are my changes.
22 matches
Mail list logo
