Re: [PATCH] libmachdev: Install as translator when bootstrapping && fix rumpdisk injection

2020-11-14 Thread Damien Zammit
Hi, On 15/11/20 11:33 am, Damien Zammit wrote: > I will test again without it. It works in both modes with current master! Damien

Re: [PATCH] libmachdev: Install as translator when bootstrapping && fix rumpdisk injection

2020-11-14 Thread Samuel Thibault
Damien Zammit, le dim. 15 nov. 2020 11:33:06 +1100, a ecrit: > On 14/11/20 9:09 pm, Samuel Thibault wrote: > > This looks odd to me. The "@/dev/master:" part should rather be > > dropped way before, by the code that opens /dev/master to access the > > master device port before calling device_open()

Re: [PATCH] libmachdev: Install as translator when bootstrapping && fix rumpdisk injection

2020-11-14 Thread Samuel Thibault
Damien Zammit, le dim. 15 nov. 2020 11:26:03 +1100, a ecrit: > By the way, should we keep the device right stored in struct block_device *bd, > so we can give already open devices the same right? I'm not sure of the details since I haven't been looking at the ports doc for a long time, but AIUI it

Re: [PATCH] libmachdev: Install as translator when bootstrapping && fix rumpdisk injection

2020-11-14 Thread Damien Zammit
Hi, On 14/11/20 9:09 pm, Samuel Thibault wrote: > This looks odd to me. The "@/dev/master:" part should rather be > dropped way before, by the code that opens /dev/master to access the > master device port before calling device_open() on it: the translators > shouldn't have to grok which way they

Re: [PATCH] libmachdev: Install as translator when bootstrapping && fix rumpdisk injection

2020-11-14 Thread Damien Zammit
On 14/11/20 8:17 pm, Samuel Thibault wrote: > Hello, > > Damien Zammit, le sam. 14 nov. 2020 14:37:37 +1100, a ecrit: >> Previous problems mentioned with 2x rumpdisk partitions all fixed. > > Congrats! > > What was the issue? The logic around default behaviour when the device was already ope

Re: [PATCH] libmachdev: Install as translator when bootstrapping && fix rumpdisk injection

2020-11-14 Thread Samuel Thibault
jbra...@dismail.de, le sam. 14 nov. 2020 20:48:07 +, a ecrit: > Are you trying to replace the Hurd's > extfs server with a rump driver? Not exactly: replace the gnumach disk drivers with the rump disk drivers. Samuel

Re: [PATCH] libmachdev: Install as translator when bootstrapping && fix rumpdisk injection

2020-11-14 Thread jbranso
Yeah! AWESOME WORK! Also, what did you just do? Are you trying to replace the Hurd's extfs server with a rump driver? November 14, 2020 4:17 AM, "Samuel Thibault" wrote: > Hello, > > Damien Zammit, le sam. 14 nov. 2020 14:37:37 +1100, a ecrit: > >> Previous problems mentioned with 2x rumpd

Re: [PATCH] libmachdev: Install as translator when bootstrapping && fix rumpdisk injection

2020-11-14 Thread Samuel Thibault
I have simplified rumpdisk's device_open. Samuel

Re: [PATCH] libmachdev: Install as translator when bootstrapping && fix rumpdisk injection

2020-11-14 Thread Samuel Thibault
Samuel Thibault, le sam. 14 nov. 2020 11:09:48 +0100, a ecrit: > Damien Zammit, le sam. 14 nov. 2020 14:37:37 +1100, a ecrit: > > /* BSD name of whole disk device is /dev/wdXd > > - * but we will receive /dev/wdX as the name */ > > + * but we will receive /dev/wdX as the name > > + * or @/dev/mas

Re: [PATCH] libmachdev: Install as translator when bootstrapping && fix rumpdisk injection

2020-11-14 Thread Samuel Thibault
Damien Zammit, le sam. 14 nov. 2020 14:37:37 +1100, a ecrit: > @@ -53,7 +53,7 @@ struct block_data >char name[DISK_NAME_LEN]; /* eg /dev/wd0 */ >off_t media_size; /* total block device size */ >uint32_t block_size; /* size in bytes of 1 sector */ > - bool taken;

Re: pci-arbiter + rumpdisk

2020-11-14 Thread Samuel Thibault
Damien Zammit, le sam. 14 nov. 2020 17:59:30 +1100, a ecrit: > > youpi: pci-arbiter could be exposed as a device name in the master device > > port and the userland pci-arbiter running on /server/bus/pci can try to > > open that > > youpi: just like netdde tries to open eth0 to check whether ther

Re: [PATCH] libmachdev: Install as translator when bootstrapping && fix rumpdisk injection

2020-11-14 Thread Samuel Thibault
Damien Zammit, le sam. 14 nov. 2020 14:37:37 +1100, a ecrit: > /* BSD name of whole disk device is /dev/wdXd > - * but we will receive /dev/wdX as the name */ > + * but we will receive /dev/wdX as the name > + * or @/dev/master:/dev/wdX */ This looks odd to me. The "@/dev/master:" part should ra

Re: [PATCH] libmachdev: Install as translator when bootstrapping && fix rumpdisk injection

2020-11-14 Thread Samuel Thibault
Hello, Damien Zammit, le sam. 14 nov. 2020 14:37:37 +1100, a ecrit: > Previous problems mentioned with 2x rumpdisk partitions all fixed. Congrats! What was the issue? Samuel