Re: [PATCH binutils-gdb] Port GDB to Hurd x86_64.

2024-02-08 Thread Samuel Thibault
Flávio Cruz, le ven. 09 févr. 2024 00:45:05 -0500, a ecrit: > I did a few more tests and GDB seems to recognize the signal handler frame > correctly when backtracking > and listing the frames during a signal. Good :) > Let me know if there's other ways to confirm this is working as intended. Tha

Re: [PATCH gnumach] smp: Fix compile error with missing apboot_addr

2024-02-08 Thread Samuel Thibault
Applied, thanks! Damien Zammit, le ven. 09 févr. 2024 02:11:14 +, a ecrit: > --- > i386/i386/model_dep.h | 5 + > i386/i386/mp_desc.h | 5 - > 2 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/i386/i386/model_dep.h b/i386/i386/model_dep.h > index 095eec9b..5369e288

Re: [PATCH binutils-gdb] Port GDB to Hurd x86_64.

2024-02-08 Thread Flávio Cruz
On Thu, Feb 8, 2024 at 7:09 PM Samuel Thibault wrote: > Flavio Cruz, le dim. 04 févr. 2024 01:43:48 -0500, a ecrit: > > +/* Recognizing signal handler frames. */ > > + > > +/* When the GNU/Hurd libc calls a signal handler, the return address > points > > + inside the trampoline assembly snippe

[PATCH gnumach] smp: Fix compile error with missing apboot_addr

2024-02-08 Thread Damien Zammit
--- i386/i386/model_dep.h | 5 + i386/i386/mp_desc.h | 5 - 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/i386/i386/model_dep.h b/i386/i386/model_dep.h index 095eec9b..5369e288 100644 --- a/i386/i386/model_dep.h +++ b/i386/i386/model_dep.h @@ -28,6 +28,11 @@ #include

Re: [PATCH binutils-gdb] Port GDB to Hurd x86_64.

2024-02-08 Thread Samuel Thibault
Flavio Cruz, le dim. 04 févr. 2024 01:43:48 -0500, a ecrit: > +/* Recognizing signal handler frames. */ > + > +/* When the GNU/Hurd libc calls a signal handler, the return address points > + inside the trampoline assembly snippet. > + > + If the trampoline function name can not be identified,

Re: [PATCH v3 4/4 gnumach] smp: Fix INIT/STARTUP IPI sequence

2024-02-08 Thread Samuel Thibault
Applied, thanks! Damien Zammit, le mer. 07 févr. 2024 05:02:24 +, a ecrit: > TODO: Don't hardcode 0x3000 as the starting eip. > > TESTED: works in qemu > TESTED: works hardware with AMD cpu > --- > i386/i386/mp_desc.c | 15 +++-- > i386/i386/smp.c | 125 +

Re: [PATCH gnumach 2/2] fpu: Fix cpuid feature detection

2024-02-08 Thread Samuel Thibault
Applied both, thanks! Olivier Valentin, le jeu. 08 févr. 2024 17:50:15 +0100, a ecrit: > Make sure to fetch capabilities from cpuid(0xd,0x1) > --- > i386/i386/fpu.c | 11 --- > 1 file changed, 8 insertions(+), 3 deletions(-) > > diff --git a/i386/i386/fpu.c b/i386/i386/fpu.c > index fefe

[PATCH gnumach 2/2] fpu: Fix cpuid feature detection

2024-02-08 Thread Olivier Valentin
Make sure to fetch capabilities from cpuid(0xd,0x1) --- i386/i386/fpu.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/i386/i386/fpu.c b/i386/i386/fpu.c index fefe5e49..4cd31dd9 100644 --- a/i386/i386/fpu.c +++ b/i386/i386/fpu.c @@ -163,6 +163,7 @@ init_fpu(void)

Reinstate a proper computation of the fpu-state size

2024-02-08 Thread Olivier Valentin
My previous patch erroneously aggregated the fpu-state size computation for XSAVES and other XSAVE methods. It turns out that the IA32_XSS can make a difference and that the size has to be read from cpuid(0xD, 0x1) in one case, and cpuid(0xD, 0x0) in the other. First patch is a plain revert, to ma

[PATCH gnumach 1/2] Revert "fpu: Fix cpuid feature detection"

2024-02-08 Thread Olivier Valentin
This reverts commit f8d0f98e80b3d7d9b24fa077818113fb0f4b3970. --- i386/i386/fpu.c | 40 +--- 1 file changed, 25 insertions(+), 15 deletions(-) diff --git a/i386/i386/fpu.c b/i386/i386/fpu.c index 9bf5aecf..fefe5e49 100644 --- a/i386/i386/fpu.c +++ b/i386/i386/f