[PATCH 30/66] i386/i386/user_ldt.c: remove unused variable

* i386/i386/user_ldt.c (acc_type): Remove unused variable. --- i386/i386/user_ldt.c | 12 1 file changed, 12 deletions(-) diff --git a/i386/i386/user_ldt.c b/i386/i386/user_ldt.c index 5c3d323..07be0a0 100644 --- a/i386/i386/user_ldt.c +++ b/i386/i386/user_ldt.c @@ -43,18 +43,6 @@

[PATCH 15/66] device/if_ether.h: remove ifdef

Function ether_sprintf() is used even if KERNEL is not defined. Avoid implicit declaration in that case by removing the ifdef. * device/if_ether.h [KERNEL]: Remove ifdef. --- device/if_ether.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/device/if_ether.h b/device/if_ether.h index

[PATCH 19/66] i386/i386/db_interface.c: use boolean instead of an int

* i386/i386/db_interface.c (kernel_dr): Use boolean instead of an int. --- i386/i386/db_interface.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/i386/i386/db_interface.c b/i386/i386/db_interface.c index a8ac52a..a59ed37 100644 --- a/i386/i386/db_interface.c +++

[PATCH 18/66] device/tty.h, chario.h: move prototype

Now that we have device/chario.h move the chario_init() prototype from device/tty.h to device/chario.h. * device/chario.h (chario_init): Add prototype. * device/device_init.c: Include device/chario.h. * device/tty.h (chario_init): Remove prototype. --- device/chario.h | 2 ++

[PATCH 06/66] ddb/db_output.c: remove call to nonexistent db_printf_enter()

* ddb/db_output.c [db_printf_enter] (db_printf_enter): Remove call to nonexistent function. --- ddb/db_output.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/ddb/db_output.c b/ddb/db_output.c index c08db6f..268de69 100644 --- a/ddb/db_output.c +++ b/ddb/db_output.c @@ -210,9 +210,6 @@

[PATCH 22/66] i386/i386/db_interface.c: remove dead assignment

* i386/i386/db_interface.c (i386_last_kdb_sp): Remove variable. (i386_last_kdb_sp): Remove dead assignment. --- i386/i386/db_interface.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/i386/i386/db_interface.c b/i386/i386/db_interface.c index ac75e03..568c855 100644 ---

[PATCH 34/66] i386/i386at/model_dep.c, kd.c: use boolean instead of an int

* i386/i386at/kd.c (rebootflag): Use boolean instead of an int. Remove duplicate variable declaration. * i386/i386at/model_dep.c (rebootflag): Use boolean instead of an int. --- i386/i386at/kd.c| 3 +-- i386/i386at/model_dep.c | 4 ++-- 2 files changed, 3 insertions(+), 4 deletions(-)

[PATCH 25/66] i386/i386/mp_desc.c: remove dead assignment

* i386/i386/mp_desc.c (mp_desc_table): Remove variable. (mp_desc_table): Remove dead assignment. * i386/i386/mp_desc.h (mp_desc_table): Remove declaration. --- i386/i386/mp_desc.c | 6 -- i386/i386/mp_desc.h | 5 - 2 files changed, 11 deletions(-) diff --git a/i386/i386/mp_desc.c

[PATCH 49/66] ipc/port.h: update comment

This is ipc/port.h. Not ipc/ipc_port.h. * ipc/port.h: Update comment. --- ipc/port.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ipc/port.h b/ipc/port.h index 6e9f77b..d6fb59b 100644 --- a/ipc/port.h +++ b/ipc/port.h @@ -29,7 +29,7 @@ /* */ /* - * File:

[PATCH 59/66] kern/priority.c: update comment

This is priority.c. Not clock_prim.c. * kern/priority.c: Update comment. --- kern/priority.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kern/priority.c b/kern/priority.c index ddb8fd6..d9ded85 100644 --- a/kern/priority.c +++ b/kern/priority.c @@ -27,7 +27,7 @@ * the

[PATCH 53/66] kern/debug.c: initialize panicstr

Variable that keeps the panic string. Initialize to NULL, meaning that the initial condition is that there is no panic string. * kern/debug.c (panicstr): Initialize to NULL. --- kern/debug.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kern/debug.c b/kern/debug.c index

[PATCH 20/66] i386/i386/db_interface.c: remove dead assignment

* i386/i386/db_interface.c (i386_last_saved_statep): Remove variable. (i386_last_saved_statep): Remove dead assignment. --- i386/i386/db_interface.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/i386/i386/db_interface.c b/i386/i386/db_interface.c index a59ed37..23a66dd 100644 ---

[PATCH 29/66] i386/i386/trap.c: remove unused variables

* i386/i386/trap.c (v86_assist_on, v86_unsafe_ok, v86_do_sti_cli, v86_do_sti_immediate, cli_count, sti_count): Remove unused variables. --- i386/i386/trap.c | 11 --- 1 file changed, 11 deletions(-) diff --git a/i386/i386/trap.c b/i386/i386/trap.c index ffb23bb..239c853 100644 ---

[PATCH 24/66] i386/i386/mp_desc.c: remove unused variable

* i386/i386/mp_desc.c (avail_start): Remove unused variable. --- i386/i386/mp_desc.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/i386/i386/mp_desc.c b/i386/i386/mp_desc.c index efdc3ee..5ede8f1 100644 --- a/i386/i386/mp_desc.c +++ b/i386/i386/mp_desc.c @@ -65,12 +65,6 @@ char

[PATCH 27/66] i386/i386/pit.c: remove unused variables

* i386/i386/pit.c (pitctr1_port, pitctr2_port): Remove unused variables. --- i386/i386/pit.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/i386/i386/pit.c b/i386/i386/pit.c index 4f156d8..85929e9 100644 --- a/i386/i386/pit.c +++ b/i386/i386/pit.c @@ -57,8 +57,6 @@ WITH THE USE OR

[PATCH 26/66] i386/i386/pic.c: remove unused variables

* i386/i386/pic.c (nintr, npics): Remove unused variables. --- i386/i386/pic.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/i386/i386/pic.c b/i386/i386/pic.c index 50ca150..75cb835 100644 --- a/i386/i386/pic.c +++ b/i386/i386/pic.c @@ -62,9 +62,6 @@ int curr_pic_mask; int

[PATCH 48/66] ipc/mach_port.c: use boolean instead of an int

* ipc/mach_port.c (mach_port_deallocate_debug): Use boolean instead of an int. --- ipc/mach_port.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ipc/mach_port.c b/ipc/mach_port.c index 46cb4de..e1d9419 100644 --- a/ipc/mach_port.c +++ b/ipc/mach_port.c @@ -555,7 +555,7 @@

[PATCH 28/66] i386/i386/trap.c: remove unused variable

* i386/i386/trap.c (brb): Remove unused variable. --- i386/i386/trap.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/i386/i386/trap.c b/i386/i386/trap.c index 89d1f3d..ffb23bb 100644 --- a/i386/i386/trap.c +++ b/i386/i386/trap.c @@ -151,9 +151,6 @@ char *trap_name(unsigned int trapnum)

[PATCH 54/66] kern/debug.c: remove unused variable

* kern/debug.c (__stack_chk_guard): Remove unused variable. --- kern/debug.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/kern/debug.c b/kern/debug.c index 8cd3f02..d3ae4fa 100644 --- a/kern/debug.c +++ b/kern/debug.c @@ -205,13 +205,6 @@ log(int level, const char *fmt, ...)

[PATCH 31/66] i386/i386at/com.c: simplify code

Variable comtimer_active is used uninitialized. What's the chance of this variable getting the value FALSE? I suggest a removal of the code that deals with this variable. But, on the other hand, this may not be a good solution. Maybe the variable should be initialized to FALSE, meaning that the

[PATCH 60/66] kern/rbtree.h: remove unnecessary include

File kern/rbtree.h includes itself. Remove this include. * kern/rbtree.h: Don't include kern/rbtree.h. --- kern/rbtree.h | 1 - 1 file changed, 1 deletion(-) diff --git a/kern/rbtree.h b/kern/rbtree.h index 5a65d1e..f577f7e 100644 --- a/kern/rbtree.h +++ b/kern/rbtree.h @@ -32,7 +32,6 @@

[PATCH 33/66] i386/i386at/immc.c, kd.c: use boolean instead of an int

* i386/i386at/immc.c (immediate_console_enable): Use boolean instead of an int. * i386/i386at/kd.c (immediate_console_enable): Likewise. --- i386/i386at/immc.c | 2 +- i386/i386at/kd.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/i386/i386at/immc.c

[PATCH 45/66] i386/intel/pmap.c: use boolean instead of an int

* i386/intel/pmap.c (pmap_debug): Use boolean instead of an int. --- i386/intel/pmap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/i386/intel/pmap.c b/i386/intel/pmap.c index 3e2e6ba..69a58ed 100644 --- a/i386/intel/pmap.c +++ b/i386/intel/pmap.c @@ -384,7 +384,7 @@

[PATCH 44/66] i386/i386at/rtc.c: remove unused variable

* i386/i386at/rtc.c (tz): Remove unused variable. --- i386/i386at/rtc.c | 1 - 1 file changed, 1 deletion(-) diff --git a/i386/i386at/rtc.c b/i386/i386at/rtc.c index 2115f23..98f157f 100644 --- a/i386/i386at/rtc.c +++ b/i386/i386at/rtc.c @@ -103,7 +103,6 @@ unsigned char *regs;

[PATCH 42/66] i386/i386at/lpr.c: remove uninitialized variable

Variable lpr_alive is never initialized. I suggest a removal of the code that deals with this variable. But, on the other hand, maybe the variable should be initialized to all zero. It's not so clear from the code. * i386/i386at/lpr.c (lpr_alive): Remove variable. Remove the if. ---

[PATCH 32/66] i386/i386at/com.c: remove dead assignment

* i386/i386at/com.c (comtimer_state): Remove variable. (comtimer_state): Remove dead assignment. --- i386/i386at/com.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/i386/i386at/com.c b/i386/i386at/com.c index 62aa85c..2df6682 100644 --- a/i386/i386at/com.c +++ b/i386/i386at/com.c @@ -64,7

[PATCH 40/66] i386/i386at/kd.h: remove ifdef

Variable key_map is used even if KERNEL is not defined. Remove ifdef. * i386/i386at/kd.h [KERNEL]: Remove ifdef. --- i386/i386at/kd.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/i386/i386at/kd.h b/i386/i386at/kd.h index b29a5bf..4d1ab7f 100644 --- a/i386/i386at/kd.h +++

[PATCH 46/66] i386/intel/pmap.c: remove unused variable

* i386/intel/pmap.c (end): Remove unused variable. --- i386/intel/pmap.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/i386/intel/pmap.c b/i386/intel/pmap.c index 69a58ed..d3e77ed 100644 --- a/i386/intel/pmap.c +++ b/i386/intel/pmap.c @@ -395,8 +395,6 @@ int ptes_per_vm_page;

[PATCH 55/66] kern/lock_mon.c: remove unused variable

* kern/lock_mon.c (default_lock_stack): Remove unused variable. --- kern/lock_mon.c | 1 - 1 file changed, 1 deletion(-) diff --git a/kern/lock_mon.c b/kern/lock_mon.c index 80c50b5..0f86735 100644 --- a/kern/lock_mon.c +++ b/kern/lock_mon.c @@ -83,7 +83,6 @@ struct lock_info_bucket { struct

[PATCH 50/66] kern/act.c, act.h: comment unused variable

* kern/act.c (null_act): Comment unused variable. * kern/act.h (null_act): Likewise. --- kern/act.c | 2 +- kern/act.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/kern/act.c b/kern/act.c index 321ff98..61b982e 100644 --- a/kern/act.c +++ b/kern/act.c @@ -61,7 +61,7 @@

[PATCH 51/66] kern/act.h: remove prototype without definition

* kern/act.h (act_create_kernel): Remove prototype without definition. --- kern/act.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/kern/act.h b/kern/act.h index cddf6c7..9175211 100644 --- a/kern/act.h +++ b/kern/act.h @@ -174,9 +174,7 @@ voidact_init(void); /* Exported

[PATCH 52/66] kern/debug.c: initialize the lock

* kern/debug.c (Assert_print_lock): Initialize the lock. --- kern/debug.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/kern/debug.c b/kern/debug.c index 33e64f3..bdc87e2 100644 --- a/kern/debug.c +++ b/kern/debug.c @@ -45,7 +45,7 @@ extern int db_breakpoints_inserted;

[PATCH 47/66] ipc/ipc_init.c: qualify constant with const

* ipc/ipc_init.c (ipc_kernel_map_size): Qualify constant with const. --- ipc/ipc_init.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ipc/ipc_init.c b/ipc/ipc_init.c index ca7e791..a7e9ec1 100644 --- a/ipc/ipc_init.c +++ b/ipc/ipc_init.c @@ -54,7 +54,7 @@ static struct

[PATCH 58/66] kern/pc_sample.c: remove unused variables

* kern/pc_sample.c (pc_sampling_enabled, pc_sampling_lock): Remove unused variables. --- kern/pc_sample.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/kern/pc_sample.c b/kern/pc_sample.c index 05c08b8..cdf8e95 100644 --- a/kern/pc_sample.c +++ b/kern/pc_sample.c @@ -43,9 +43,6 @@

[PATCH 56/66] kern/lock_mon.c: use spl_t instead of an int

Variable curr_ipl is in other files declared as spl_t. * kern/lock_mon.c (curr_ipl): Use spl_t instead of an int. --- kern/lock_mon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kern/lock_mon.c b/kern/lock_mon.c index 0f86735..d126c69 100644 --- a/kern/lock_mon.c +++

[PATCH 23/66] i386/i386/ipl.h: remove ifdef and add ifndef

This code is used even if KERNEL is not defined. Remove the ifdef. * i386/i386/ipl.h [KERNEL]: Remove ifdef. [_I386_IPL_H_]: Add ifndef. --- i386/i386/ipl.h | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/i386/i386/ipl.h b/i386/i386/ipl.h index 8f729e1..7503ac3 100644

[PATCH 07/66] ddb/db_output.c: remove duplicate function

Function kdbprintf() and db_printf() are the same function. Remove kdbprintf() and define kdbprintf to db_printf. * ddb/db_output.c (kdbprintf): Remove function. * ddb/db_output.h: Define kdbprintf to db_printf. (kdbprintf): Remove prototype. --- ddb/db_output.c | 12

[PATCH 64/66] Cleanup of the prototypes

* device/cirbuf.h (nqdb): Remove prototype without definition. * device/conf.h (dev_set_indirect): Likewise. * kern/boot_script.h (boot_script_read_file): Likewise. * kern/eventcount.h (evc_notify_abort): Remove duplicate prototype. * kern/thread.h (thread_set_own_priority): Likewise. *

[PATCH 12/66] device/cons.h: remove ifdef

Field constab is used even if KERNEL is not defined. Remove the ifdef. * device/cons.h [KERNEL]: Remove ifdef. --- device/cons.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/device/cons.h b/device/cons.h index 8ac796c..d569a8f 100644 --- a/device/cons.h +++ b/device/cons.h @@ -43,9

[PATCH 65/66] kern/act.h: remove unnecessary include

File kern/act.h includes itself. Remove this include. * kern/act.h: Don't include kern/act.h. --- kern/act.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/kern/act.h b/kern/act.h index 9175211..5ae4b9d 100644 --- a/kern/act.h +++ b/kern/act.h @@ -40,8 +40,6 @@ #include kern/refcount.h

[PATCH 63/66] vm/vm_page.h: remove unused variables

* vm/vm_page.h (first_phys_addr, last_phys_addr): Remove unused variables. --- vm/vm_page.h | 5 - 1 file changed, 5 deletions(-) diff --git a/vm/vm_page.h b/vm/vm_page.h index 4536d1c..f5681d7 100644 --- a/vm/vm_page.h +++ b/vm/vm_page.h @@ -156,11 +156,6 @@ extern queue_head_t

[PATCH 57/66] kern/lock_mon.c: remove dead assignments

* kern/lock_mon.c (scurval, ssum, sli): Remove variables. (scurval, ssum, sli): Remove dead assignments. --- kern/lock_mon.c | 5 - 1 file changed, 5 deletions(-) diff --git a/kern/lock_mon.c b/kern/lock_mon.c index d126c69..cc8c36c 100644 --- a/kern/lock_mon.c +++ b/kern/lock_mon.c @@

[PATCH 21/66] i386/i386/db_interface.c: remove dead assignment

* i386/i386/db_interface.c (i386_nested_saved_state): Remove variable. (i386_nested_saved_state): Remove dead assignment. --- i386/i386/db_interface.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/i386/i386/db_interface.c b/i386/i386/db_interface.c index 23a66dd..ac75e03 100644 ---

[PATCH 13/66] device/dev_lookup.c: remove unused lock

* device/dev_lookup.c (dev_port_lock): Remove unused lock. --- device/dev_lookup.c | 4 1 file changed, 4 deletions(-) diff --git a/device/dev_lookup.c b/device/dev_lookup.c index 01317b9..0c2198e 100644 --- a/device/dev_lookup.c +++ b/device/dev_lookup.c @@ -242,8 +242,6 @@

[PATCH 41/66] i386/i386at/kd.h: remove ifdef

Variable kb_mode is used even if KERNEL is not defined. Remove ifdef. * i386/i386at/kd.h [KERNEL]: Remove ifdef. --- i386/i386at/kd.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/i386/i386at/kd.h b/i386/i386at/kd.h index 4d1ab7f..ed11cbb 100644 --- a/i386/i386at/kd.h +++

[PATCH 11/66] device/cirbuf.c: use boolean instead of an int

* device/cirbuf.c (cb_check_enable): Use boolean instead of an int. --- device/cirbuf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/device/cirbuf.c b/device/cirbuf.c index 7af2d7a..292b888 100644 --- a/device/cirbuf.c +++ b/device/cirbuf.c @@ -42,7 +42,7 @@ /* if c_cl ==

[PATCH 62/66] kern/syscall_sw.c: use boolean instead of an int

* kern/syscall_sw.c (kern_invalid_debug): Use boolean instead of an int. --- kern/syscall_sw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kern/syscall_sw.c b/kern/syscall_sw.c index 607d843..856b12f 100644 --- a/kern/syscall_sw.c +++ b/kern/syscall_sw.c @@ -56,7 +56,7 @@

[PATCH 08/66] ddb/db_output.h: add comment

Add comment saying that kdbprintf is an alternate name for db_printf(). * ddb/db_output.h: Add comment. --- ddb/db_output.h | 1 + 1 file changed, 1 insertion(+) diff --git a/ddb/db_output.h b/ddb/db_output.h index 8d74f88..35c39a6 100644 --- a/ddb/db_output.h +++ b/ddb/db_output.h @@ -35,6

[PATCH 43/66] i386/i386at/rtc.c: use boolean instead of an int

* i386/i386at/rtc.c (first_rtcopen_ever): Use boolean instead of an int. --- i386/i386at/rtc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/i386/i386at/rtc.c b/i386/i386at/rtc.c index 3112830..2115f23 100644 --- a/i386/i386at/rtc.c +++ b/i386/i386at/rtc.c @@ -53,7

[PATCH 38/66] i386/i386at/kd.c: use boolean instead of an int

* i386/i386at/kd.c (mouse_in_use): Use boolean instead of an int. Remove duplicate declaration. --- i386/i386at/kd.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/i386/i386at/kd.c b/i386/i386at/kd.c index 1a2d9fd..3299e70 100644 --- a/i386/i386at/kd.c +++

[PATCH 17/66] device/kmsg.c: use boolean instead of an int

* device/kmsg.c (kmsg_init_done): Use boolean instead of an int. --- device/kmsg.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/device/kmsg.c b/device/kmsg.c index 0e18725..7034bfc 100644 --- a/device/kmsg.c +++ b/device/kmsg.c @@ -46,7 +46,7 @@ static boolean_t

[PATCH 66/66] kern/processor.h: remove ifdef

This code is used even if KERNEL is not defined. Remove the ifdef. * kern/processor.h [KERNEL]: Remove ifdef. --- kern/processor.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/kern/processor.h b/kern/processor.h index 7bd29cf..2000192 100644 --- a/kern/processor.h +++ b/kern/processor.h

[PATCH 37/66] i386/i386at/kd.c: simplify code

Variable font_byte_width is always zero. Use this to simplify the code. * i386/i386at/kd.c (font_byte_width): Remove variable. (i, from): Remove variables. Remove for loop. * i386/i386at/kdsoft.h (font_byte_width): Remove declaration. --- i386/i386at/kd.c | 7 --- i386/i386at/kdsoft.h |

[PATCH 16/66] device/kmsg.c: use boolean instead of an int

* device/kmsg.c (kmsg_in_use): Use boolean instead of an int. --- device/kmsg.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/device/kmsg.c b/device/kmsg.c index c8bd897..0e18725 100644 --- a/device/kmsg.c +++ b/device/kmsg.c @@ -42,7 +42,7 @@ static int

[PATCH 39/66] i386/i386at/kd.c: use boolean instead of an unsigned int

* i386/i386at/kd.c (kd_bellstate): Use boolean instead of an unsigned int. --- i386/i386at/kd.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/i386/i386at/kd.c b/i386/i386at/kd.c index 1425f74..1bf6fe1 100644 --- a/i386/i386at/kd.c +++ b/i386/i386at/kd.c @@ -1215,7

[PATCH 61/66] kern/refcount.h: remove unnecessary include

File kern/refcount.h includes itself. Remove this include. * kern/refcount.h: Don't include kern/refcount.h. --- kern/refcount.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/kern/refcount.h b/kern/refcount.h index 7fd6cdf..58e1cc4 100644 --- a/kern/refcount.h +++ b/kern/refcount.h @@

[PATCH 35/66] i386/i386at/kd.c: simplify code

Variable char_byte_width is always zero. Use this to simplify the code. * i386/i386at/kd.c (char_byte_width): Remove variable. (j): Remove variable. (mask): Remove assignment. (from): Simplify assignment. Remove for loop. (j): Remove variable. Remove for loop. (byte): Remove variable. Remove for

Re: [PATCH 57/68] Remove MACH_TTD code

On 04.12.2013 22:59:06, Samuel Thibault wrote: Marin Ramesa, le Fri 29 Nov 2013 22:54:22 +0100, a écrit : * device/net_io.c [MACH_TTD]: Remove code. * i386/i386/trap.c [MACH_TTD]: Likewise. * i386/i386at/autoconf.c [MACH_TTD]: Likewise. Ah. The patch ordering was improper

[PATCH 1/2] device/net_io.c: add comments and initialize hash_entp

Samuel Thibault wrote: It doesn't seem so clear that it's actually always properly initialized. We also need a comment explaining why it always is. * device/net_io.c (hash_entp): Initialize and add a comment saying why this was done. --- device/net_io.c | 7 +-- 1 file changed, 5

[PATCH 2/2] kern/lock.h: XXX quiet GCC warnings about set but unused variables during simple locks

* kern/lock.h (decl_simple_lock_data): Define macro. (simple_unlock): Define so that lock is assigned to itself and add a comment saying why this was done. (simple_lock_try): Define so that lock data is cast to a boolean with the value TRUE and assigned to itself. Add a comment saying why this

Re: [PATCH 1/2] device/net_io.c: add comments and initialize hash_entp

0b850181995519071d3064c45dbbc31b762bd75a Mon Sep 17 00:00:00 2001 From: Marin Ramesa m...@hi.t-com.hr Date: Mon, 2 Dec 2013 11:39:33 +0100 Subject: [PATCH] device/net_io.c: initialize hash_entp --- device/net_io.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/device/net_io.c b/device/net_io.c index 1958840

Re: [PATCH 1/2] device/net_io.c: add comments and initialize hash_entp

On 02.12.2013 11:55:14, Marin Ramesa wrote: +for (counter = 0; i N_NET_HASH_KEYS; i++) This should be: for (counter = 0; counter N_NET_HASH_KEYS; counter++);

Re: [PATCH] Patch that breaks the gnumach build

On 02.12.2013 14:38:28, Samuel Thibault wrote: Marin Ramesa, le Sun 01 Dec 2013 10:47:53 +0100, a écrit : I need some help. I'm trying to fix a GCC warning by modifying the struct dev_ops in device/conf.h. I need the definition of io_req_t to do that. But when I include device/io_req.h from

[PATCH 01/14] i386/i386at/kd.c: fix signed overflow (a warning from GCC)

* i386/i386at/kd.c (c): Cast to char. --- i386/i386at/kd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/i386/i386at/kd.c b/i386/i386at/kd.c index 3890c3d..0b780a7 100644 --- a/i386/i386at/kd.c +++ b/i386/i386at/kd.c @@ -854,7 +854,7 @@ int vec; *

[PATCH 02/14] i386/i386at/kd.c: remove useless old code

* i386/i386at/kd.c [old]: Remove code. --- i386/i386at/kd.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/i386/i386at/kd.c b/i386/i386at/kd.c index 0b780a7..ab04632 100644 --- a/i386/i386at/kd.c +++ b/i386/i386at/kd.c @@ -748,9 +748,7 @@ int vec;

[PATCH 14/14] vm/vm_resident.c: move struct definition to a header file

* vm/vm_resident.c: Include vm/vm_resident.h. (vm_page_bucket_t): Move struct defintion to vm/vm_resident.h. --- vm/vm_resident.c | 5 + vm/vm_resident.h | 5 + 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/vm/vm_resident.c b/vm/vm_resident.c index fbd4275..b164109

[PATCH 05/14] i386/i386/idt.c: move struct definition to a header file

* i386/i386/idt.c (idt_init_entry): Move struct definition to i386/i386/idt-gen.h. --- i386/i386/idt-gen.h | 7 +++ i386/i386/idt.c | 6 -- 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/i386/i386/idt-gen.h b/i386/i386/idt-gen.h index f86afb4..1aad4c0 100644 ---

[PATCH 04/14] ddb/db_macro.c: move struct definition to a header file

* ddb/db_macro.c (db_user_macro): Move struct definition to ddb/db_macro.h. --- ddb/db_macro.c | 6 -- ddb/db_macro.h | 8 2 files changed, 8 insertions(+), 6 deletions(-) diff --git a/ddb/db_macro.c b/ddb/db_macro.c index 9d14b12..6c1bff3 100644 --- a/ddb/db_macro.c +++

[PATCH 06/14] i386/intel/pmap.c: move struct definitions to a header file

* i386/intel/pmap.c (pv_entry, pmap_update_item, pmap_update_list): Move struct definitions to i386/intel/pmap.h. --- i386/intel/pmap.c | 45 - i386/intel/pmap.h | 46 +- 2 files changed, 45 insertions(+),

[PATCH 03/14] ddb/db_cond.c: move struct definition to a header file

* ddb/db_cond.c (db_cond): Move struct definition to ddb/db_cond.h. --- ddb/db_cond.c | 7 --- ddb/db_cond.h | 7 +++ 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/ddb/db_cond.c b/ddb/db_cond.c index 82ec0d6..b8e661b 100644 --- a/ddb/db_cond.c +++ b/ddb/db_cond.c @@

[PATCH 11/14] kern/lock.c: move struct definition to a header file

* kern/lock.c [MACH_SLOCKS NCPUS == 1] (simple_locks_info): Move struct definition to kern/lock.h. --- kern/lock.c | 5 - kern/lock.h | 7 +++ 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/kern/lock.c b/kern/lock.c index fb5e344..ca47e8a 100644 --- a/kern/lock.c +++

[PATCH 07/14] ipc/ipc_hash.c: move struct definition to a header file

* ipc/ipc_hash.c (ipc_hash_global_bucket): Move struct definition to ipc/ipc_hash.h. --- ipc/ipc_hash.c | 7 --- ipc/ipc_hash.h | 7 +++ 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/ipc/ipc_hash.c b/ipc/ipc_hash.c index 5eec58c..5b31691 100644 --- a/ipc/ipc_hash.c +++

[PATCH 13/14] vm/vm_fault.c: move struct definition to a header file

* vm/vm_fault.c (vm_fault_state): Move struct definition to vm/vm_fault.h. --- vm/vm_fault.c | 26 -- vm/vm_fault.h | 24 2 files changed, 24 insertions(+), 26 deletions(-) diff --git a/vm/vm_fault.c b/vm/vm_fault.c index d0c7f96..0bde0fb 100644

[PATCH 12/14] vm/memory_object_proxy.c: move struct definition to a header file

* vm/memory_object_proxy.c (memory_object_proxy): Move struct definition to vm/memory_object_proxy.h. --- vm/memory_object_proxy.c | 10 -- vm/memory_object_proxy.h | 9 + 2 files changed, 9 insertions(+), 10 deletions(-) diff --git a/vm/memory_object_proxy.c

[PATCH 08/14] ipc/ipc_marequest.c: move struct definition to a header file

* ipc/ipc_marequest.c (ipc_marequest_bucket): Move struct definition to ipc/ipc_marequest.h. * ipc/ipc_marequest.h: Include kern/lock.h. --- ipc/ipc_marequest.c | 7 --- ipc/ipc_marequest.h | 8 2 files changed, 8 insertions(+), 7 deletions(-) diff --git a/ipc/ipc_marequest.c

[PATCH 09/14] ipc/ipc_port.c: trivial stylistic fix for consistency

* ipc/ipc_port.c (indent): Trivial stylistic fix for consistency. --- ipc/ipc_port.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ipc/ipc_port.c b/ipc/ipc_port.c index b960739..99a6ad4 100644 --- a/ipc/ipc_port.c +++ b/ipc/ipc_port.c @@ -1240,7 +1240,7 @@

[PATCH] device/net_io.c: initialize hash_entp to NULL

* device/net_io.c (hash_entp): Initialize to NET_HASH_ENTRY_NULL. --- device/net_io.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/device/net_io.c b/device/net_io.c index 1958840..40fe8f6 100644 --- a/device/net_io.c +++ b/device/net_io.c @@ -324,6 +324,7 @@

[PATCH] Patch that breaks the gnumach build

I need some help. I'm trying to fix a GCC warning by modifying the struct dev_ops in device/conf.h. I need the definition of io_req_t to do that. But when I include device/io_req.h from device/conf.h the build breaks with this error message: In file included from ../vm/pmap.h:45:0,

[PATCH 1/3] device/device_types_kernel.h: remove redeclaration of dev_port_lookup()

* device/device_types_kernel.h (dev_port_lookup): Remove prototype. --- device/device_types_kernel.h | 1 - 1 file changed, 1 deletion(-) diff --git a/device/device_types_kernel.h b/device/device_types_kernel.h index 87ce00f..e17055c 100644 --- a/device/device_types_kernel.h +++

[PATCH 3/3] kern/debug.c: fix return of noreturn function

Assertion failure message even if no breakpoints inserted. * kern/debug.c [MACH_KDB] (Assert): Add call to Debugger(). --- kern/debug.c | 6 ++- 1 file changed, 5 insertions(+), 1 deletions(-) diff --git a/kern/debug.c b/kern/debug.c index 33e64f3..6d32e19 100644 --- a/kern/debug.c +++

[PATCH 2/3] build/device/device.server.c: fix implicit declaration of function

* include/device/device_types.h (device_deallocate): Add prototype. --- include/device/device_types.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/device/device_types.h b/include/device/device_types.h index caf4fc0..b091d1d 100644 --- a/include/device/device_types.h +++

[PATCH 2/2] Add ifndefs

* i386/i386at/cram.h [_CRAM_H_]: Add ifndef. * i386/i386at/disk.h [_DISK_H_]: Likewise. * i386/i386at/i8250.h [_I8250_H_]: Likewise. * i386/include/mach/i386/asm.h [_MACH_I386_ASM_H_]: Likewise. * i386/include/mach/i386/disk.h [_MACH_I386_DISK_H_]: Likewise. --- i386/i386at/cram.h| 4

[PATCH 1/2] Add comments after endifs

* ddb/db_run.c [FIXUP_PC_AFTER_BREAK]: Add comment after endif. * device/cons.c [MACH_KMSG]: Likewise. [CONSBUFSIZE 0]: Likewise. * i386/i386/trap.c [MACH_KDB]: Likewise. [MACH_PV_PAGETABLES]: Likewise. * i386/i386at/kd.c [ENABLE_IMMEDIATE_CONSOLE]: Likewise. * ipc/ipc_kmsg_queue.h

Re: [PATCH 31/68] ipc/ipc_kmsg.c: remove forward declarations

On 29.11.2013 22:53:56, Marin Ramesa wrote: * ipc/ipc_kmsg.c (copyinmap, copyoutmap, ipc_msg_print): Remove forward declarations. * ipc/ipc_kmsg.h (ipc_msg_print): Add prototype. I just noticed this, the prototype for ipc_msg_print() is a duplicate - it's already declared in ipc/icp_print.h

[PATCH 02/68] ddb/db_input.c: add comment after endif

* ddb/db_input.c [DB_HISTORY_SIZE]: Add comment after endif. --- ddb/db_input.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/ddb/db_input.c b/ddb/db_input.c index 8f875ad..7fee8fd 100644 --- a/ddb/db_input.c +++ b/ddb/db_input.c @@ -133,7 +133,7 @@ db_delete_line()

[PATCH 05/68] ddb/db_run.c: add comment after endif

* ddb/db_run.c [FIXUP_PC_AFTER_BREAK]: Add comment after endif. --- ddb/db_run.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ddb/db_run.c b/ddb/db_run.c index acd5586..330b41b 100644 --- a/ddb/db_run.c +++ b/ddb/db_run.c @@ -81,7 +81,7 @@ db_stop_at_pc(is_breakpoint,

[PATCH 01/68] ddb/db_command.c: remove forward declarations

* ddb/db_command.c: Include machine/db_interface.h. (db_help_cmd, db_stack_trace_cmd): Remove forward declarations. * ddb/db_command.h (db_help_cmd): Add prototype. * i386/i386/db_interface.h (db_stack_trace_cmd): Add prototype. --- ddb/db_command.c | 3 +-- ddb/db_command.h | 2

gnumach code cleanup

I've broken up my previous patch into seperate git commits and added the removal of forward declarations. The result is a series of 68 patches. I am sorry of the length of the series causes any trouble. Large number of forward declarations have been turned into prototypes in header files and all

[PATCH 04/68] ddb/db_output.c: remove forward declaration

* ddb/db_output.c (db_check_interrupt): Remove forward declaration. * ddb/db_output.h (db_check_interrupt): Add prototype. --- ddb/db_output.c | 2 -- ddb/db_output.h | 1 + 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/ddb/db_output.c b/ddb/db_output.c index c08db6f..b63813b

[PATCH 07/68] ddb: new header file db_aout.h

* Makefrag.am: Include ddb/db_aout.h. * ddb/db_aout.c: Include ddb/db_aout.h. * ddb/db_aout.h: New file. Add copyright. [_DDB_DB_AOUT_H_]: Add ifndef. Include ddb/db_sym.h. Include machine/db_machdep.h. (aout_db_line_at_pc, aout_db_lookup, aout_db_search_symbol, aout_db_symbol_values): Add

[PATCH 12/68] ddb/db_trap.c: remove forward declarations

* ddb/db_run.h (db_restart_at_pc, db_stop_at_pc): Add prototypes. * ddb/db_trap.c (db_restart_at_pc, db_stop_at_pc): Remove forward declarations. Include ddb/db_run.h. --- ddb/db_run.h | 10 ++ ddb/db_trap.c | 4 +--- 2 files changed, 11 insertions(+), 3 deletions(-) diff --git

[PATCH 14/68] device/device_init.c: remove forward declarations

* device/dev_lookup.c: Include device/ds_routines.h. * device/device_init.c: Include device/ds_routines.h. Include device/net_io.h. (mach_device_init, dev_lookup_init, net_io_init, device_pager_init, io_done_thread, net_thread): Remove forward declarations. * device/ds_routines.h

[PATCH 08/68] ddb/db_sym.c: remove useless forward declarations without definitions

* ddb/db_sym.c (coff_db_sym_init, coff_db_line_at_pc, db_sym_t coff_db_lookup, coff_db_search_symbol, coff_db_symbol_values): Remove forward declarations. (x_db): Modify field definition. --- ddb/db_sym.c | 9 - 1 file changed, 9 deletions(-) diff --git a/ddb/db_sym.c b/ddb/db_sym.c

[PATCH 06/68] ddb/db_aout.c: trivial stylistic fix for consistency

* ddb/db_aout.c: Trivial stylistic fix for consistency. --- ddb/db_aout.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ddb/db_aout.c b/ddb/db_aout.c index a36ca0e..5480325 100644 --- a/ddb/db_aout.c +++ b/ddb/db_aout.c @@ -500,7 +500,7 @@ aout_db_line_at_pc(stab, sym,

[PATCH 09/68] ddb/db_sym.c: fix argument list

* ddb/db_sym.c (dummy_db_free_symbol): Fix argument list. --- ddb/db_sym.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ddb/db_sym.c b/ddb/db_sym.c index 9d64f5b..fb0cd96 100644 --- a/ddb/db_sym.c +++ b/ddb/db_sym.c @@ -507,7 +507,7 @@ void db_free_symbol(db_sym_t s) *

[PATCH 18/68] i386/i386/io_perm.c: remove forward declaration

* i386/i386/io_perm.c: Include pcb.h. (update_ktss_iopb): Remove forward declaration. * i386/i386/pcb.h (update_ktss_iopb): Add prototype. --- i386/i386/io_perm.c | 6 +- i386/i386/pcb.h | 2 ++ 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/i386/i386/io_perm.c

[PATCH 19/68] i386/i386/ldt.c: remove useless forward declaration without definition

* i386/i386/ldt.c (syscall): Remove forward declaration. (syscall): New variable. --- i386/i386/ldt.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/i386/i386/ldt.c b/i386/i386/ldt.c index 43b9efb..37f09fb 100644 --- a/i386/i386/ldt.c +++ b/i386/i386/ldt.c @@ -37,8 +37,6

[PATCH 17/68] i386/i386/fpu.c: remove (#if 1)

* i386/i386/fpu.c: Remove (#if 1). --- i386/i386/fpu.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/i386/i386/fpu.c b/i386/i386/fpu.c index 4e3ab57..a850203 100644 --- a/i386/i386/fpu.c +++ b/i386/i386/fpu.c @@ -782,7 +782,6 @@ ASSERT_IPL(SPL0); memset(ifps, 0, sizeof *ifps);

[PATCH 11/68] ddb/db_command.c: remove useless forward declaration without definition

* ddb/db_command.c (ddb_display): Remove forward declaration. Remove ddb_display call. --- ddb/db_command.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/ddb/db_command.c b/ddb/db_command.c index 833b720..b596e52 100644 --- a/ddb/db_command.c +++ b/ddb/db_command.c @@

[PATCH 21/68] kern: new header file exception.h

* Makefrag.am: Include kern/exception.h. * i386/i386/trap.c: Include kern/exception.h. (exception, thread_exception_return): Remove forward declarations. * kern/exception.c: Include kern/exception.h. (exception, exception_try_task, exception_no_server, exception_raise, exception_parse_reply,

<    1   2   3   4   5   6   >