* device/dev_pager.c [lint]: Remove ifdefs and associated code.
---
device/dev_pager.c | 12
1 file changed, 12 deletions(-)
diff --git a/device/dev_pager.c b/device/dev_pager.c
index a1b9eb9..63726b6 100644
--- a/device/dev_pager.c
+++ b/device/dev_pager.c
@@ -331,10 +331,6 @@
* device/dev_pager.c: Coding style changes.
---
device/dev_pager.c | 28 ++--
1 file changed, 14 insertions(+), 14 deletions(-)
diff --git a/device/dev_pager.c b/device/dev_pager.c
index 7f49805..a1b9eb9 100644
--- a/device/dev_pager.c
+++ b/device/dev_pager.c
@@ -262,12
* device/dk_label.c: Remove file.
---
device/dk_label.c | 99 ---
1 file changed, 99 deletions(-)
delete mode 100644 device/dk_label.c
diff --git a/device/dk_label.c b/device/dk_label.c
deleted file mode 100644
index c7d459b..000
---
* device/dev_name.c: Remove register qualifiers.
---
device/dev_name.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/device/dev_name.c b/device/dev_name.c
index cef1efd..98a0e27 100644
--- a/device/dev_name.c
+++ b/device/dev_name.c
@@ -65,9 +65,9 @@
The first one is a message that name lookup has been called, which
I think is safe to remove, or maybe add #if DEBUG. Second one is a
alternate calculation that I doubt it will ever be used, so I think
it's safe to remove it.
* device/dev_name.c: Remove preprocessor comments.
---
What follows is a small cleanup of device name routines. Patches
2, 4 and 7 can be applied at the same time. They are just changes
in style for consistency. I didn't know how to combine them in one
commit, so I'm sending them this way, I hope this is not a problem.
I'm not sure about patch 3 - I
* device/dev_name.c: Change in coding style.
---
device/dev_name.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/device/dev_name.c b/device/dev_name.c
index dc5f835..2e3b0ab 100644
--- a/device/dev_name.c
+++ b/device/dev_name.c
@@ -219,14 +219,14 @@ boolean_t
Variable 'found' already receives values TRUE and FALSE, so why not make
it a boolean.
* device/dev_name.c: Use boolean_t instead of an int.
---
device/dev_name.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/device/dev_name.c b/device/dev_name.c
index a9056ff..dc5f835
* device/dev_name: Changes in coding style.
---
device/dev_name.c | 15 ---
1 file changed, 8 insertions(+), 7 deletions(-)
diff --git a/device/dev_name.c b/device/dev_name.c
index 98a0e27..bf541df 100644
--- a/device/dev_name.c
+++ b/device/dev_name.c
@@ -65,9 +65,9 @@ nomap()
*/
* device/dev_name.c: Change in coding style.
---
device/dev_name.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/device/dev_name.c b/device/dev_name.c
index 6ce4b19..7bdbf38 100644
--- a/device/dev_name.c
+++ b/device/dev_name.c
@@ -170,7 +170,7 @@ boolean_t
Return early from function if src null-terminates in the loop before
the target does. This is to prevent pointers going to addresses beyond
null-termination.
* device/dev_name.c (name_equal): Check if src null-terminates in the loop.
---
device/dev_name.c | 5 -
1 file changed, 4
On 13.09.2013 14:42:44, Neal H. Walfield wrote:
At Fri, 13 Sep 2013 13:31:53 +0200,
Marin Ramesa wrote:
diff --git a/device/dev_name.c b/device/dev_name.c
index bf541df..6ce4b19 100644
--- a/device/dev_name.c
+++ b/device/dev_name.c
@@ -69,9 +69,12 @@ name_equal(src, len, target
On 13.09.2013 15:41:47, Neal H. Walfield wrote:
At Fri, 13 Sep 2013 15:06:33 +0200,
Marin Ramesa wrote:
On 13.09.2013 14:42:44, Neal H. Walfield wrote:
At Fri, 13 Sep 2013 13:31:53 +0200,
Marin Ramesa wrote:
diff --git a/device/dev_name.c b/device/dev_name.c
index bf541df
What follows is a small cleanup of the device lookup code.
[PATCH 1/2] remove register qualifiers
[PATCH 2/2] remove definition of NDEVICES
* device/dev_lookup.c: Remove register qualifiers.
---
device/dev_lookup.c | 36 ++--
1 file changed, 18 insertions(+), 18 deletions(-)
diff --git a/device/dev_lookup.c b/device/dev_lookup.c
index 98a2d02..e156d1a 100644
--- a/device/dev_lookup.c
+++
NDEVICES is never used. Judging by the position and the comments
it was once used in initialization, but it's not anymore. I think
it's safe to remove it.
* device/dev_lookup.c (NDEVICES): Remove definition.
---
device/dev_lookup.c | 2 --
1 file changed, 2 deletions(-)
diff --git
On 11.09.2013 23:05:44, Samuel Thibault wrote:
Marin Ramesa, le Tue 10 Sep 2013 10:38:04 +0200, a écrit :
#ifDEBUG
-int cb_check_enable = 0;
+const int cb_check_enable = 0;
I'd rather not.
It is useful to be able to modify the value live from the debugger,
so as to enable
A variable that keeps track if the console init has been called. It should
never receive values other than 0 and 1, so constrain it's possible range of
values to a boolean.
* device/cons.c (cn_inited): Use boolean_t instead of an int.
---
device/cons.c | 4 ++--
1 file changed, 2
A variable that keeps track of the console buffer usage should never receive
values other than 0 and 1, so constrain it's value range to boolean. Plus, it's
more readable this way.
* device/cons.c (consbufused): Use boolean_t instead of an int.
---
device/cons.c | 8
1 file changed, 4
Function cnputc() should never modify it's argument so qualify it
with a const keyword.
* device/cons.c (cnputc): Qualify argument as const.
* device/cons.h (cnputc): Likewise.
---
device/cons.c | 2 +-
device/cons.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git
CONSMAJOR is never used. I'm guessing that in the past it was
a part of some problematic code. I don't see a reason to keep
it's definition.
* device/cons.h (CONSMAJOR): Remove definition.
---
device/cons.h | 3 ---
1 file changed, 3 deletions(-)
diff --git a/device/cons.h b/device/cons.h
What follows is a small cleanup of the console code.
[PATCH 1/5] drop unused CONSMAJOR
[PATCH 2/5] track the console buffer usage with a boolean instead of an int
[PATCH 3/5] track the console init with a boolean instead of an int
[PATCH 4/5] qualify constant with the const
[PATCH 5/5] remove
Please comment on this removal.
The check 'defined(MACH_HYP) 0' never evaluates to TRUE, so
I'm guessing this was a way to comment out this code. I don't
see hyp_console_write() anywhere defined except in xen, so there
should be some checking for that too. Plus, the call itself look like
it
* device/cirbuf.c (cb_check_enable) [DEBUG]: Qualify constant as const.
---
device/cirbuf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/device/cirbuf.c b/device/cirbuf.c
index 4fe2d89..0ebff8e 100644
--- a/device/cirbuf.c
+++ b/device/cirbuf.c
@@ -42,7 +42,7 @@
/* if
It doesn't require much cleanup, so I'm just adding const and
removing the register qualifier.
[PATCH 1/2] qualify constants as const
[PATCH 2/2] remove register qualifiers.
* device/cirbuf.c: Remove register qualifiers.
---
device/cirbuf.c | 48
1 file changed, 24 insertions(+), 24 deletions(-)
diff --git a/device/cirbuf.c b/device/cirbuf.c
index 0ebff8e..2b10819 100644
--- a/device/cirbuf.c
+++ b/device/cirbuf.c
@@
Simple patch to remove all trace of the luna88k arch.
By the way, I'm sending this to the list as a test for git-send-email
as Justus suggested, so if something unexpected happens (like a duplication
or something) please just ignore it.
* kern/debug.c: Remove check for luna88k.
---
.
From 93dd68cc7c96dadde44fcd452e4aaf22cea7aecc Mon Sep 17 00:00:00 2001
From: Marin Ramesa m...@hi.t-com.hr
Date: Sun, 8 Sep 2013 16:30:27 +0200
Subject: [PATCH 2/2] Cleanup of the TTY I/O.
---
device/chario.c | 122 +++-
device/tty.h| 7
On 08.09.2013 18:53:02, Justus Winter wrote:
Hi Marin :)
I think it is awesome of you to start cleaning up gnumach, this is
much overdue. But you shouldn't mash so many changes into one patch,
rather split it up. By the way, gnumach uses git and using git it is
very easy to keep separate
* ipc/ipc_port.c (ipc_port_set_seqno) [MACH_SLOCKS]: Conditional locking.
=46rom d56b769755a5d671f084ebdd482de8b34be9cd5b Mon Sep 17 00:00:00 2001
From: Marin Ramesa m...@hi.t-com.hr
Date: Sat, 7 Sep 2013 07:37:42 +0200
Subject: [PATCH] perform conditional locking while changing the port sequence
On 07.09.2013 08:58:14, Samuel Thibault wrote:
Marin Ramesa, le Sat 07 Sep 2013 08:00:47 +0200, a écrit :
* ipc/ipc_port.c (ipc_port_set_seqno) [MACH_SLOCKS]: Conditional
locking.
What is the rationale? Does it really bring an noticeable
improvement? The locking is already conditional
On 07.09.2013 10:46:18, Samuel Thibault wrote:
And in the end mqueue never get's really used in the
ipc_port_set_seqno().
It is, for locking.
That's what I mean by not functional. I claim it doesn't perform
locking in that one special case. But I was too hasty with the patch,
I'll be
On 07.09.2013 10:46:18, Samuel Thibault wrote:
Marin Ramesa, le Sat 07 Sep 2013 10:17:29 +0200, a écrit :
We have a local variable mqueue that is set by the lock, but if you
look at the definition of imq_unlock() and then simple_unlock()
members of mqueue just change state and they don't
Mon Sep 17 00:00:00 2001
From: Marin Ramesa m...@hi.t-com.hr
Date: Fri, 6 Sep 2013 16:42:44 +0200
Subject: [PATCH] Drop the register keyword and use boolean_t
---
chips/busses.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/chips/busses.c b/chips/busses.c
On 10.07.2013 14:14:29, Marin Ramesa wrote:
Use new .h files in cleanup of db_command.c.
I noticed that these four patches are very similar to what was done in
XNU. Now, I don't know if they should be applied to GNU Mach, I'm not
a legal expert, so I don't know if this patches are a copyright
/vm_print.h.
From 7ad0c89384899681cdc9e39ccb7dee15f4a5bb82 Mon Sep 17 00:00:00 2001
From: Marin Ramesa m...@hi.t-com.hr
Date: Wed, 10 Jul 2013 12:42:08 +0200
Subject: [PATCH 1/4] vm: organize vm print function prototypes
---
vm/vm_map.c | 1 +
vm/vm_map.h | 3 ---
vm/vm_object.c
.
From 080ba6e2dad9b63f0939a375ed9fa299e26697b5 Mon Sep 17 00:00:00 2001
From: Marin Ramesa m...@hi.t-com.hr
Date: Wed, 10 Jul 2013 13:14:27 +0200
Subject: [PATCH 2/4] ipc: organize ipc print function prototypes
---
ipc/ipc_kmsg.c | 1 +
ipc/ipc_port.c | 1 +
ipc/ipc_port.h | 3 ---
ipc
* kern/lock.h (db_show_all_slocks): Add prototype.
=46rom 8e5ed9a78a101bb1afb243a1b3e3c4ef07a0e2dc Mon Sep 17 00:00:00 2001
From: Marin Ramesa m...@hi.t-com.hr
Date: Wed, 10 Jul 2013 13:23:07 +0200
Subject: [PATCH 3/4] kern: add missing prototype
---
kern/lock.h | 2 ++
1 file changed, 2
.
(ipc_kmsg_print): Likewise.
(ipc_msg_print): Likewise.
Include vm/vm_print.h.
Include ipc/ipc_print.h.
Include kern/lock.h.
* i386/i386/setjmp.h [__GNUC__] (_longjmp): Add prototype.
From 5e371e31032dea5760cf48dbf657df5768b9e241 Mon Sep 17 00:00:00 2001
From: Marin Ramesa m...@hi.t-com.hr
Date
On 05.07.2013 14:55:32, Marin Ramesa wrote:
Putting 'extern int _setjmp(jmp_buf_t*)' to i386/i386/setjmp.h
removes three implicit declaration warnings.
Actually four, if db_trap.c includes machine/setjmp.h.
* ddb/db_trap.c: Include machine/setjmp.h.
* i386/i386/setjmp.h (_setjmp): Add
): Likewise.
(db_cond_cmd): Likewise.
(db_help_cmd): Likewise.
(db_def_macro_cmd): Likewise.
(db_del_macro_cmd): Likewise.
(db_fncall): Likewise.
(db_help_cmd): Remove unused function.
From fe4dba010bbe25e4d148f1cc3d488c17dca5eaac Mon Sep 17 00:00:00 2001
From: Marin Ramesa marin.ram...@gmail.com
On 04.07.2013 23:11:19, Samuel Thibault wrote:
Please rather put it into a .h file.
Here's the patch:
* ddb/db_command.h (_setjmp): Add prototype.
* kern/xpr.h (_setjmp): Add prototype.
=46rom b5f866f80206845700c242f5005495ca20e57206 Mon Sep 17 00:00:00 2001
From: Marin Ramesa marin.ram
On 05.07.2013 09:45:39, Samuel Thibault wrote:
Err, no, the point of putting it in a .h file is to put it into a
single place, so you're sure everybody agree on the definition since
it's written only once. The .h file where it's supposed to go has to
be related with the function itself, e.g.
+++ ../gnumach1/ddb/db_examine.h2013-07-03
10:27:57.205341927 +0200
@@ -26,8 +26,8 @@
#include ddb/db_expr.h
extern void db_examine_cmd (
- db_expr_t addr,
- int have_addr,
+ db_expr_t addr,
+ int have_addr,
This looks like spurious change.
Samuel
I have
When building with --enable-kdb.
* ddb/db_break.c: Include ddb/db_access.h.
* ddb/db_examine.h (db_xcdump): Add prototype.
* ddb/db_ext_symtab.c: Include vm/vm_user.h.
* ddb/db_input.c: Include device/cons.h.
* ddb/db_output.c: Likewise.
* ddb/db_command.c: Add extern _setjmp.
* ddb/db_cond.c:
On 03.07.2013 12:28:31, Richard Braun wrote:
On Wed, Jul 03, 2013 at 11:35:31AM +0200, Marin Ramesa wrote:
diff -Nurp ../gnumach/ddb/db_break.c ../gnumach1/ddb/db_break.c
Please ease the life of maintainers by providing git-generated
patches with a proper changelog entry.
No problem. I
On 02.07.2013 00:45:29, Samuel Thibault wrote:
Marin Ramesa, le Mon 01 Jul 2013 12:37:54 +0200, a écrit :
I don't know if this qualifies as a rewrite of db_expr.h; in my
mind it does, so I removed the copyright;
Well, the patch doesn't make it look so :)
OK, at least I tried. :)
It's
I quote the project page: For some of the internal header files
(containing function prototypes and the like), it might actually be
useful to use them. (And then get rid of a bunch of extern ...
statements in other files.).
So, I made a preliminary patch with db_print.h. I don't really know if
Marin Ramesa marin.ram...@gmail.com
* ddb/ddb_expr.h: Remove copyright notice, it's a rewrite.
Remove unneeded includes.
Remove obvious comment.
(db_expression): Remove prototype.
(db_logical_or_expr): New prototype.
* ddb/ddb_expr.c (db_expression): Remove trivial function.
(db_term): Call
On 01.07.2013 12:37:54, Marin Ramesa wrote:
Also I noticed that the current build skips db_expr.h
Please ignore this, I forgot to pass --enable-kdb to configure.
Tell the compiler that it will find these at link time; this fixes the
implicit declaration warnings.
--- ./gnumach/device/net_io.h 2013-06-28 10:10:49.877024364 +0200
+++ ./gnumach1/device/net_io.h 2013-06-29 09:42:58.498730719 +0200
@@ -83,4 +83,9 @@
#define net_kmsg_alloc() ((ipc_kmsg_t)
Sometimes, bpf_hash gets arguments passed from incompatible pointer
types. This patch fixes this warning.
--- ./gnumach/device/net_io.c 2013-06-28 10:10:49.877024364 +0200
+++ ./gnumach1/device/net_io.c 2013-06-29 15:02:43.758232365 +0200
@@ -310,7 +310,7 @@
#define N_NET_HASH 4
#define
On 29.06.2013 20:48:59, Samuel Thibault wrote:
Marin Ramesa, le Fri 28 Jun 2013 20:04:19 +0200, a écrit :
There is a function declared in dev_pager.c, used in ds_routines.c
without a prototype.
Thanks. Could you take the habit of writing the ChangeLog entry?
Samuel
Sure. Will do
A simple fix of printf format; vm_size_t is type defined as an unsigned
int.
--- ./gnumach/kern/slab.c 2013-06-28 10:10:49.951023129 +0200
+++ ./gnumach1/kern/slab.c 2013-06-28 10:44:03.020995010 +0200
@@ -1450,7 +1450,7 @@
mem_usage = (cache-nr_slabs * cache-slab_size) 10;
There is a function declared in dev_pager.c, used in ds_routines.c
without a prototype.
--- ./gnumach/device/ds_routines.h 2013-06-28 10:10:49.875024397 +0200
+++ ./gnumach1/device/ds_routines.h 2013-06-28 19:39:36.544358212 +0200
@@ -58,4 +58,11 @@
void iowait (io_req_t ior);
The same situation as my previous patch, just a different function. I
should have corrected this two compiler warnings with one patch, but I
did not notice the second function. --- ./gnumach/kern/ipc_mig.c 2013-06-04 22:13:41.916218572 +0200
+++ ./gnumach1/kern/ipc_mig.c 2013-06-05
A variable that is constant throughout the whole function and not used
in other statements except for keeping its value; probably a debugging
leftover.--- ./gnumach/linux/src/drivers/scsi/sr.c 2013-06-01 20:41:44.358545464 +0200
+++ ./gnumach1/linux/src/drivers/scsi/sr.c 2013-06-05
On 02.06.2013 14:23:20, Marin Ramesa wrote:
2. On a Fedora system with flex installed, I had to add /mig/
lexxer.l:
'%option noyywrap' as otherwise linker fails with an undefined
reference.
[...]
mig -n -cc cat - /dev/null\
-user vm/memory_object_user.user.c -header vm
Here's my first patch for Mach; I hope it will get reviewed. There was
a variable reply_port that was set in the if statement, but not used as
an argument of ds_device_write_trap. I commented out the declaration
(as there is indication in the comments that in the future it might be
used in the
Hello,
First of all, thanks to Thomas Schwinge for patiently replying to my
Savannah generated e-mail and directing me to the projects page. I did
not want to reply saying just 'thanks' as the CC: list of people was
long and I did not want to further disturb people in their work.
I'm learning
501 - 560 of 560 matches
Mail list logo
