Re: [PATCH] hurd: Add shared mig declarations

2020-05-30 Thread Pedro Alves
this the wrong way, but a while ago the GDB project (following Glibc's lead) decided that we would not add more "contributed by", "written by", etc. notes. See here <https://sourceware.org/gdb/wiki/ContributionChecklist#Attribution> and follow the link there for rationale. Thanks, Pedro Alves

Re: hurd: update RPC prototypes

2017-09-07 Thread Pedro Alves
On 09/06/2017 11:11 PM, Samuel Thibault wrote: > Pedro Alves, on lun. 04 sept. 2017 13:14:33 +0100, wrote: >> On 08/27/2017 07:41 PM, Samuel Thibault wrote: >>> Since hurd's baf7e5c ('hurd: Use polymorphic port types to return some >>> rights.'), some RPCs prototy

Re: hurd: update RPC prototypes

2017-09-04 Thread Pedro Alves
n-ToT Hurd systems? Is the intention to only ever support building ToT gdb with ToT Hurd? Thanks, Pedro Alves > > diff --git a/gdb/gnu-nat.c b/gdb/gnu-nat.c > index d5e3841e68..402027866b 100644 > --- a/gdb/gnu-nat.c > +++ b/gdb/gnu-nat.c > @@ -1874,17 +1876,19 @@ ILL_RPC (S_proc_setmsgport_re

Re: [pushed][PATCH v3 1/4] Extended-remote follow exec

2017-02-17 Thread Pedro Alves
hname = (char *) xmalloc (pathlen + 1); struct cleanup *old_chain = make_cleanup (xfree, pathname); hex2bin (p1, (gdb_byte *) pathname, pathlen); pathname[pathlen] = '\0'; discard_cleanups (old_chain); OK with that change. Thanks, Pedro Alves

Re: [PATCH] Make STARTUP_WITH_SHELL a runtime toggle -- add new set/show startup-with-shell option.

2014-01-09 Thread Pedro Alves
On 01/08/2014 09:20 PM, Thomas Schwinge wrote: Hi! On Thu, 24 Oct 2013 16:17:21 +0100, Pedro Alves pal...@redhat.com wrote: Here's what I pushed ..., and what made the Hurd port pretty unhappy. ;-) Whoops. ;-) Thanks for fixing. In the thread around http://news.gmane.org/find

Re: [RFC] GDB Hurd Fixes

2013-09-20 Thread Pedro Alves
On 09/20/2013 01:43 AM, David Michael wrote: Hi, (Copying gdb-patches this time.) But, we're missing all the context on the gdb-patches@ side. Here is an updated patch to successfully build GDB after today's Hurd/mig changes. -- Pedro Alves

Re: FAIL: gdb.base/nextoverexit.exp: next over exit (the program exited)

2013-09-19 Thread Pedro Alves
On 09/19/2013 09:30 AM, Thomas Schwinge wrote: Hi! On Thu, 19 Sep 2013 15:40:40 +0800, Yue Lu hacklu.newb...@gmail.com wrote: On Wed, Sep 18, 2013 at 8:37 PM, Pedro Alves pal...@redhat.com wrote: On 09/12/2013 04:05 AM, Yue Lu wrote: On Sat, Sep 7, 2013 at 2:53 AM, Pedro Alves pal

Re: [PATCH 1/2] Port gdbserver to GNU/Hurd

2013-09-18 Thread Pedro Alves
/ 2013-09-18 Pedro Alves pal...@redhat.com * gnu-nat.c (inf_validate_procs, gnu_wait, gnu_resume) (gnu_create_inferior) (gnu_attach, gnu_thread_alive, gnu_pid_to_str, cur_thread) (set_sig_thread_cmd): Use the lwpid field of ptids to store the thread id instead

Re: [PATCH 1/2] Port gdbserver to GNU/Hurd

2013-09-18 Thread Pedro Alves
-thread (though I can't see how in the current code), and then setting breakpoints, or other operations that require reading memory would crash. -- Pedro Alves

Re: [PATCH 1/2] Port gdbserver to GNU/Hurd

2013-09-18 Thread Pedro Alves
On 09/12/2013 04:05 AM, Yue Lu wrote: On Sat, Sep 7, 2013 at 2:53 AM, Pedro Alves pal...@redhat.com wrote: This is what I meant: https://sourceware.org/ml/gdb-patches/2013-09/msg00253.html I was thinking you'd wrap gnu_xfer_memory. I have study your patch, Thanks. Did you try building

[Hurd/gnu-nat.c] Use ptid_t.lwpid to store, thread ids instead of ptid_t.tid. (was: Re: [PATCH 1/2] Port gdbserver to GNU/Hurd)

2013-09-18 Thread Pedro Alves
On 09/18/2013 02:48 PM, Yue Lu wrote: On Wed, Sep 18, 2013 at 8:11 PM, Pedro Alves pal...@redhat.com wrote: /me gives it a try. I grepped for ptid_build and ptid_get_tid in *gnu* files, and adjusted all I found. I have tried this way before, but it doesn't work. After apply your patch

Re: [PATCH 1/2] Port gdbserver to GNU/Hurd

2013-09-18 Thread Pedro Alves
?) line-wrapped the patch. I just now tried saving the whole email as an mbox file, and then applied it to a pristine tree with git am, and saw no issues. -- Pedro Alves

Re: [PATCH 1/2] Port gdbserver to GNU/Hurd

2013-09-06 Thread Pedro Alves
Hi! On 09/05/2013 08:29 PM, Pedro Alves wrote: +static int +gnu_read_memory (CORE_ADDR addr, unsigned char *myaddr, int length) +{ + int ret = 0; + task_t task = (gnu_current_inf + ? (gnu_current_inf-task +? gnu_current_inf-task-port : 0) : 0); + if (task == MACH_PORT_NULL

Re: [PATCH 1/2] Port gdbserver to GNU/Hurd

2013-09-05 Thread Pedro Alves
On 09/05/2013 11:53 AM, Yue Lu wrote: Hi, This is the my new patch. Thanks. Follows a few comments, by no means an in depth review. We'll probably need to iterate a few times. I'm counting on Thomas and others to help as well! I'm actually very excited to see gdb and gdbserver sharing a

Re: [PATCH 1/2] Port gdbserver to GNU/Hurd

2013-09-03 Thread Pedro Alves
that way. Moving them under gdb/nat/ can be left for a cleanup step further down the road. Could we try that approach? -- Pedro Alves

Re: [patch] for mig check in GDB's configure

2013-05-03 Thread Pedro Alves
will want to run mig even on cross gdbs hosted on GNU Hurd, though... -- Pedro Alves

Re: [PATCH,HURD] hurd: compliance fixes for getgroups

2012-04-28 Thread Pedro Alves
name itself should be lower case, but write it in upper case when you are speaking about the value rather than the variable itself. Thus, “the inode number NODE_NUM” rather than “an inode”. -- Pedro Alves

Re: Restore GNU/Hurd functionality (was: Modernize solaris threads support.)

2009-07-20 Thread Pedro Alves
). What do you think about it? Could you try it if you like it? -- Pedro Alves 2009-07-20 Pedro Alves pe...@codesourcery.com * gnu-nat.c (gnu_mourn_inferior): Use the passed in target_ops instead of the gnu_ops global. (gnu_create_inferior): Inline `attach_to_child', use

Re: Restore GNU/Hurd functionality

2009-07-20 Thread Pedro Alves
;'' is missing. Fixed. Thanks. I'll commit the patch in a bit. -- Pedro Alves

Re: [PATCH?] GDB HEAD (partly) broken for GNU/Hurd

2008-10-13 Thread Pedro Alves
of handle_inferior_event logic :-( ) What do you guys think? Thomas, could you try the attached patch on the Hurd, please? I just gave it a spin on x86-64-unknown-linux-gnu without regressions. -- Pedro Alves 2008-10-13 Pedro Alves [EMAIL PROTECTED] * fork-child.c (startup_inferior): Only set

Re: GDB HEAD (partly) broken for GNU/Hurd

2008-10-11 Thread Pedro Alves
going through the shell doing fork/execs, we see new threads at every exec, and the old threads disappear. Could you try adding a `switch_to_thread (resume_thread)' somewhere after target_wait returns and before any other target method? -- Pedro Alves

Re: GDB HEAD (partly) broken for GNU/Hurd

2008-10-10 Thread Pedro Alves
); + target_resume (minus_one_ptid, 0, TARGET_SIGNAL_0); The other thing I suggest to look at, is to make sure the local `pending_execs' and the `gnu-nat.c:struct inf'::pending_execs aren't in conflict, but it doesn't look like it. Hope this helps. -- Pedro Alves

Re: GDB HEAD (partly) broken for GNU/Hurd

2008-10-09 Thread Pedro Alves
built (natively) on the same up-to-date Debian GNU/Hurd system. For easy reproduction, I can publish the faulting binary. Could you check what caused the breakage? It *may* have been the ptid changes I made, or not. 2008-09-08 Pedro Alves [EMAIL PROTECTED] Use ptid_t.tid to store