In data sabato 28 novembre 2020 20:02:52 CET, Samuel Thibault ha scritto:
> Hello Pino,
>
> Pino Toscano, le sam. 28 nov. 2020 19:45:12 +0100, a ecrit:
> > Can AT_NO_AUTOMOUNT be (easily) implemented in the hurd lookup bits?
>
> I would say that it simply maps to O_NOTRANS?
,
--
Pino Toscano
signature.asc
Description: This is a digitally signed message part.
ome.
You don't need to duplicate the whole __host_adjust_time call:
struct timeval dummy;
..
if (olddelta == NULL)
olddelta = &dummy;
should be enough.
--
Pino Toscano
ts.
IIRC it should unlink the existing socket path before trying to bind the
unix socket to the specified path -- otherwise you'd get EADDRINUSE.
--
Pino Toscano
signature.asc
Description: This is a digitally signed message part.
y, any strong reason to not change mig??
> >
> > Having to deal with the introduced incompatibility.
>
> Incompatibility with what, older versions of glibc/hurd/mach/mig, which
> ones?
If your suggestion is to remove the argument from
__mig_dealloc_reply_port, that isn't an option, as it would be an ABI
break in libc.
--
Pino Toscano
the same way.
--
Pino Toscano
p11-kit should
avoid using __libc_enable_secure for getauxval(AT_SECURE)
b) the behaviour is wrong and should be fixed in Hurd
?
Thanks,
--
Pino Toscano
signature.asc
Description: This is a digitally signed message part.
t;
> -thread_info_t thread_info;
> +struct thread_info thread_info;
Or what about simply getting rid of thread_info_t struct and thread_info
variable, since they don't seem to be used at all within nscd?
(Of course, that would require testing also on Linux.)
--
Pino Toscano
nown locations on Linux distributions are:
- /var/lib/random-seed (Fedora < F20, RHEL)
- /var/lib/systemd/random-seed (Fedora F20+, recent systemd)
- /var/lib/urandom/random-seed (Debian)
- /var/lib/misc/random-seed (SuSE)
(derivated distros are not included, but can be infered)
--
Pino Toscano
un/slabinfo.git
[...]
+ infos = malloc ((cache_info_count + 1) * sizeof *infos);
+ if (infos == NULL)
+ return ENOMEM;
What about using FILE + open_memstream to ease the output?
--
Pino Toscano
Scopri istella, il nuovo motore per il web italiano.
Istella garantisce risultati di qualità e la
task_get_name too, so we can implement
pthread_{get,set}name_np in libpthread?
Thanks!
--
Pino Toscano
Hi,
attached there is the (simple) implementation of the read-only
SO_ACCEPTCONN socket option in pflocal.
(pfinet could need it too, just need to dig into its Linux code more.)
May I push it?
Thanks,
--
Pino Toscano>From 18d76905be35500afdb8ef47c1086f6376540da4 Mon Sep 17 00:00:00 2001
F
into fuzzy search (which would find
/hurd/init and /sbin/init).
--
Pino Toscano
signature.asc
Description: This is a digitally signed message part.
= 0) to MAXSYMLINKS if defined.
--
Pino Toscano
signature.asc
Description: This is a digitally signed message part.
on could be get the md5sum of /etc/inittab, and compare
it with the one of the current version (the one with old paths): if they
match, then the user did not change it at all, and it can be just
replaced; if does not match, either ask the user what to do, or simply
move the old file as .dpkg-old and
= FALSE,
> + MTAB_TRUE = TRUE,
> + MTAB_UNINITIALIZED,
> +};
> +
> +static int
> +rootdir_mounts_exists ()
parameter-less, so add void
> +{
> + static enum mtab_translator_state state = MTAB_UNINITIALIZED;
> + if (state == MTAB_UNINITIALIZED)
> +state = access(MTAB_T
Hi,
Alle martedì 9 luglio 2013, Justus Winter ha scritto:
> Ignore the --nodev, --noexec and --nosuid arguments.
Why nodev? The only consumer of it seems to be sysvinit, which has been
patched to not pass nodev also on Hurd (in addition to kFreeBSD) when
mounting /proc.
--
Pino Tosc
1,6 +51,7 @@ debian/tmp/bin/storeread
> debian/tmp/bin/msgport
> debian/tmp/bin/rpctrace
> debian/tmp/bin/mount
> +debian/tmp/bin/umount
> debian/tmp/bin/gcore
> debian/tmp/bin/fakeauth
> debian/tmp/usr/bin/fakeroot-hurd
That said, this seems fine, I've just applied it.
--
Pino Toscano
signature.asc
Description: This is a digitally signed message part.
Hi,
Alle sabato 28 gennaio 2012, Pino Toscano ha scritto:
> I implemented in swapon the -e/--ifexists option close as to what's
> in util-linux' swapon. It basically ignores unexisting devices/files
> when doing `swapon -a`, i.e. only for the devices found in fstab
> (not
> Additionally a lot of patches are pending (due to the long freeze
> period) see e.g.
> http://bugs.debian.org/cgi-bin/pkgreport.cgi?tag=hurd;users=debian-h
> u...@lists.debian.org so the percentage could be much higher.
"a lot of patches" is surely not true (and we had the a similar amount
also in non-freeze period), and a number of those won't give actually
much.
With the above changes and Michael Banck's note that it is a "Debian
GNU/Hurd port release", it'd be good IMHO.
--
Pino Toscano
signature.asc
Description: This is a digitally signed message part.
ntended to apply to a
> variety of environments is just icky.
Well, there are two cases only (at least for this flag): glibc >= 2.18
(not released yet) which has it, and glibc < 2.18 which doesn't.
--
Pino Toscano
signature.asc
Description: This is a digitally signed message part.
Hi,
the attached patch makes use of the ST_NOATIME flag I just added in
glibc for statvfs/fstatvfs, by making libdiskfs expose it if needed in
its file_statfs implementation. (This will automatically cover ext2fs
and tmpfs, for example).
OK to push?
--
Pino Toscano
From
Hi,
a simple patch to provide the GNU-specific ST_NOATIME flag for statvfs
(which is already available on Linux).
Once this patch is accepted, it will follow an Hurd patch to expose this
attribute in libdiskfs-based translators (such as ext2fs and tmpfs).
Thanks,
--
Pino Toscano
Hurd: add
host_os}" in
gnu*)
# Needed for GNU/Hurd.
AC_CHECK_TOOL(MIG, mig)
if test "$MIG" = "" ; then
AC_MSG_ERROR([no mig for use])
fi
;;
esac
that is, look for mig as mandatory only on Hurd, using a less-ambiguous
variable as $host_os.
--
Pino Toscano
signature.asc
Description: This is a digitally signed message part.
hanges above.
I should have added useful/explaining comments in the various commits;
my main concern is the various GNU changelog bits, which most probably
need some through review.
Comments, questions, etc are welcome.
Thanks,
--
Pino Toscano
signature.asc
Description: This is a digitally signed message part.
Alle martedì 19 marzo 2013, Thomas Schwinge ha scritto:
> On Fri, 15 Mar 2013 22:39:07 +0000, Pino Toscano
wrote:
> > commit 7674ea1101a508e65b59b717d549c30b81c8a18e
> > Author: Pino Toscano
> > Date: Fri Mar 15 23:38:52 2013 +0100
> >
> > more cha
;hurd", isn't
it?
Thanks,
--
Pino Toscano
From 1d14864c9908ffa9fafdd7b281fe90236c294d8e Mon Sep 17 00:00:00 2001
From: Pino Toscano
Date: Thu, 14 Mar 2013 17:32:04 +0100
Subject: [PATCH] Switch from cthreads to pthreads
Makefiles, headers, types, macros and function calls are renamed wh
Update of bug #32755 (project hurd):
Category:None => Hurd Servers
Open/Closed:Open => Closed
___
Follow-up Comment #4:
As per Maksym's commen
Update of bug #27184 (project hurd):
Status: Confirmed => Fixed
Assigned to:None => jkoenig
Open/Closed:Open => Closed
_
Alle venerdì 1 marzo 2013, Samuel Thibault ha scritto:
> Pino Toscano, le Fri 01 Mar 2013 16:27:03 +0100, a écrit :
> > Side question: do we have git hooks to automatically close bugs and
> > tasks with commits?
>
> I don't know.
Hm ok.
> > + newval
?
Thanks,
--
Pino Toscano
From 7c60857c44b0792a1a79ebd4fd07704c2a712609 Mon Sep 17 00:00:00 2001
From: Pino Toscano
Date: Fri, 1 Mar 2013 15:48:37 +0100
Subject: [PATCH] rpctrace: implement -E
Add a -E option to rpctrace, much like its strace's equivalent, to add/change/unset environment vari
Hi,
attached a small patch to include or in few places
where they were needed, to fix the compilation warnings about lacks of
prototypes.
May I push it?
--
Pino Toscano
From e652274733eeba8a753623dc61bd781c35f93c93 Mon Sep 17 00:00:00 2001
From: Pino Toscano
Date: Mon, 25 Feb 2013 21:51
Alle mercoledì 13 febbraio 2013, Svante Signell ha scritto:
> On Wed, 2013-02-13 at 00:08 +0100, Pino Toscano wrote:
> > Alle mercoledì 13 febbraio 2013, Svante Signell ha scritto:
> > > On Tue, 2013-02-12 at 23:52 +0100, Pino Toscano wrote:
> > > > Alle martedì 12 fe
Alle mercoledì 13 febbraio 2013, Samuel Thibault ha scritto:
> Pino Toscano, le Wed 13 Feb 2013 00:08:21 +0100, a écrit :
> > Alle mercoledì 13 febbraio 2013, Svante Signell ha scritto:
> > > On Tue, 2013-02-12 at 23:52 +0100, Pino Toscano wrote:
> > > > Alle ma
Alle mercoledì 13 febbraio 2013, Svante Signell ha scritto:
> On Tue, 2013-02-12 at 23:52 +0100, Pino Toscano wrote:
> > Alle martedì 12 febbraio 2013, Svante Signell ha scritto:
> > > * change the FD_SETSIZE upper value check to larger than or
> > > equal
&g
s, you
need to allow FD_SETSIZE as maximum number of fd's.)
Please remove this change, which is wrong.
--
Pino Toscano
signature.asc
Description: This is a digitally signed message part.
se are probably not errors.
>
> Indeed, you need to let a couple of signals through:
>
> handle SIGPWR noprint nostop
> handle SIGXCPU noprint nostop
>
> See ‘gdbinit’ in the Guile distro.
You will need to make gdb ignore and let through SIGUSR1 and SIGUSR2,
which ar
ally, do a commit removing the bsd file.
Done, I think I should have done everything correctly.
The addition of was needed on Hurd (I tested it before
sending the first version of this ulimit rework) -- in any case,
LONG_MAX is explicitly used, so that include is not wrong.
Thanks,
--
Pino Toscan
Alle martedì 22 gennaio 2013, Svante Signell ha scritto:
> On Tue, 2013-01-22 at 19:15 +0100, Pino Toscano wrote:
> > Alle martedì 22 gennaio 2013, Svante Signell ha scritto:
> > > Attached is the first patch for a 3-way split of hurdselect.c
> > > into three
d[i].ulink); if (d[i].io_port != MACH_PORT_NULL)
> continue;
> - }
why is this check removed? When collecting inputs from poll,
d[i].io_port is the fd passed, which has no guarantee to be lower than
_hurd_dtablesize.
--
Pino Toscano
signature.asc
Description: This is a digitally signed message part.
, the case for having it at all is
> inordinately weak.
OK.
Attached there are the two patches of the ulimit reorganization, as you
suggested in a previous email:
1) move the linux implementation as posix (including limits.h)
2) remove the bsd implementation
Thanks,
--
Pino Toscano
ulimit: move lin
Alle giovedì 6 dicembre 2012, Thomas Schwinge ha scritto:
> Hi!
>
> On Thu, 6 Dec 2012 17:57:32 +0100, Pino Toscano
wrote:
> > Initial implementation of statfs reply, just returning the
> > filesystem type and its id.
> >
> > * netfs.c: Include and .
>
Hi,
attached there is a small patch for procfs to implement statfs,
returning only the two fields we can fill for sure.
May I push it?
Thanks,
--
Pino Toscano
From 1b7ad5c5d601b6388f0fc871b4fa42d231c05400 Mon Sep 17 00:00:00 2001
From: Pino Toscano
Date: Thu, 6 Dec 2012 17:51:58 +0100
Subject
ig and
> libx11-dev (neither was installed by apt-get build-dep hurd, or
> build-essential or devscripts).
Those have been added by Samuel in the packaging repository some time
ago, and will be part of the next upload.
--
Pino Toscano
signature.asc
Description: This is a digitally signed message part.
ven the history, the least of
> avaialble evils is to make the Hurd implementation consistent with
> the others and do the check.
(few months later... I forgot I sent this patch, so I'm bring it again.)
I updated the patch; is it okay to commit, or should I bring back the
buf==NULL check?
--
Pi
of comment added.
--
Pino Toscano
muntrace: reset file and hooks before finalizing the stream
fclose will call free, invoking its hook, then fprintf which would indirectly
try to allocate a buffer, and this can cause malloc to be used (thus its hook
to be invoked) if libio uses malloc instead o
Hi,
Alle lunedì 19 novembre 2012, Pino Toscano ha scritto:
> simple implementation of the Linux-ish syncfs on Hurd.
Updated patch according to Roland's and Christoph's comments (thanks!)
--
Pino Toscano
Hurd: implement syncfs
2012-11-19 Pino Toscano
* sysdeps/mach/hurd/syncf
t; Third commit: remove sysdeps/unix/bsd/ file.
OK, I will split the commits once approved.
--
Pino Toscano
signature.asc
Description: This is a digitally signed message part.
Hi,
simple implementation of the Linux-ish syncfs on Hurd.
Thanks,
--
Pino Toscano
Hurd: implement syncfs
2012-11-19 Pino Toscano
* sysdeps/mach/hurd/syncfs.c: New file.
--- /dev/null
+++ b/sysdeps/mach/hurd/syncfs.c
@@ -0,0 +1,33 @@
+/* Copyright (C) 2012 Free Software Foundation, Inc
Hi,
(bug-hurd only for this)
Alle sabato 17 novembre 2012, Pino Toscano ha scritto:
> Ignoring the fact that in libio mmap is not used on Hurd (it will
> need a different fix),
This has been reported by Thomas Schwinge one year ago:
http://thread.gmane.org/87mx
this be considered
acceptable?
Thanks,
--
Pino Toscano
Simplify ulimit implementations
The ulimit implementation in sysdeps/unix/bsd/ulimit.c produces wrong return
values, while sysdeps/unix/sysv/linux/ulimit.c is generally better. Thus,
copy the latter into a more general sysdeps/unix/ulimit.c
y after that close the file.
Thanks,
--
Pino Toscano
#0 0x0106281c in swtch_pri () at /build/buildd-eglibc_2.13-36-hurd-i386-IvO_gk/eglibc-2.13/build-tree/hurd-i386-libc/mach/swtch_pri.S:2
#1 0x010640a4 in __spin_lock_solid (lock=0x11ded74) at spin-solid.c:27
#2 0x0106429d in __mutex_lock_sol
Hi,
the attached patch makes check-local-headers.sh ignore headers from the
"mach" subdirectory, since they the Mach kernel headers used to build
glibc on Hurd.
Thanks,
--
Pino Toscano
check-local-headers: ignore Mach kernel headers
2012-11-16 Pino Toscano
* scripts/c
with glibc < 2.16.
Also, I'm slightly in doubt about the ChangeLog snippet, not totally
sure about how to write it properly in this case.
--
Pino Toscano
From 64d00b6482f03f7dfb6f3d4775a9bf44e53cec63 Mon Sep 17 00:00:00 2001
From: Pino Toscano
Date: Fri, 16 Nov 2012 15:04:29 +0100
Subjec
SIX.1 specifies EINVAL for a file descriptor on which
> sync is not supported.
Attached an updated patch to handle only EOPNOTSUPP, with comment added.
Thanks,
--
Pino Toscano
Hurd: fix fdatasync/fsync if the fd does not support file_sync
Handle the case of the fd port implementing a stub
e (i.e. pflocal), libtrivfs is used, EOPNOTSUPP is
> returned, right?
The run above would have fsync() set errno = -303, MIG_BAD_ID.
--
Pino Toscano
signature.asc
Description: This is a digitally signed message part.
Alle mercoledì 29 agosto 2012, Pino Toscano ha scritto:
> attached there is a minor patch to fix the return values of
> unimplemented cases, i.e. using __hurd_fail to set EOPNOTSUPP
> properly.
Ping.
--
Pino Toscano
signature.asc
Description: This is a digitally signed message part.
Alle mercoledì 29 agosto 2012, Pino Toscano ha scritto:
> Hurd's implementations of fdatasync and fsync do not take into
> account the fact that file_sync could not be implemented in the
> receiving port, or implemented as stub, returning (E)MIG_BAD_ID or
> EOPNOTSUPP. Attached th
binary compatibility,
and a filesystem providing such diskfs_pathconf implementation should
run fine even with an older libdisks (but I did not test this case).
What do you think about this solution?
--
Pino Toscano
--- a/libdiskfs/diskfs.h
+++ b/libdiskfs/diskfs.h
@@ -553,6 +553,9
nly fatfs,
IIRC) do not support symlinks.
I've reverted the commit, and going to propose a better (I hope)
solution for this.
Thanks,
--
Pino Toscano
signature.asc
Description: This is a digitally signed message part.
Alle mercoledì 3 ottobre 2012, Thomas Schwinge ha scritto:
> Hi!
>
> On Wed, 3 Oct 2012 17:50:38 +0200, Pino Toscano
wrote:
> > Alle martedì 2 ottobre 2012, Thomas Schwinge ha scritto:
> > > On Mon, 1 Oct 2012 19:59:35 +0200, Pino Toscano
> >
> > wrote:
&g
Hi,
Alle lunedì 1 ottobre 2012, Andreas Jaeger ha scritto:
> On Sunday, September 30, 2012 17:53:33 Pino Toscano wrote:
> > attached there is a patch to add a custom version (copied from the
> > unix sysdep) of confstr.h, to avoid using the bsd header which adds
> > a n
Alle martedì 2 ottobre 2012, Thomas Schwinge ha scritto:
> Hi!
>
> On Mon, 1 Oct 2012 19:59:35 +0200, Pino Toscano
wrote:
> > Alle giovedì 27 settembre 2012, Thomas Schwinge ha scritto:
> > > On Mon, 24 Sep 2012 02:04:05 +0200, Guillem Jover
> >
> > wrote:
Hi,
Alle giovedì 27 settembre 2012, Thomas Schwinge ha scritto:
> On Mon, 24 Sep 2012 02:04:05 +0200, Guillem Jover
wrote:
> > On Mon, 2012-09-24 at 00:30:39 +0200, Pino Toscano wrote:
> > > Alle lunedì 24 settembre 2012, Thomas Schwinge ha scritto:
> > > > On M
Hi,
The following two patches allow to
a) make use of the "pthread" glibc sysdep, which provides implementation
for some functions using pthreads (e.g. aio stuff)
b) hook the libpthread version inside glibc, so it is properly returned
by confstr.
--
Pino To
Hi,
attached there is a patch to add a custom version (copied from the unix
sysdep) of confstr.h, to avoid using the bsd header which adds a non-
existing /usr/ucb.
Thanks,
--
Pino Toscano
Hurd: fix the _CS_PATH getconf value
Copy sysdeps/unix/confstr.h to avoid using sysdeps/unix/bsd
Hi,
attached there is a simple patch to make
(f)pathconf(path, _PC_2_SYMLINKS) working for libdiskfs-based
translators, properly indicating whether the FS supports symlinks.
Thanks,
--
Pino Toscano
From edbb0cc20709e0599e1490b81aa1841114f3f0bc Mon Sep 17 00:00:00 2001
From: Pino Toscano
Date
Alle venerdì 28 settembre 2012, Roland McGrath ha scritto:
> That change looks fine if the test still passes on Linux.
It does on Linux/x86_64, so I pushed it.
Thanks for the reviews,
--
Pino Toscano
signature.asc
Description: This is a digitally signed message part.
gle socket.
>
> I think the intent of the change is to test the mknodat interface,
> not any particular kind of node. Just change the test to create a
> FIFO instead.
Right, patch attached.
--
Pino Toscano
tst-mknodat: create a FIFO instead of a socket
A FIFO is the only special fi
ince all it does is testing the creation of a single socket.
--
Pino Toscano
signature.asc
Description: This is a digitally signed message part.
umber provided.
Thanks,
--
Pino Toscano
Hurd: mknodat: create also sockets
2012-09-28 Pino Toscano
* sysdeps/mach/hurd/xmknodat.c: Allow to create sockets. Simplify the
check for translators needing the device number.
--- a/sysdeps/mach/hurd/xmknodat.c
+++ b/sysdeps/mach/hurd/xmknodat.c
@@
Hi,
Alle lunedì 24 settembre 2012, Thomas Schwinge ha scritto:
> Generally OK, but two comments:
>
> On Mon, 24 Sep 2012 00:04:20 +0200, Pino Toscano
wrote:
> > Subject: [PATCH] configure: add --with-version-suffix=STRING
> >
> > Add the possibility to append a c
le of months.)
Thanks,
--
Pino Toscano
From 399f9112f763c095abe44567135307c554746e9e Mon Sep 17 00:00:00 2001
From: Pino Toscano
Date: Sun, 23 Sep 2012 23:53:00 +0200
Subject: [PATCH] configure: add --with-version-suffix=STRING
Add the possibility to append a custom string to the gnumach version s
> (http://lists.gnu.org/archive/html/bug-hurd/2012-03/msg00013.html)
> and [made console-run resilient against missing /dev/console]
> (http://lists.gnu.org/archive/html/bug-hurd/2012-03/msg2.html),
> improving the overall reliability of the system.
Not sure how they "improve
places.
Otherwise, I'm not yet sure how fix the lookup glibc functions.
As I said, I'm pretty new to the involved parts (lookup stuff), so if
you have more ideas I will hear them.
--
Pino Toscano
signature.asc
Description: This is a digitally signed message part.
Hi,
it seems that in some occasions (i.e on malloc failure) pthread_create
can return ENOMEM, which is not a valid POSIX error number.
Attached there is a patch for libpthread to normalize ENOMEM to EAGAIN.
Thanks,
--
Pino Toscano
From 2ee7e1e143784452ef325a0c80c106e972a3ffdc Mon Sep 17 00:00
Alle lunedì 10 settembre 2012, Samuel Thibault ha scritto:
> Pino Toscano, le Mon 10 Sep 2012 17:31:32 +0200, a écrit :
> > Alle domenica 9 settembre 2012, Samuel Thibault ha scritto:
> > > Pino Toscano, le Fri 07 Sep 2012 20:02:56 +0200, a écrit :
> > > > +static i
Alle domenica 9 settembre 2012, Samuel Thibault ha scritto:
> Pino Toscano, le Fri 07 Sep 2012 20:02:56 +0200, a écrit :
> > +static int args_filename_length (const char *name)
> > +{
> > + const char *p = name;
> > + while (*p != '\0' && *p != &#x
,
--
Pino Toscano
From a35bd267aba2954df85ee3403981395bf8c9e736 Mon Sep 17 00:00:00 2001
From: Pino Toscano
Date: Fri, 7 Sep 2012 18:21:00 +0200
Subject: [PATCH 1/2] tmpfs: extract size string parsing in an own function
* tmpfs/tmpfs.c (parse_opt_size): New function, broken out of ...
(parse_opt
Hi,
attached there is a new patch for procfs to improve again the file name
in stat/status files for PIDs.
Basically, it just considers only the first word in case the process
name has more (e.g. when it changed its own).
Thanks,
--
Pino Toscano
From ebf2b049ea6963026766763df1697467f5806327
Hi,
attached there is a minor patch to fix the return values of
unimplemented cases, i.e. using __hurd_fail to set EOPNOTSUPP properly.
Thanks,
--
Pino Toscano
Hurd: ptrace: use __hurd_fail for EOPNOTSUPP
2012-08-29 Pino Toscano
* sysdeps/mach/hurd/ptrace.c (ptrace): Use __hurd_fail to
POSIX.
Thanks,
--
Pino Toscano
Hurd: fix fdatasync/fsync if the fd does not support file_sync
Handle the case of the fd port not implementing file_sync (returning MIG_BAD_ID) or implementing a stub (EOPNOTSUPP),
properly returning EINVAL.
2012-08-29 Pino Toscano
* sysdeps/mach/hurd/fdatasync.c: Tur
a1_native and
a2_native).
Does it look good?
--
Pino Toscano
Provide a generic empty version of __check_native.
Add an empty implementation of __check_native, as used in the posix version of getaddrinfo.
This allows non-Linux GNU-based OSes to compile.
2012-07-26 Pino Toscano
* inet
second.
>
> Otherwise that looks fine, so go ahead and commit it with that
> change.
Ok, I will do.
Thanks,
--
Pino Toscano
signature.asc
Description: This is a digitally signed message part.
Hi,
the attached patch implements renameat for Hurd; it seems to work fine,
and tst-renameat now passes.
The copyright starts from the year of the rename implementation, as I
basically copied it and slightly adapted to the "at" behaviour.
Thanks,
--
Pino Toscano
Hurd: implemen
Hi,
Alle mercoledì 13 giugno 2012, Pino Toscano ha scritto:
> Alle martedì 12 giugno 2012, Roland McGrath ha scritto:
> > That's almost right, but you should avoid calling
> > __mach_port_deallocate if APORT is MACH_PORT_NULL. Also, avoid
> > shadowing the local variabl
attached patch comments them out (instead of removing them, to keep
their placeholders).
Thanks,
--
Pino Toscano
Hurd: comment PF_LINK/AF_LINK defines
Comment out the PF_LINK and AF_LINK defines, since they are usually associated
with struct sockaddr_dl, which is not available on Hurd.
2012-06
F_LINK/AF_LINK
defines be the right solution?
--
Pino Toscano
signature.asc
Description: This is a digitally signed message part.
Hi,
two simple patches to implement llistxattr and lremovexattr the same way
respectively listxattr and removexattr are implemented, just passing
O_NOLINK. This way all the *xattr functions are implemented, at least to
use the internal _hurd_xattr_*.
Thanks,
--
Pino Toscano
Hurd: provide
aw other cases of shadowing by internal subroutines, and
assumed it was okay (since inside them you want to refer to the local
"err" instead of the outermost one.
Thanks for the further review, patch attached.
(I would use the non-ChangeLog lines of the patch header as commit log,
would that
> structure and port are kept alive around the AF_LOCAL case's calls,
> but that seems OK.
Done.
Updated patch attached.
--
Pino Toscano
Hurd: sendto: do not crash when ADDR is NULL
Create a new create_address_port subroutine to isolate the address port creation
(for both local and
Hi,
currently, sendto() crashes when the specified addr is NULL; the
attached patch fixes it making sendto() with NULL addr behave as it
would be a plain send().
Thanks,
--
Pino Toscano
Hurd: sendto: do not crash when addr is NULL
Work also when the specified addr is NULL; simplify also the
Hi,
attached there is a patch to make Mach's nanosleep() (used by Hurd) a
bit more POSIX compliant:
* check for validity of the `requested_time' parameter
* return EINTR when interrupted
* modify correctly the `remaining' parameter only when interrupted
Thanks,
--
Pino Toscano
m
Alle sabato 10 dicembre 2011, Pino Toscano ha scritto:
> attached there is a patch to add some validation for parameters of
> Mach's nanosleep() (used by Hurd).
Disregard this patch -- I'll send a better one with more fixes for
nanosleep.
--
Pino Toscano
signature.asc
Descri
tsname_r(fd, NULL, 0) would be properly failing with EINVAL (and the
man page even explicitly mention that return value, unlike with
basically most of the other functions). Should gnulib do that check only
on Linux, then?
Attached the updated patch, also with the hits of the other reviews.
Thanks
sarily catch it
> anyway. If you want that sort of paranoia, use __strnlen (login,
> sizeof login - 1).
>
> If you've already called strlen/strnlen then don't use strncpy,
> just use memcpy with the known length.
Fixed.
Attached there is the updated patch.
--
Pino Tosc
Alle venerdì 27 aprile 2012, Roland McGrath ha scritto:
> > 2012-04-27 Pino Toscano
> >
> > * sysdeps/mach/hurd/getgroups.c (__getgroups): Return -1 and set
> > EINVAL for negative `n' or less than `ngids'.
>
> The norm is to use all caps
Hi,
attached there is a patch to fix few issues in Hurd's ptsname_r(),
mostly checking for more error conditions and making sure to set as
errno and return the proper values on error conditions.
Thanks,
--
Pino Toscano
hurd: compliance fixes for ptsname_r
ptsname_r on failure return
Hi,
attached there is a patch to fix few issues in Hurd's getlogin_r():
avoid a static buffer, and check for buffer shorter than necessary.
Thanks,
--
Pino Toscano
hurd: compliance fixes for getlogin_r
* do not make `login' static, as it would make getlogin_r no more reentrant
*
of
failing).
Thanks,
--
Pino Toscano
hurd: compliance fixes for getgroups
Fail with EINVAL when the requested number of groups is negative,
or when it is positive but less than the actual number of groups.
2012-04-27 Pino Toscano
* sysdeps/mach/hurd/getgroups.c (__getgroups): Return -1 and set
1 - 100 of 135 matches
Mail list logo
