That change is good but it needs a comment. You don't need to go into
great detail, just say that we call fprintf+fclose after clearing the
hooks to match how mtrace called fopen+fprintf before setting them.
Thanks,
Roland
Alle lunedì 19 novembre 2012, Roland McGrath ha scritto:
That change is good but it needs a comment. You don't need to go
into great detail, just say that we call fprintf+fclose after
clearing the hooks to match how mtrace called fopen+fprintf before
setting them.
A bit of comment added.
--
That is fine as is, though it's preferable to use C99-style inline
declarations.
Hi,
(bug-hurd only for this)
Alle sabato 17 novembre 2012, Pino Toscano ha scritto:
Ignoring the fact that in libio mmap is not used on Hurd (it will
need a different fix),
This has been reported by Thomas Schwinge one year ago:
Hi,
I was debugging on Hurd a misbehaviour of muntrace, which would just
spin taking 100% CPU: using a simple test like:
--v--
#include mcheck.h
int main()
{ mtrace(); muntrace(); return 0; }
--^--
when run as `MALLOC_TRACE=out test`, you get a backtrace like the
attached trace.log
