Re: [PATCH] gnumach/ddb: use and cleanup db_print.h

2013-07-06 Thread Samuel Thibault
Marin Ramesa, le Sat 06 Jul 2013 14:35:26 +0200, a écrit : > On 05.07.2013 00:15:29, Samuel Thibault wrote: > > etc. Ideally all these would go into common .h files. > > I made a first version of this patch. Thanks. > I also found an unused function, > which is a plus in my cleanup project. W

Re: [PATCH] gnumach/ddb: use and cleanup db_print.h

2013-07-06 Thread Marin Ramesa
On 05.07.2013 00:15:29, Samuel Thibault wrote: > etc. Ideally all these would go into common .h files. I made a first version of this patch. I also found an unused function, which is a plus in my cleanup project. Here's the patch: * ddb/db_write_cmd.h: New file. (db_write_cmd): Add prototype. I

Re: [PATCH] gnumach/ddb: use and cleanup db_print.h

2013-07-04 Thread Samuel Thibault
Marin Ramesa, le Tue 02 Jul 2013 11:41:55 +0200, a écrit : > So, I made a preliminary patch with db_print.h. I don't really know if > this is an improvement over having extern statements in db_command.c. It is: by making the .c file (that defines the function) include the .h file, it permits to

[PATCH] gnumach/ddb: use and cleanup db_print.h

2013-07-02 Thread Marin Ramesa
I quote the project page: "For some of the internal header files (containing function prototypes and the like), it might actually be useful to use them. (And then get rid of a bunch of extern ... statements in other files.)". So, I made a preliminary patch with db_print.h. I don't really know i