Re: [PATCH 1/2] hurd: Remove the ecx kludge

2023-03-01 Thread Samuel Thibault
And I'll upload the fix to debian, possibly that'll fix some bugs we have seen in golang packages builds. Samuel Thibault, le jeu. 02 mars 2023 00:33:09 +0100, a ecrit: > Applied, thanks! > > Sergey Bugaev, le mer. 01 mars 2023 19:23:54 +0300, a ecrit: > > "We don't need it any more" > > > > The

Re: [PATCH 1/2] hurd: Remove the ecx kludge

2023-03-01 Thread Samuel Thibault
Applied, thanks! Sergey Bugaev, le mer. 01 mars 2023 19:23:54 +0300, a ecrit: > "We don't need it any more" > > The INTR_MSG_TRAP macro in intr-msg.h used to play little trick with > the stack pointer: it would temporarily save the "real" stack pointer > into ecx, while setting esp to point to ju

Re: [PATCH 1/2] hurd: Remove the ecx kludge

2023-03-01 Thread Samuel Thibault
Luca, le mer. 01 mars 2023 19:01:02 +0100, a ecrit: > I still have to fully understand the existing code, so this might be > something completely wrong... but if interrupting an rpc is a complex thing > to do reliably in user space, why not add some kernel support? Also, how do > you test this code

Re: [PATCH 1/2] hurd: Remove the ecx kludge

2023-03-01 Thread Luca
Hi, Il 01/03/23 17:23, Sergey Bugaev ha scritto: "We don't need it any more" The INTR_MSG_TRAP macro in intr-msg.h used to play little trick with the stack pointer: it would temporarily save the "real" stack pointer into ecx, while setting esp to point to just before the message buffer, and the

[PATCH 1/2] hurd: Remove the ecx kludge

2023-03-01 Thread Sergey Bugaev
"We don't need it any more" The INTR_MSG_TRAP macro in intr-msg.h used to play little trick with the stack pointer: it would temporarily save the "real" stack pointer into ecx, while setting esp to point to just before the message buffer, and then invoke the mach_msg trap. This way, INTR_MSG_TRAP