Re: [PATCH 1/3] rumpdisk: define RUMP_REGISTER_T

2021-12-21 Thread Samuel Thibault
Damien Zammit, le lun. 20 déc. 2021 18:08:23 +1100, a ecrit: > On 20/12/21 4:05 am, Samuel Thibault wrote: > > A commit log message needs to include the "why" of the commit. > > Sorry, this is somewhat of a hack to work around a conflicting "register_t" > definition. Ok. AIUI it should rather be

Re: [PATCH 1/3] rumpdisk: define RUMP_REGISTER_T

2021-12-20 Thread Damien Zammit
Hi Samuel, On 20/12/21 4:05 am, Samuel Thibault wrote: > A commit log message needs to include the "why" of the commit. Sorry, this is somewhat of a hack to work around a conflicting "register_t" definition. We need to fix it in the librump configuration at compile time but I couldn't quite fig

Re: [PATCH 1/3] rumpdisk: define RUMP_REGISTER_T

2021-12-19 Thread Samuel Thibault
Hello, A commit log message needs to include the "why" of the commit. Damien Zammit, le sam. 18 déc. 2021 17:08:45 +1100, a ecrit: > --- > rumpdisk/block-rump.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/rumpdisk/block-rump.c b/rumpdisk/block-rump.c > index 398289fb..8c29dc01 1006

[PATCH 1/3] rumpdisk: define RUMP_REGISTER_T

2021-12-17 Thread Damien Zammit
--- rumpdisk/block-rump.c | 1 + 1 file changed, 1 insertion(+) diff --git a/rumpdisk/block-rump.c b/rumpdisk/block-rump.c index 398289fb..8c29dc01 100644 --- a/rumpdisk/block-rump.c +++ b/rumpdisk/block-rump.c @@ -31,6 +31,7 @@ #include #define MACH_INCLUDE +#define RUMP_REGISTER_T #incl