Re: [PATCH 10/11] i386/i386/db_trace.c: return reg value

2013-11-20 Thread Samuel Thibault
Marin Ramesa, le Wed 20 Nov 2013 22:22:41 +0100, a écrit : > On 20.11.2013 22:10:54, Samuel Thibault wrote: > > Marin Ramesa, le Wed 20 Nov 2013 20:42:54 +0100, a écrit : > > > * i386/i386/db_trace.c (db_i386_reg_value): Return reg value. > > > > I don't see the returned value used anywhere. I'd

Re: [PATCH 10/11] i386/i386/db_trace.c: return reg value

2013-11-20 Thread Marin Ramesa
On 20.11.2013 22:10:54, Samuel Thibault wrote: > Marin Ramesa, le Wed 20 Nov 2013 20:42:54 +0100, a écrit : > > * i386/i386/db_trace.c (db_i386_reg_value): Return reg value. > > I don't see the returned value used anywhere. I'd say rather drop it > than returning something which is already return

Re: [PATCH 10/11] i386/i386/db_trace.c: return reg value

2013-11-20 Thread Samuel Thibault
Marin Ramesa, le Wed 20 Nov 2013 20:42:54 +0100, a écrit : > * i386/i386/db_trace.c (db_i386_reg_value): Return reg value. I don't see the returned value used anywhere. I'd say rather drop it than returning something which is already returned another way. > --- > i386/i386/db_trace.c | 1 + > 1

[PATCH 10/11] i386/i386/db_trace.c: return reg value

2013-11-20 Thread Marin Ramesa
* i386/i386/db_trace.c (db_i386_reg_value): Return reg value. --- i386/i386/db_trace.c | 1 + 1 file changed, 1 insertion(+) diff --git a/i386/i386/db_trace.c b/i386/i386/db_trace.c index 419fa0c..71b7620 100644 --- a/i386/i386/db_trace.c +++ b/i386/i386/db_trace.c @@ -178,6 +178,7 @@ db_i386_re