Re: [PATCH 3/6] ddb/db_break.c (db_delete_cmd): add missing returns

2013-12-15 Thread Samuel Thibault
Marin Ramesa, le Sun 15 Dec 2013 22:38:29 +0100, a écrit : > On 15.12.2013 20:25:24, Samuel Thibault wrote: > > Marin Ramesa, le Sun 15 Dec 2013 20:22:02 +0100, a écrit : > > > On 15.12.2013 20:14:03, Samuel Thibault wrote: > > > > Marin Ramesa, le Thu 12 Dec 2013 18:27:05 +0100, a écrit : > > > >

Re: [PATCH 3/6] ddb/db_break.c (db_delete_cmd): add missing returns

2013-12-15 Thread Marin Ramesa
On 15.12.2013 20:25:24, Samuel Thibault wrote: > Marin Ramesa, le Sun 15 Dec 2013 20:22:02 +0100, a écrit : > > On 15.12.2013 20:14:03, Samuel Thibault wrote: > > > Marin Ramesa, le Thu 12 Dec 2013 18:27:05 +0100, a écrit : > > > > There is a code path when db_error() can return. > > > > > > Which

Re: [PATCH 3/6] ddb/db_break.c (db_delete_cmd): add missing returns

2013-12-15 Thread Samuel Thibault
Marin Ramesa, le Sun 15 Dec 2013 20:22:02 +0100, a écrit : > On 15.12.2013 20:14:03, Samuel Thibault wrote: > > Marin Ramesa, le Thu 12 Dec 2013 18:27:05 +0100, a écrit : > > > There is a code path when db_error() can return. > > > > Which one? > > When _longjmp() _longjmp never returns. Samuel

Re: [PATCH 3/6] ddb/db_break.c (db_delete_cmd): add missing returns

2013-12-15 Thread Marin Ramesa
On 15.12.2013 20:14:03, Samuel Thibault wrote: > Marin Ramesa, le Thu 12 Dec 2013 18:27:05 +0100, a écrit : > > There is a code path when db_error() can return. > > Which one? When _longjmp() returns and db_recover and argument to db_error() are non-zero.

Re: [PATCH 3/6] ddb/db_break.c (db_delete_cmd): add missing returns

2013-12-15 Thread Samuel Thibault
Marin Ramesa, le Thu 12 Dec 2013 18:27:05 +0100, a écrit : > There is a code path when db_error() can return. Which one? Samuel

[PATCH 3/6] ddb/db_break.c (db_delete_cmd): add missing returns

2013-12-12 Thread Marin Ramesa
There is a code path when db_error() can return. Avoid, by writing returns, deleting the breakpoint when breakpoint number is not valid or there is no such breakpoint. * ddb/db_break.c (db_delete_cmd): Add missing returns. --- ddb/db_break.c | 2 ++ 1 file changed, 2 insertions(+) diff --git