Re: [PATCH 8/8] rpctrace: use condition variable to keep messages in sequence

"Brent W. Baccala" writes: > My solution is to signal the condition variable right before the call to > mach_msg, but this creates a race condition where messages can get > reordered. > > As you know, I never liked this blocking behavior of mach_msg, but I just > can't see

Re: [PATCH 8/8] rpctrace: use condition variable to keep messages in sequence

On Sat, Oct 29, 2016 at 1:48 PM, Brent W. Baccala wrote: > Yes, patch7 without patch8 can reorder messages as they're being resent, > but patch8 uses the mutex introduced in patch7, so the ordering can't be > reversed. > > They could be combined into a single patch. Do you

Re: [PATCH 8/8] rpctrace: use condition variable to keep messages in sequence

Brent W. Baccala, on Sat 29 Oct 2016 13:48:23 -1000, wrote: > I had thought of the entire patch set being applied monolithically. Yes, but that'll still appear as separate commits, that some people might fall in the middle of while bisecting something. > Yes, patch7 without patch8 can reorder

Re: [PATCH 8/8] rpctrace: use condition variable to keep messages in sequence

On Oct 29, 2016 2:55 AM, "Samuel Thibault" wrote: > > Hello, > > Better apply this patch before patch7, shouldn't we? Otherwise there's > a little git interval during which rpctrace is unreliable. > > Samuel I had thought of the entire patch set being applied

Re: [PATCH 8/8] rpctrace: use condition variable to keep messages in sequence

Hello, Better apply this patch before patch7, shouldn't we? Otherwise there's a little git interval during which rpctrace is unreliable. Samuel

[PATCH 8/8] rpctrace: use condition variable to keep messages in sequence

--- utils/rpctrace.c | 19 ++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git a/utils/rpctrace.c b/utils/rpctrace.c index 88b5e38..09911b3 100644 --- a/utils/rpctrace.c +++ b/utils/rpctrace.c @@ -131,6 +131,8 @@ struct traced_info mach_msg_type_name_t type; char