Re: [PATCH gnumach] Add x86_64 registers to i386_thread_state

2023-02-14 Thread Flávio Cruz
On Tue, Feb 14, 2023 at 2:51 PM Samuel Thibault wrote: > Sergey Bugaev, le mar. 14 févr. 2023 22:48:18 +0300, a ecrit: > > On Tue, Feb 14, 2023 at 10:20 PM Samuel Thibault > > wrote: > > > > > +#if defined(__x86_64__) && !defined(USER32) > > > > > + uint64_tefl; > > > > > > > > Sho

Re: [PATCH gnumach] Add x86_64 registers to i386_thread_state

2023-02-14 Thread Samuel Thibault
Sergey Bugaev, le mar. 14 févr. 2023 22:48:18 +0300, a ecrit: > On Tue, Feb 14, 2023 at 10:20 PM Samuel Thibault > wrote: > > > > +#if defined(__x86_64__) && !defined(USER32) > > > > + uint64_tefl; > > > > > > Should this not be 'rfl' (for 'rflags')? > > > > In both cases, that would

Re: [PATCH gnumach] Add x86_64 registers to i386_thread_state

2023-02-14 Thread Sergey Bugaev
On Tue, Feb 14, 2023 at 10:20 PM Samuel Thibault wrote: > > > +#if defined(__x86_64__) && !defined(USER32) > > > + uint64_tefl; > > > > Should this not be 'rfl' (for 'rflags')? > > In both cases, that would make the gnumach code have to distinguish the > two names, in the debugger an

Re: [PATCH gnumach] Add x86_64 registers to i386_thread_state

2023-02-14 Thread Samuel Thibault
Hello, Sergey Bugaev, le mar. 14 févr. 2023 14:03:22 +0300, a ecrit: > On Sun, Feb 12, 2023 at 9:26 PM Flavio Cruz wrote: > > > > This is required to implement ptrace. > > --- > > i386/i386/pcb.c| 42 +- > > i386/include/mach/i386/thread_status.h |

Re: [PATCH gnumach] Add x86_64 registers to i386_thread_state

2023-02-14 Thread Sergey Bugaev
On Sun, Feb 12, 2023 at 9:26 PM Flavio Cruz wrote: > > This is required to implement ptrace. > --- > i386/i386/pcb.c| 42 +- > i386/include/mach/i386/thread_status.h | 28 + > 2 files changed, 69 insertions(+), 1 deletion(-) > > diff

Re: [PATCH gnumach] Add x86_64 registers to i386_thread_state

2023-02-12 Thread Samuel Thibault
Applied, thanks! Flavio Cruz, le dim. 12 févr. 2023 13:26:29 -0500, a ecrit: > This is required to implement ptrace. > --- > i386/i386/pcb.c| 42 +- > i386/include/mach/i386/thread_status.h | 28 + > 2 files changed, 69 insertions(+)

[PATCH gnumach] Add x86_64 registers to i386_thread_state

2023-02-12 Thread Flavio Cruz
This is required to implement ptrace. --- i386/i386/pcb.c| 42 +- i386/include/mach/i386/thread_status.h | 28 + 2 files changed, 69 insertions(+), 1 deletion(-) diff --git a/i386/i386/pcb.c b/i386/i386/pcb.c index 9ac55a1c..ba856523