Here is an updated patch. I hope I got it right this time.
I added __attribute__ ((noreturn)) to i386_exception but I now get this
warning:
../i386/i386/trap.c: In function 'i386_exception':
../i386/i386/trap.c:634: warning: 'noreturn' function does return
But I don't see a return anywhere!??
Barry deFreese, le Mon 21 Jul 2008 11:01:31 -0400, a écrit :
Here is an updated patch. I hope I got it right this time.
I added __attribute__ ((noreturn)) to i386_exception but I now get this
warning:
../i386/i386/trap.c: In function 'i386_exception':
../i386/i386/trap.c:634: warning:
Samuel Thibault wrote:
snip
Indeed, but functions implicitely return at the end of it...
And in that case, that's why I said to add noreturn to i386_exception
and similar. exception() is one of those similars.
Samuel
Samuel,
OK fair enough but exception() does do a few returns, you want
Barry deFreese, le Mon 21 Jul 2008 11:33:57 -0400, a écrit :
Samuel Thibault wrote:
snip
Indeed, but functions implicitely return at the end of it...
And in that case, that's why I said to add noreturn to i386_exception
and similar. exception() is one of those similars.
OK fair enough
Samuel Thibault wrote:
Barry deFreese, le Mon 21 Jul 2008 11:33:57 -0400, a écrit :
Samuel Thibault wrote:
snip
Indeed, but functions implicitely return at the end of it...
And in that case, that's why I said to add noreturn to i386_exception
and similar. exception() is one of those
Barry deFreese, le Mon 21 Jul 2008 12:30:36 -0400, a écrit :
Samuel Thibault wrote:
See the comment, they shouldn't be reached, so yes you can, but also add
noreturn to the functions that are called just before, etc. ;)
OK I'm getting closer. I added noreturn to exception and
