Re: [PATCH] osdep/hurd/getroot: Fix 64bit build

2024-01-23 Thread Daniel Kiper
On Sun, Jan 21, 2024 at 05:22:29AM +0300, Vladimir 'phcoder' Serbinenko wrote: > LGTM > Reviewed-by: Vladimir Serbinenko Reviewed-by: Daniel Kiper Daniel

Re: [PATCH] osdep/hurd/getroot: Fix 64bit build

2024-01-20 Thread Vladimir 'phcoder' Serbinenko
LGTM Reviewed-by: Vladimir Serbinenko Le sam. 20 janv. 2024, 21:36, Samuel Thibault a écrit : > file_get_fs_options takes a mach_msg_type_number_t (32bit), not a size_t > (64bit on 64bit platforms). > --- > grub-core/osdep/hurd/getroot.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >

Re: [PATCH] osdep/hurd/getroot: Fix 64bit build

2024-01-20 Thread John Paul Adrian Glaubitz
On Sat, 2024-01-20 at 19:35 +0100, Samuel Thibault wrote: > file_get_fs_options takes a mach_msg_type_number_t (32bit), not a size_t > (64bit on 64bit platforms). Nitpick: I think it should be "32 bit", "64 bit" and "64-bit", the former two referring two a word size while the latter refers to the

Re: [PATCH] osdep/hurd/getroot: Fix 64bit build

2024-01-20 Thread Samuel Thibault
Samuel Thibault, le sam. 20 janv. 2024 19:35:13 +0100, a ecrit: > file_get_fs_options takes a mach_msg_type_number_t (32bit), not a size_t > (64bit on 64bit platforms). Signed-off-by: Samuel Thibault > --- > grub-core/osdep/hurd/getroot.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)