Hello,
Samuel Thibault, le sam. 27 juil. 2019 11:32:44 +0200, a ecrit:
> Samuel Thibault, le sam. 27 juil. 2019 11:09:56 +0200, a ecrit:
> > The issue here is actually that the source code is missing
> >
> > #define _FILE_OFFSET_BITS 64
> >
> > at the very top of the file.
>
> Or you can make the hooks use loff_t instead of off_t.
Either way, we should make sure to have warnings when it's not done.
I'm thinking that hurd/{triv,disk,net}fs.h could at least include the
prototypes for io_read/write etc. (those RPCs which do depend on this)
to make sure these are properly set (since the off_t thing is very
subtle).
I'm however wondering why we don't just ship the _S.h files in
/usr/include/hurd/, and make {triv,disk,net}fs.h include them?
Translators in hurd/ do include them manually already probably to
catch such errors, but I'd say it's part of the lib{triv,disk,net}fs
interfaces so we should just make any user of them include it?
Samuel
