Gianluca Guida, le Sun 08 Jan 2006 19:18:52 +0100, a écrit :
> On 1/8/06, Samuel Thibault <[EMAIL PROTECTED]> wrote:
> > The problem is that when opening a device (device_open), the port that
> > is returned to the user is &device->dev: see
> > device/ds_routines.c:device_open():
>
> Ok. The patch
On 1/8/06, Samuel Thibault <[EMAIL PROTECTED]> wrote:
> The problem is that when opening a device (device_open), the port that
> is returned to the user is &device->dev: see
> device/ds_routines.c:device_open():
Ok. The patch is functionally OK. Only thing I ask is that you add
some comment at eac
Gianluca Guida, le Sun 08 Jan 2006 18:40:45 +0100, a écrit :
> On 1/8/06, Samuel Thibault <[EMAIL PROTECTED]> wrote:
> > I was not sure about this indeed. The caller here is actually all
> > drivers that call io_port_create()...
>
> What drivers and where?
./i386/i386at/kd.c: io_port_create(
On 1/8/06, Samuel Thibault <[EMAIL PROTECTED]> wrote:
> I was not sure about this indeed. The caller here is actually all
> drivers that call io_port_create()...
What drivers and where?
Can you be more precise about it? The more I look at the patch the
less I understand what it is for.
Thanks,
Gianluca Guida, le Sun 08 Jan 2006 18:21:09 +0100, a écrit :
> I am not actually happy with this patch, since it will break for
> example stomach, and since I guess it's trying to fix an error on the
> callers (that should give the proper parameter) by modifying the
> called function.
I was not su
On 1/8/06, Samuel Thibault <[EMAIL PROTECTED]> wrote:
> Alfred M. Szmidt, le Sun 08 Jan 2006 17:57:27 +0100, a écrit :
> > Looks ok. Why the ifdef i386 though?
Because this patch assumes the i386 device emulation that Mach's i386
subsection uses. That is actually architecture independent, and for
Alfred M. Szmidt, le Sun 08 Jan 2006 17:57:27 +0100, a écrit :
> Looks ok. Why the ifdef i386 though?
Cf all ifdef i386 along device/ds_routines.c for instance. I don't know
the deep reason for all these defines, it's another issue anyway.
Regards,
Samuel
_
Looks ok. Why the ifdef i386 though?
2006-01-02 Samuel Thibault <[EMAIL PROTECTED]>
* iopb.c (i386_io_port_add): Get the device parameter properly.
(i386_io_port_remove): Likewise.
diff -urp gnumach-mine-2-default_noio/i386/i386/iopb.c
gnumach-mine-3-device_port_fix/i386/i386
