Re: io_select EPIPE error case? [Was: [PATCH] Prepare pflocal/io.c for a revised hurdselect.c: Pipe case (for review)]

2012-11-26 Thread Richard Braun
On Mon, Nov 26, 2012 at 02:38:44PM +0100, Samuel Thibault wrote: > Richard Braun, le Mon 26 Nov 2012 14:37:23 +0100, a écrit : > > Right. What about the SELECT_URG/POLLPRI case ? This one looks quite > > obscur. > > It is. IIRC for TCP/IP it's used for out-of-band data. I don't think we > have an

Re: io_select EPIPE error case? [Was: [PATCH] Prepare pflocal/io.c for a revised hurdselect.c: Pipe case (for review)]

2012-11-26 Thread Samuel Thibault
Richard Braun, le Mon 26 Nov 2012 14:37:23 +0100, a écrit : > On Mon, Nov 26, 2012 at 02:34:04PM +0100, Samuel Thibault wrote: > > In the read case, the end of file will be detected by a zero-read, not > > an EPIPE. > > Right. What about the SELECT_URG/POLLPRI case ? This one looks quite > obscur.

Re: io_select EPIPE error case? [Was: [PATCH] Prepare pflocal/io.c for a revised hurdselect.c: Pipe case (for review)]

2012-11-26 Thread Richard Braun
On Mon, Nov 26, 2012 at 02:34:04PM +0100, Samuel Thibault wrote: > In the read case, the end of file will be detected by a zero-read, not > an EPIPE. Right. What about the SELECT_URG/POLLPRI case ? This one looks quite obscur. -- Richard Braun

Re: io_select EPIPE error case? [Was: [PATCH] Prepare pflocal/io.c for a revised hurdselect.c: Pipe case (for review)]

2012-11-26 Thread Samuel Thibault
Richard Braun, le Mon 26 Nov 2012 14:30:40 +0100, a écrit : > On Fri, Nov 23, 2012 at 01:55:19AM +0100, Samuel Thibault wrote: > > About the behavior change, I'd tend to agree, but I'd rather get others' > > opinion too. > > > > I guess what you actually want to fix is the error case on poll()? >

Re: io_select EPIPE error case? [Was: [PATCH] Prepare pflocal/io.c for a revised hurdselect.c: Pipe case (for review)]

2012-11-26 Thread Richard Braun
On Fri, Nov 23, 2012 at 01:55:19AM +0100, Samuel Thibault wrote: > About the behavior change, I'd tend to agree, but I'd rather get others' > opinion too. > > I guess what you actually want to fix is the error case on poll()? > (actually here the only error that can happen is EPIPE) > (that would

Re: io_select EPIPE error case? [Was: [PATCH] Prepare pflocal/io.c for a revised hurdselect.c: Pipe case (for review)]

2012-11-23 Thread Samuel Thibault
Svante Signell, le Fri 23 Nov 2012 08:00:26 +0100, a écrit : > I'm not yet fluent in > the terminology and how to write things properly the GNU Hurd way. Well, it's not about any "Hurd way", but simply collaborative project :) > Yes, no errors in the select case only for poll (according to POSIX)

Re: io_select EPIPE error case? [Was: [PATCH] Prepare pflocal/io.c for a revised hurdselect.c: Pipe case (for review)]

2012-11-22 Thread Svante Signell
On Fri, 2012-11-23 at 01:55 +0100, Samuel Thibault wrote: > Svante Signell, le Thu 22 Nov 2012 20:29:32 +0100, a écrit : > > @@ -231,15 +232,21 @@ S_io_select (struct sock_user *user, > >if (valid & SELECT_READ) > > { > > pipe_acquire_reader (read_pipe); > > - if (pipe_wait_re

io_select EPIPE error case? [Was: [PATCH] Prepare pflocal/io.c for a revised hurdselect.c: Pipe case (for review)]

2012-11-22 Thread Samuel Thibault
Svante Signell, le Thu 22 Nov 2012 20:29:32 +0100, a écrit : > @@ -231,15 +232,21 @@ S_io_select (struct sock_user *user, >if (valid & SELECT_READ) > { > pipe_acquire_reader (read_pipe); > - if (pipe_wait_readable (read_pipe, 1, 1) != EWOULDBLOCK) > + err = pipe_wa