Re: socket_send & socket_recv fail when sending non-socket ports

2010-11-07 Thread Thomas Schwinge
Hello! On Sun, Sep 19, 2010 at 01:54:23PM +0200, Manuel Menal wrote: > As a sidenote, this also makes us able to use sshd with > UsePrivilegeSeparation set to yes (which used to fail because it sends > the tty fd through sendmsg() with SCM_RIGHTS, which fails silently > without your patch). Confi

Re: socket_send & socket_recv fail when sending non-socket ports

2010-09-19 Thread Thomas Bushnell, BSG
Good catch. As Roland notes the old code here has the restart race bug. Also it was probably a leak because I think nothing here wa counting he new make send instance the way we normally wrap all uses of make send. On Sunday, September 19, 2010, Manuel Menal wrote: > On 27/07/2010 17:39, Emilio P

Re: socket_send & socket_recv fail when sending non-socket ports

2010-09-19 Thread Samuel Thibault
Manuel Menal, le Sun 19 Sep 2010 13:54:23 +0200, a écrit : > Here is a very simple fix for this bug: Applied. Samuel

Re: socket_send & socket_recv fail when sending non-socket ports

2010-09-19 Thread Manuel Menal
On 27/07/2010 17:39, Emilio Pozuelo Monfort wrote: > Hi, Hello, > While adding support for SCM_RIGHTS to glibc, I've created a testcase that > sends > and receives some ports on the result of a socketpair() call. The ports sent > were initially the two ports result of another socketpair() call,

Re: socket_send & socket_recv fail when sending non-socket ports

2010-07-28 Thread Roland McGrath
> On 28/07/10 00:53, Roland McGrath wrote: > > I don't know off hand why you're getting that failure mode. But in general > > you can't use MACH_MSG_TYPE_MOVE_SEND in Hurd RPC arguments (only for > > replies) because of the interrupt retry issue. That could be related > > to this failure though I

Re: socket_send & socket_recv fail when sending non-socket ports

2010-07-28 Thread Emilio Pozuelo Monfort
On 28/07/10 00:53, Roland McGrath wrote: > I don't know off hand why you're getting that failure mode. But in general > you can't use MACH_MSG_TYPE_MOVE_SEND in Hurd RPC arguments (only for > replies) because of the interrupt retry issue. That could be related > to this failure though I can't rea

Re: socket_send & socket_recv fail when sending non-socket ports

2010-07-27 Thread Roland McGrath
I don't know off hand why you're getting that failure mode. But in general you can't use MACH_MSG_TYPE_MOVE_SEND in Hurd RPC arguments (only for replies) because of the interrupt retry issue. That could be related to this failure though I can't really see how at the moment. Thanks, Roland

socket_send & socket_recv fail when sending non-socket ports

2010-07-27 Thread Emilio Pozuelo Monfort
Hi, While adding support for SCM_RIGHTS to glibc, I've created a testcase that sends and receives some ports on the result of a socketpair() call. The ports sent were initially the two ports result of another socketpair() call, and it was working fine, but then I tried with the result of a couple