Simon Josefsson writes:
> True. The savannah issue tracker? I'm using it, but I find the
> availability issues with savannah together with the really dated UX and
> technical design (is it possible to export savannah issues in any
> standardized format?) is making me consider alternatives.
>
>
Simon Josefsson writes:
> I think that if I hadn't used the codeberg web interface to approve the
> merge request, but instead pulled it locally and merged it myself, I
> could have used some git command and parameter that would result in the
> git commit identity would point to me instead. We c
Bruno Haible writes:
> Today the inetutils CI failed:
>
> 1 out of 6 hunks FAILED -- saving rejects to file
> /tmp/glpycudi5nxa/top/README-release.rej
> /home/runner/work/ci-check/ci-check/gnulib/gnulib-tool.py: *** patch file
> top/README-release didn't apply cleanly
> /home/runner/work/ci-che
Simon Josefsson writes:
> Btw, is there any more common OS than AIX which lack asprintf? It would
> be nice to have CI/CD, I dislike portability fixes which we cannot
> regression test. Windows? I suspect very little of InetUtils builds on
> Windows, but GitLab have Windows runners available,
Hi Simon,
Simon Josefsson via Bug reports for the GNU Internet utilities
writes:
> - Push a topic branch to my personal inetutils fork:
> https://codeberg.org/jas/inetutils
> - Push the topic branch to a GitLab project to run CI/CD:
> https://gitlab.com/gsasl/inetutils/-/pipelines
> it use
"Alfred M. Szmidt" writes:
> I've stepped down as maintainer for inetutils (essentially for the
> issues that have been a plauge here, and neither RMS nor the FSF have
> tried to addressed, to the point where other tasks have been entierly
> ignored), but if a provider, service, whatever you wish
Simon Josefsson via Bug reports for the GNU Internet utilities
writes:
> "Alfred M. Szmidt" writes:
>
>> What would people say about moving things over to codeberg? Savannah
>> is entierly unusable, and the FSF admins are not interesting in doing
>> anything.
The downtime was getting quite anno
Hi Simon,
Thanks for checking the patch. And thanks again Bruno for the fix.
Simon Josefsson writes:
> I dislike merge commits, and I don't know how codeberg will behave if I
> merge this in the web browser, and I also don't know if PGP signed git
> commits will behave on codeberg (which I use)
Simon Josefsson writes:
> Hmm, you make a good case for this, and I'm changing my position to
> neutral. What I think is more important is to align ping and ping6 more
> to reduce code duplication. If that happens to lead to using normal
> getaddrinfo() selection defaults for IPv4 vs IPv6, that
"Alfred M. Szmidt" writes:
> ping is for IPv4, ping5 is for IPv6. There is nothing "legacy" about
> IPv4. Use the right command for the right task.
I generally agree. Having both a ping and ping6 commands seems fairly
common.
I wouldn't mind having 'ping' support both IPv4 and IPv6 with argum
Hi Bruno,
Bruno Haible via Bug reports for the GNU Internet utilities
writes:
> gcc 15 reports this warning from -Wanalyzer-use-after-free:
> ../../talkd/table.c:65:30: warning: use after 'free' of 'ptr' [CWE-416]
>
> gcc is right here: Accessing ptr->next after calling free (ptr)
> (inside tabl
Simon Josefsson writes:
> I recall looking into this some time ago. I found that some of the uses
> of this function are for IPv4-only code paths. And then I found it hard
> to argue for change.
>
> Is there anything other wrong with inet_ntoa? If there is no other
> fundamental problem, I thi
Hi Simon,
Simon Josefsson writes:
> Thank you for reverting, and I hope it won't deter you from proposing
> and suggesting other fixes for InetUtils! I think it is fine to install
> things, we can always revert stuff. How to approach man pages seems to
> be an endless source of considerations.
Simon Josefsson writes:
> Thanks for the finding! Is that building from tarball or from git?
It is the same as the other CI written by Bruno Haible, so from git.
> But please, let's not add more copies of external tools to version
> control sources. That is a software supply-chain nightmare.
48d Mon Sep 17 00:00:00 2001
From: Collin Funk
Date: Fri, 18 Apr 2025 20:14:24 -0700
Subject: [PATCH] maint: Distribute help2man script.
* .x-update-copyright: New file.
* bootstrap.conf (buildreq): Remove help2man.
* configure.ac: Fallback to distributed help2man if it is not installed.
*
lin
>From 8e88c32cfebffaef103d4fedf10358cde4ffb9fb Mon Sep 17 00:00:00 2001
From: Collin Funk
Date: Tue, 25 Feb 2025 22:14:00 -0800
Subject: [PATCH] maint: Fix link errors on Solaris 11 OmniOS.
* bootstrap.conf (gnulib_modules): Add hostent and socket.
* ftp/Makefile.am (ftp_LDADD): New var
Hi Erik,
Erik Auerswald writes:
> On Thu, Sep 05, 2024 at 12:48:03PM +0200, Simon Josefsson wrote:
>> Collin Funk writes:
>>
>> > Can someone give it a look over before pushing?
>>
>> Could you see if it is feasible to write a self-test that check if t
ing? I'll write a patch for
talkd later.
Collin
>From cbc4d8289f4c5c034715302deb3be7e431cb7fb8 Mon Sep 17 00:00:00 2001
From: Collin Funk
Date: Wed, 4 Sep 2024 19:30:55 -0700
Subject: [PATCH] syslogd: Adjust to readutmp changes in Gnulib.
* src/syslogd.c (wallmsg): Let readutmp handle p
Hi Bruno,
Bruno Haible writes:
> (It doesn't take your tarball. It build off the git repository. But that
> should be sufficiently close.)
>
> Here are my findings so far:
Thanks! Also, before a release I want to fix these warnings that I
noticed.
process.c:224:50: warning: argument to 'sizeof
I've pushed this patch using Gnulib's stat-time instead of doing the
check for struct stat members ourselves.
I tested 'ls' changes against Coreutils and 'rcp' changes with a NetBSD
VM.
Collin
>From 4b73be3eb2d764c2b2c7ca7afb19e0f88d24f45a Mon Sep 17 00:00:00
Hi Erik,
Erik Auerswald writes:
>> > Thanks! Should this be added to NEWS?
>>
>> Thanks Collin, and yes please :)
>
> How about the following?
Looks good to me.
You might want to mention that it could cause auto-of-bounds memory
access. I wasn't able to cause the SIGSEGV you saw on Fedora 40
Erik Auerswald writes:
> https://github.com/openbsd/src/blob/master/usr.bin/telnet/commands.c
>
> The 'Sendlist[]' there also has no 'help' string for 'dont' and similar
> commands. The 'send_help()" function also omits commands without a
> 'help' string.
>
> This code also seems to have the sam
Hi Erik,
Erik Auerswald writes:
> I plan to push the attached patches in about a week unless there is
> an objection.
Thanks! I didn't even notice there were telnet tests. These are
definitely nice additions.
Collin
Hi Simon,
Simon Josefsson writes:
> I don't know the history -- but (sounding like a broken record by now)
> did anyone check *BSD telnet behaviour? I'm not a fan of intentionally
> not documentating supported commands, so +1 on any patch to document
> this from me, regardless of what *BSD teln
g strtol and friends
annoying. I'd prefer using xstrtoimax, since it deals with all the
conditions and platform discrepancies. But feel free to change to a
standard function if you'd like.
Collin
>From a6d9848a32fafa763548e54b44cb094abdac915d Mon Sep 17 00:00:00 2001
From: Collin Funk
Date
Hi Simon,
Simon Josefsson writes:
> Did you review how *BSD's tnftpd looks here? Then often applied fixes
> many years ago. If they solved this problem already, it is nice to
> solve it in the same way, and if their solution is sub-optimal consider
> submitting a fix to them to sync more code.
to:
+ snprintf (portstr, sizeof portstr, "%u", port);
Patch attached. Feel free to make changes if you see fit.
Collin
[1] https://lists.gnu.org/archive/html/bug-gnulib/2011-02/msg00119.html
>From e29e76b37b31eef27c5d53cc87306e7b80376762 Mon Sep 17 00:00:00 2001
From: Collin Funk
Date: Wed,
it won't overflow.
To make this more clear we change 'port' to in_port_t. POSIX requires
this to be equivalent to uint16_t so GCC can tell the buffer won't
overflow. Then also reduce the buffer size from 10 to 6 using Gnulib's
INT_STRLEN_BOUND. Makes things more clear IMO.
C
GCC throws -Wanalyzer-va-list-leak here since the function can return
before va_end is called. I checked and the NetBSD fixed this along time
ago. Not sure if it can cause any harm but bad style IMO.
-- 8< --
* src/rcp.c (run_err): Move va_start call after the early return.
---
src/rcp.c | 5 +++
Simon Josefsson writes:
> Since the CI/CD file had '|| true' I suppose it means it is a known
> problem for ArchLinux. Does anyone understand why the error above
> happens? ArchLinux shouldn't be that different, and tgetent should come
> via ncurses which is detected fine... anyway, since it i
Hi Erik,
Erik Auerswald writes:
> I have added macOS to the operating systems that do not need to skip
> the ping-localhost.sh test without root privileges, and plan to push
> the attached patch in a few days.
Looks good upon a quick glance from me. Sorry I didn't see the v2 patch.
Started a ne
Hi Erik,
Erik Auerswald writes:
> as a first attempt at testing "ping" without requiring root, the following
> patch works for me. Do we need to add a check if "cut" is available?
> Since the "id -G" is only used on systems with the kernel Linux, it may
> be OK without a check, or should we add
Erik Auerswald writes:
> This can be fixed by deleting the clone, creating a new one, and executing
> the bootstrap script. But is there a nicer way for updating an exiting
> git clone to also include the new gnulib module(s)?
BTW, here is how I deal with Gnulib stuff though. Since I am a commi
Hi Erik,
Erik Auerswald writes:
> the recent time function changes added another gnulib module. A simple
> "git pull" in a clone of the inetutils repository does not update the
> gnulib modules, resulting in a build failure:
>
> traceroute.c:52:10: fatal error: timespec.h: No such file or d
Hi Erik,
Erik Auerswald writes:
> Have you looked if you could add a (regression) test for this?
>
> Hm, the ping tests are skipped for me because they need to be run as
> root.
Not specifically for this case. Though I would like to improve overall
test suite so that it is easier to add tests.
before calling select ().
I've pushed the attached patch fixing it.
Collin
>From 183f8d940ffcf5a308aa96c731c1a80a580aa653 Mon Sep 17 00:00:00 2001
From: Collin Funk
Date: Sat, 29 Jun 2024 17:48:35 -0700
Subject: [PATCH] ping, ping6: Fix mistake in previous change.
* ping/ping.c (ping_r
Hi Simon,
Simon Josefsson writes:
> Thanks - I'm neutral on these patches, as I don't really know what a
> positive or negative test for them would be. However, speaking on
> inet_ntoa and different code paths reminded me: a good todo work item
> would be to merge the ping4 and ping6 tools. I
* README: Fix spelling of similarly.
* doc/inetutils.texi (ifconfig invocation): Fox spelling of or.
(logger invocation): Fix spelling of influential.
(Ftp commands): Fix spelling of intended.
(Configuration file): Fix spelling of limited.
(telnetd invocation): Fix spelling of construct.
(tftpd inv
I've committed this patch. Similar to the two I sent yesterday.
Collin
>From 572af87d9ed5c8cdccee006bac79f958b211a880 Mon Sep 17 00:00:00 2001
From: Collin Funk
Date: Thu, 27 Jun 2024 23:10:12 -0700
Subject: [PATCH] ftp: Modernize time functions.
* ftp/Makefile.am (LDADD): Add $(CLOCK_
Collin Funk writes:
> I've applied this patch using modern gnulib timespec functions instead
> of rolling our own versions (atleast for traceroute).
Likewise for ping & ping6.
Collin
>From b694830a330906e63a036513c7a6cdde997d19e4 Mon Sep 17 00:00:00 2001
From: Collin Funk
t and improve the
getaddrinfo gnulib module.
Collin
[1] https://lists.gnu.org/archive/html/bug-gnulib/2024-06/msg00268.html
>From 550ad69881e4b012bb2a9d2848f998319ebc445d Mon Sep 17 00:00:00 2001
From: Collin Funk
Date: Wed, 26 Jun 2024 16:23:59 -0700
Subject: [PATCH] traceroute: Modernize time f
b.git/tree/lib/timespec.hFrom 449c9ad956b4d03953d6b2b97496cc06fabb10ce Mon Sep 17 00:00:00 2001
From: Collin Funk
Date: Sat, 25 May 2024 23:55:01 -0700
Subject: [PATCH] Use gnulib select module.
* ftp/Makefile.am (LDADD): Add $(SELECT_LIB).
* ping/Makefile.am (LDADD): Likewise.
* src/Makefile.a
Hi Simon,
On 5/12/24 3:56 AM, Simon Josefsson via Bug reports for the GNU Internet
utilities wrote:
> I have committed the attached patches giving us reproducible tarballs.
>
> The particular logic to verify this continously is in the
> 000-reproducibility pipeline job, code here:
Cool!
A bit
On 5/12/24 12:23 AM, Simon Josefsson wrote:
>> With an exception for some Kerberos 4 stuff, which I cannot test. I
>> assume the plan is still to remove that as mentioned in TODO?
>
> Let's keep that question open for a while more...
Sounds good.
>> In any case, I could test telnet commands incl
Hi Simon,
On 5/12/24 12:20 AM, Simon Josefsson wrote:
> I enabled c23 build for gcc-14.1 now, and it passes:
>
> https://gitlab.com/gsasl/inetutils/-/jobs/6830704753
Nice, Thanks!
> I see we weren't using the warnings module from gnulib at all. I recall
> we were worried that if we are going t
1)
DES_OFB64 (2)
CollinFrom 380bbda03648b8f2f2b1590547d4afa4b40152af Mon Sep 17 00:00:00 2001
From: Collin Funk
Date: Fri, 10 May 2024 20:51:53 -0700
Subject: [PATCH] telnet: Make function declarations C23 compatible.
* NEWS: Mention C23 support.
* telnet/commands.c (Sendlist, Togglelist, Set
On 5/10/24 6:52 AM, Simon Josefsson wrote:>> $ ./configure CC="gcc-14.1"
CFLAGS="-std=c23 -Wstrict-prototypes" --enable-authentication
--enable-encryption --with-krb5
>
> Ah, you answered my request from the earlier email already :-)
:)
> Looks good, and yes let's improve the compiler warning
:777:9: error: too many arguments to function 'kp->getcrypt'
777 | ep = (*kp->getcrypt) (*kp->modep);
|~^~
CollinFrom 25816697e6c79ae0e009b4762d8f325dfad6e99e Mon Sep 17 00:00:00 2001
From: Collin Funk
Date: Thu, 9 May 2024 21:10:57 -0700
Subject: [PATCH] libtelnet: Make en
d a NEWS entry saying Inetutils can be compiled in
C23 mode for whenever there is a release.
CollinFrom dd4c077b3407b7fc0bd88313ee54c7c9200e2498 Mon Sep 17 00:00:00 2001
From: Collin Funk
Date: Thu, 9 May 2024 18:51:54 -0700
Subject: [PATCH] maint: Fix most instances of '-Wstrict-prototype
On 5/9/24 12:32 AM, Simon Josefsson wrote:
> These looks good to me, thank you! Please push them.
Done.
> Btw, if you are used to working on gitlab -- to get feedback from CI/CD
> testing directly -- you can push test branches to your personal fork of
> https://gitlab.com/gsasl/inetutils and add
check' this time...
[1]
https://github.com/NetBSD/src/commit/797d779cf1e0fea886f40c274a5e87d72e1d4b77
[2]
https://github.com/NetBSD/src/commit/b87e54c002f7345d281ff7ab0c325d0336a8a8a2
CollinFrom e5a9384c928f853eefba28435d63cb8337d30b13 Mon Sep 17 00:00:00 2001
From: Collin Funk
Date: We
Hi Simon and Gulliem,
On 5/8/24 1:06 PM, Simon Josefsson via Bug reports for the GNU Internet
utilities wrote:
> Hi Guillem. I added the bootstrap files to the tarball now.
>
> I'm not convinced that this is a good idea, so let's consider this an
> experiment. First, this is not recommended by
On 5/7/24 12:25 AM, Simon Josefsson wrote:
> Yes please indent code and write a NEWS entry about fixing some ASAN
> alarms.
I've pushed the attached patch. Now 'make syntax-check' should be
happy.
CollinFrom cd3a8b26fba59ef62905dbfa19bf07be0a61e993 Mon Sep 17 00:00:00 2
On 5/6/24 6:03 PM, Collin Funk wrote:
> So I am confident it is a bug. I've applied the attached patch which
> seems to fix the issue. This is based on a quick glance of the code so
> I would appreciate others looking it over. Thanks!
Oops, I forgot to run 'make indent',
127549== ERROR SUMMARY: 127 errors from 31 contexts (suppressed: 0 from 0)
So I am confident it is a bug. I've applied the attached patch which
seems to fix the issue. This is based on a quick glance of the code so
I would appreciate others looking it over. Thanks!
CollinFrom 45d5900c9ee8d03
On 5/6/24 5:26 AM, Simon Josefsson wrote:
> Looks good to me, feel free to push.
Done, with some slight changes to the fist patch now that some checks
are in Gnulib.
> I do mostly agree, however there is another concern: frivolious changes
> like this makes it harder to align code with BSD implem
other example is 'index' vs 'strchr' and 'rindex' vs 'strrchr'.
That stuff probably hinders portability more than it helps as the
years go on. :)
CollinFrom 17afd1df789db615f9a6867688a54e18b8e2f316 Mon Sep 17 00:00:00 2001
From: Collin Funk
Date: Sun, 5 May 2024
On 5/4/24 2:03 PM, Collin Funk wrote:
> I've sent a 'request for inclusion' to the Inetutils group on
> Savannah.
I got added, so I just pushed those 2 patches + the one I sent
previously removing unessecary 'extern char **environ' decls.
Collin
On 5/4/24 10:41 AM, Simon Josefsson wrote:
>> But they forgot to do u_int. Patch 0001 adds one for u_int and patch
>> 0002 removes them.
>
> Thank you -- looks good to me, feel free to push.
Thanks!
I've sent a 'request for inclusion' to the Inetutils group on
Savannah.
I assume committer rules
ine these, so it would work fine in 99% of
places.
CollinFrom 90f512bb93d9aa5b9b1c1c38991c0b53283db45d Mon Sep 17 00:00:00 2001
From: Collin Funk
Date: Sat, 4 May 2024 01:34:39 -0700
Subject: [PATCH 1/2] cfg.mk: Add checks for 'u_int'.
* cfg.mk (sc_unsigned_int): New rule.
(sc_unsigned_s
On 5/2/24 11:46 PM, Simon Josefsson wrote:
> Nice catch. It doesn't make sense for maint.mk's indentation to be
> influenced by ~/.indent.pro -- the style has to be a per-project
> setting. I pushed the patch below.
Thanks. Inetutils now runs 'make syntax-check' and passes for me.
Collin
Hi Simon,
On 5/2/24 11:25 AM, Simon Josefsson via Bug reports for the GNU Internet
utilities wrote:
>> Sadly, I cannot do this, at least not easily. After installing GNU
>> indent, "make syntax-check" complains about many files:
>>
>> $ indent --version
>> GNU indent 2.2.12
> You need 2.
Hi Simon,
On 5/2/24 10:55 AM, Simon Josefsson wrote:
>> Specifically, are these items still true?
>
> I think you should pretty much assume very little is up to date or
> correct in inetutils.
Haha, good to know. :)
>>> generally use gnulib for portability more than we use today:
>>> - getaddr
x27; module emulates C23, there is no need
to include stdbool.h. If the compiler doesn't support bool stuff as a
keyword the header is included in config.h.
[1] https://www.gnu.org/software/gnulib/manual/html_node/environ.html
CollinFrom 079eb20eb805a1411e082364762eb7973c402098 Mon Sep 17 00:00:00 20
Hi Simon,
On 4/24/24 6:22 AM, Simon Josefsson wrote:
> I think this was fairly common before. If there had been a 'make
> syntax-check' rule for this, we would have caught it! I have removed
> use of HAVE_CONFIG_H and fixed telnetd.h in Inetutils now, thanks.
Thanks! It showed up from some othe
On 3/22/24 2:18 PM, Simon Josefsson wrote:
> Upgrading inetutils to use gnulib-tool.py would be nice. As a start, I
> bumped the gnulib submodule.
Bruno and I are still working on it with a test suite. We want the
file output and stdout output to be the same before we recommend using
it. Then we
Hi Simon,
On 3/22/24 12:51 PM, Simon Josefsson wrote:
> Hi. Nice catch, thank you. I have added a CI/CD job to catch -lsystemd
> regressions in the future:
Nice, looks good to me.
> Thank you for details -- I think this is somewhat subjective, but I do
> prefer to augment as specific LDADD's a
3b92a5fa78a3d6de12f88d43e89270 Mon Sep 17 00:00:00 2001
From: Collin Funk
Date: Thu, 21 Mar 2024 21:55:47 -0700
Subject: [PATCH] maint: Allow gnulib's readutmp module to use systemd.
* src/Makefile.am (LDADD): Link to $(READUTMP_LIB).
* talkd/Makefile.am (LDADD): Likewise.
* tests/Makefile
00:00 2001
From: Collin Funk
Date: Sun, 7 Jan 2024 12:09:43 -0800
Subject: [PATCH] Fixed for a few compiler warnings.
Fixed shadowed local variables in ftp/ftpd.c, ifconfig/changif.c,
and ifconfig/options.c.
Converted size_t to idx_t to match function declarations in
src/syslogd.c and talkd/proc
69 matches
Mail list logo
