Re: Cppcheck reports patch for 2546

2012-05-20 Thread Julien Nabet
On 19/05/2012 00:36, Carl Sorensen wrote: Thanks for the file, Julien. I have split the warnings into various issues. See issues 2545, 2546, and 2548 through 2554 on the issue tracker. http://code.google.com/p/lilypond/issues/detail?id=2545colspec=ID%20Type%2

Re: Cppcheck reports patch for 2546

2012-05-20 Thread Graham Percival
On Sat, May 19, 2012 at 08:30:50AM +0200, Julien Nabet wrote: Since I don't have a Google account to sign in to http://codereview.appspot.com/, I attached the patch for 2546. Don't hesitate to tell me if it's ok or not. (I attached a link to why prefix is better). Unfortunately we do not

Re: Cppcheck reports patch for 2546

2012-05-20 Thread Carl Sorensen
On May 20, 2012, at 1:16 PM, Graham Percival gra...@percival-music.ca wrote: On Sat, May 19, 2012 at 08:30:50AM +0200, Julien Nabet wrote: Since I don't have a Google account to sign in to http://codereview.appspot.com/, I attached the patch for 2546. Don't hesitate to tell me if it's ok or