Re: Issue 1288 in lilypond: running convert-ly on git

Updates: Summary: running convert-ly on git Status: Started Owner: percival.music.ca Comment #1 on issue 1288 by percival.music.ca: running convert-ly on git http://code.google.com/p/lilypond/issues/detail?id=1288 In more general terms, we need to figure out when to run c

Re: Issue 1288 in lilypond: running convert-ly on git

Updates: Labels: Patch Comment #2 on issue 1288 by percival.music.ca: running convert-ly on git http://code.google.com/p/lilypond/issues/detail?id=1288 The first step is to get this patch approved (or modified further): http://codereview.appspot.com/2401042/ ___

Re: Issue 1288 in lilypond: running convert-ly on git

Comment #4 on issue 1288 by percival.music.ca: running convert-ly on git http://code.google.com/p/lilypond/issues/detail?id=1288 Previous patch accepted and pushed. I'm preparing another patch, but it does not include: Documentation/snippets/new/changing-the-time-signature-without-affectin

Re: Issue 1288 in lilypond: running convert-ly on git

Comment #5 on issue 1288 by Carl.D.Sorensen: running convert-ly on git http://code.google.com/p/lilypond/issues/detail?id=1288 The woodwind files are correct. Probably the problem is that the version was not updated previously when it should have been.

Re: Issue 1288 in lilypond: running convert-ly on git

Comment #6 on issue 1288 by percival.music.ca: running convert-ly on git http://code.google.com/p/lilypond/issues/detail?id=1288 Thanks for checking, Carl. I expected that the version numbers just hadn't been updated (since we have the same problem in the NR), but I'm glad that you checked.

Re: Issue 1288 in lilypond: running convert-ly on git

Comment #7 on issue 1288 by percival.music.ca: running convert-ly on git http://code.google.com/p/lilypond/issues/detail?id=1288 Whoops, I just noticed that snippets/new/changing-the-time-signature-without-affecting-the-beaming.ly is a "this snippet is deprecated" one. Obviously that shou

Re: Issue 1288 in lilypond: running convert-ly on git

Updates: Labels: Patch Comment #8 on issue 1288 by percival.music.ca: running convert-ly on git http://code.google.com/p/lilypond/issues/detail?id=1288 Next patch requiring review: http://codereview.appspot.com/2642041/ ___ bug-lilypond maili

Re: Issue 1288 in lilypond: running convert-ly on git

Comment #10 on issue 1288 by percival.music.ca: running convert-ly on git http://code.google.com/p/lilypond/issues/detail?id=1288 Could somebody check ly/performer-init.ly ? convert-ly wants to remove: @@ -219,8 +219,4 @@ \name RhythmicStaff } -\context { - \type "Performer_group" - \

Re: Issue 1288 in lilypond: running convert-ly on git

Comment #9 on issue 1288 by percival.music.ca: running convert-ly on git http://code.google.com/p/lilypond/issues/detail?id=1288 Could somebody check if input/regression/dynamics-text-spanner-postfix.ly is correctly written for \version "2.13.36" ? convert-ly wants to replace all the \cresc w

Re: Issue 1288 in lilypond: running convert-ly on git

Comment #11 on issue 1288 by percival.music.ca: running convert-ly on git http://code.google.com/p/lilypond/issues/detail?id=1288 Latest patch: http://codereview.appspot.com/2687043/ In summary, there's the policy update patch (above), comments 9 and 10, and issue 1358. ___

Re: Issue 1288 in lilypond: running convert-ly on git

Comment #12 on issue 1288 by v.villenave: running convert-ly on git http://code.google.com/p/lilypond/issues/detail?id=1288 As far as I can see, dynamics-text-spanner-postfix.ly is OK. However, I think that removing the Performer_group is something we want to do. I'm not familiar enough with

Re: Issue 1288 in lilypond: running convert-ly on git

Comment #13 on issue 1288 by v.villenave: running convert-ly on git http://code.google.com/p/lilypond/issues/detail?id=1288 I meant "I *don't* think that removing the performer_group is something we want to do", obviously. ___ bug-lilypond mailing

Re: Issue 1288 in lilypond: running convert-ly on git

Comment #14 on issue 1288 by percival.music.ca: running convert-ly on git http://code.google.com/p/lilypond/issues/detail?id=1288 If we don't want to remove that performer_group, then this sounds like a bug in convert-ly. Could you figure out which version conversion rule does it, and/or ju

Re: Issue 1288 in lilypond: running convert-ly on git

Comment #15 on issue 1288 by n.puttock: running convert-ly on git http://code.google.com/p/lilypond/issues/detail?id=1288 It's the greedy rule I added to remove explicit Dynamics blocks (e.g., from the old centred dynamics template). See 9633a39ac6e996e16f13e2076c565a6ef88e6eca. __

Re: Issue 1288 in lilypond: running convert-ly on git

Comment #16 on issue 1288 by v.villenave: running convert-ly on git http://code.google.com/p/lilypond/issues/detail?id=1288 Oh, I see. Perhaps you should have added "Engraver_group" in your regexp. I'll have a look. ___ bug-lilypond mailing list b

Re: Issue 1288 in lilypond: running convert-ly on git

Updates: Labels: -Patch Comment #17 on issue 1288 by percival.music.ca: running convert-ly on git http://code.google.com/p/lilypond/issues/detail?id=1288 The convert-ly Dynamics thing is now 1365. I have manually updated the version of ly/performer-init.ly. The policy has been updat

Re: Issue 1288 in lilypond: running convert-ly on git

Updates: Status: Fixed Labels: fixed_2_13_38 Comment #18 on issue 1288 by percival.music.ca: running convert-ly on git http://code.google.com/p/lilypond/issues/detail?id=1288 That file compiles cleanly (and as expected) in .36, so I've bumped the version. That completes this t

Re: Issue 1288 in lilypond: running convert-ly on git

Updates: Status: Verified Comment #19 on issue 1288 by percival.music.ca: running convert-ly on git http://code.google.com/p/lilypond/issues/detail?id=1288 Looks fine now. ___ bug-lilypond mailing list bug-lilypond@gnu.org http://lists.gnu.or