Updates:
Status: Verified
Labels: -Patch-push Fixed_2_15_27
Comment #22 on issue 2177 by julien.r...@gmail.com: Patch: Reverts public
interface for simple spacer.
http://code.google.com/p/lilypond/issues/detail?id=2177
Thanks for clarifying the patchy stuff.
As to this
Comment #19 on issue 2177 by julien.r...@gmail.com: Patch: Reverts public
interface for simple spacer.
http://code.google.com/p/lilypond/issues/detail?id=2177
Patchy had some problem, if I understood the discussion, because make
clean did not remove the .dep files. If that is the case
Comment #20 on issue 2177 by mts...@gmail.com: Patch: Reverts public
interface for simple spacer.
http://code.google.com/p/lilypond/issues/detail?id=2177
I fixed this in Patchy - he should be good to go on this front.
___
bug-lilypond mailing
Comment #21 on issue 2177 by gra...@percival-music.ca: Patch: Reverts
public interface for simple spacer.
http://code.google.com/p/lilypond/issues/detail?id=2177
it was a bit more subtle than that: AFAIK 'make clean' does work, but the
first fix I made was to run make clean *after* testing
Updates:
Labels: -Patch-countdown Patch-push
Comment #17 on issue 2177 by colinpkc...@gmail.com: Patch: Reverts public
interface for simple spacer.
http://code.google.com/p/lilypond/issues/detail?id=2177
Counted down to 20120117, please push.
Updates:
Status: Fixed
Comment #18 on issue 2177 by mts...@gmail.com: Patch: Reverts public
interface for simple spacer.
http://code.google.com/p/lilypond/issues/detail?id=2177
Pushed as 50e6c85c2f12b45e02159e344ebc543139204748.
___
Updates:
Labels: Patch-needs_work
Comment #10 on issue 2177 by lilypond...@gmail.com: Patch: Reverts public
interface for simple spacer.
http://code.google.com/p/lilypond/issues/detail?id=2177#c10
Patchy the autobot says: patch does not apply to current master
Updates:
Labels: Patch-new
Comment #11 on issue 2177 by mts...@gmail.com: Patch: Reverts public
interface for simple spacer.
http://code.google.com/p/lilypond/issues/detail?id=2177#c11
Reverts public interface for simple spacer.
http://codereview.appspot.com/5511044
Updates:
Labels: Patch-needs_work
Comment #12 on issue 2177 by lilypond...@gmail.com: Patch: Reverts public
interface for simple spacer.
http://code.google.com/p/lilypond/issues/detail?id=2177#c12
Patchy the autobot says: sorry, apparently make clean isn't enough to
handle the .dep
Comment #13 on issue 2177 by m...@apollinemike.com: Patch: Reverts public
interface for simple spacer.
http://code.google.com/p/lilypond/issues/detail?id=2177
Agreed - if you go into the appropriate build directory and wipe all .dep
and .o files, it should build ok.
Updates:
Labels: -Patch-needs_work Patch-new
Comment #14 on issue 2177 by gra...@percival-music.ca: Patch: Reverts
public interface for simple spacer.
http://code.google.com/p/lilypond/issues/detail?id=2177
(No comment was entered for this change.)
Updates:
Labels: Patch-review
Comment #15 on issue 2177 by lilypond...@gmail.com: Patch: Reverts public
interface for simple spacer.
http://code.google.com/p/lilypond/issues/detail?id=2177#c15
Patchy the autobot says: LGTM.
___
Comment #8 on issue 2177 by m...@apollinemike.com: Patch: Reverts public
interface for simple spacer.
http://code.google.com/p/lilypond/issues/detail?id=2177
Could you please check this patch again w/ the new patchy to see if it gets
over the column-description.hh hurdle?
Updates:
Labels: -Patch-needs_work Patch-new
Comment #9 on issue 2177 by gra...@percival-music.ca: Patch: Reverts public
interface for simple spacer.
http://code.google.com/p/lilypond/issues/detail?id=2177
err, ok. I guess this patch was waiting for 6 days just for somebody to
Comment #5 on issue 2177 by d...@gnu.org: Patch: Reverts public interface
for simple spacer.
http://code.google.com/p/lilypond/issues/detail?id=2177
The .dep files are created _along_ with the .o files. As a result, they
don't track changes in dependencies until the file has been
Comment #6 on issue 2177 by gra...@percival-music.ca: Patch: Reverts public
interface for simple spacer.
http://code.google.com/p/lilypond/issues/detail?id=2177
Patchy tries to process all Patch-new items in the same run:
apply patch
configure
make
make test-check
cp -r regtests/
Comment #7 on issue 2177 by d...@gnu.org: Patch: Reverts public interface
for simple spacer.
http://code.google.com/p/lilypond/issues/detail?id=2177
The manual page of git-clean is quite explicit and short.
un-apply patch is definitely totally insufficient for not having
interactions with
Updates:
Labels: Patch-needs_work
Comment #1 on issue 2177 by lilypond...@gmail.com: Patch: Reverts public
interface for simple spacer.
http://code.google.com/p/lilypond/issues/detail?id=2177#c1
Patchy the autobot says: no rule to make column-description.hh needed by
simple-spacer
Comment #2 on issue 2177 by lemzw...@gmail.com: Patch: Reverts public
interface for simple spacer.
http://code.google.com/p/lilypond/issues/detail?id=2177
This is a problem with patchy: After applying a patch, all *.dep files
should be regenerated. The patch itself works fine, BTW, at least
Comment #3 on issue 2177 by gra...@percival-music.ca: Patch: Reverts public
interface for simple spacer.
http://code.google.com/p/lilypond/issues/detail?id=2177
how on earth do I do that?
I suspected a build problem, so patchy now re-runs autogen.sh and
configure. That isn't enough to
Comment #4 on issue 2177 by lemzw...@gmail.com: Patch: Reverts public
interface for simple spacer.
http://code.google.com/p/lilypond/issues/detail?id=2177
No, it isn't. Removing a header file doesn't automatically trigger the
engine to update the *.dep files.
In groff (which I maintain)
Status: New
Owner:
Labels: Type-Enhancement Patch-new
New issue 2177 by mts...@gmail.com: Patch: Reverts public interface for
simple spacer.
http://code.google.com/p/lilypond/issues/detail?id=2177
Reverts public interface for simple spacer.
http://codereview.appspot.com/5511044
22 matches
Mail list logo
