Re: [bug #33138] .PARLLELSYNC enhancement with patch

2013-04-16 Thread Paul Smith
On Tue, 2013-04-16 at 19:20 +0300, Eli Zaretskii wrote: > > From: Paul Smith > > Cc: bo...@kolpackov.net, bug-make@gnu.org, f.heckenb...@fh-soft.de > > Date: Tue, 16 Apr 2013 10:44:39 -0400 > > > > On Tue, 2013-04-16 at 16:43 +0300, Eli Zaretskii wrote: > > > > I'm not sure what the semantics of

Re: [PATCH 4/4] Windows: MSYS Autotools doc disabling hack

2013-04-16 Thread Ray Donnelly
This is all, of course, with sources from git. If configure contains the line continuation ('\') in AC_CONFIG_FILES, then we end up with this lovely construct in configure: "config/Makefile") CONFIG_FILES="$CONFIG_FILES config/Makefile" ;; "\") CONFIG_FILES="$CONFIG_FILES \" ;; "doc/Ma

Re: [bug #33138] .PARLLELSYNC enhancement with patch

2013-04-16 Thread Eli Zaretskii
> From: Paul Smith > Cc: bo...@kolpackov.net, bug-make@gnu.org, f.heckenb...@fh-soft.de > Date: Tue, 16 Apr 2013 10:44:39 -0400 > > On Tue, 2013-04-16 at 16:43 +0300, Eli Zaretskii wrote: > > > I'm not sure what the semantics of tmpfile() are on Windows. > > > > The file is automatically deleted

Re: [bug #33138] .PARLLELSYNC enhancement with patch

2013-04-16 Thread Paul Smith
On Tue, 2013-04-16 at 15:31 +0100, Tim Murphy wrote: > So this is great and you can see that there are 4 targets in my > makefile and that each one is a "start X" followed by an "end X". I > don't see any enter/exit delimitation - have I missed out some option? Um. Yes, the enter/leave only hap

Re: [bug #33138] .PARLLELSYNC enhancement with patch

2013-04-16 Thread Paul Smith
On Tue, 2013-04-16 at 16:43 +0300, Eli Zaretskii wrote: > > I'm not sure what the semantics of tmpfile() are on Windows. > > The file is automatically deleted when closed. But the documentation > doesn't say what happens if it is open on more than one descriptor, or > what happens if the original

Re: [PATCH 2/4] Windows: Add 'move' to sh_cmds_dos

2013-04-16 Thread Ray Donnelly
Thanks Eli, On systems where move *is* a built-in, gnumake fails as CreateProcess(NULL, "move" ...) doesn't work. On systems where move *is not* a built-in, my proposed fix is fine as "cmd.exe /c move" still works. Cheers, Ray. On Tue, Apr 16, 2013 at 2:59 PM, Eli Zaretskii wrote: > > Date:

Re: [bug #33138] .PARLLELSYNC enhancement with patch

2013-04-16 Thread Tim Murphy
Hi, I tried it out. It all works as I imagined - you were perfectly clear: bash-4.2$ ./make -Otarget -j 5 -f test.mk start a end a start b end b start c end c start d end d So this is great and you can see that there are 4 targets in my makefile and that each one is a "start X" followed by an "e

Re: [bug #33138] .PARLLELSYNC enhancement with patch

2013-04-16 Thread Eli Zaretskii
> From: Paul Smith > Cc: bo...@kolpackov.net, bug-make@gnu.org, f.heckenb...@fh-soft.de > Date: Tue, 16 Apr 2013 07:47:08 -0400 > > On Tue, 2013-04-16 at 11:30 +0300, Eli Zaretskii wrote: > > > Date: Tue, 16 Apr 2013 05:54:13 + > > > From: "Paul D. Smith" > > > > > > I did a little bit of c

Re: [PATCH 4/4] Windows: MSYS Autotools doc disabling hack

2013-04-16 Thread Eli Zaretskii
> Date: Tue, 16 Apr 2013 13:41:53 +0100 > From: Ray Donnelly > > This is just for reference for anyone who wants to build gnumake on > Windows. I don't want it to be applied as the real bugs are in Autotools. What are the bugs, and how do they manifest themselves? __

Re: [PATCH 2/4] Windows: Add 'move' to sh_cmds_dos

2013-04-16 Thread Eli Zaretskii
> Date: Tue, 16 Apr 2013 13:39:58 +0100 > From: Ray Donnelly > > 'move' is not listed as a cmd.exe builtin when it needs to be. > > > Not sure how this hasn't been spotted and fixed before now! It's not a bug, it is done on purpose: 'move' is a built-in on some versions of Windows, and a .exe

Re: [PATCH 3/4] Compile fix for when not using output-sync

2013-04-16 Thread Ray Donnelly
Oops! On Tue, Apr 16, 2013 at 1:41 PM, Paul Smith wrote: > On Tue, 2013-04-16 at 13:40 +0100, Ray Donnelly wrote: > > Pretty simple, needs little explanation. > > Maybe not but a patch would be nice :-) :-p > > > 0003-Compile-fix-for-when-not-using-output-sync.patch Description: Binary data _

Re: [bug #33138] .PARLLELSYNC enhancement with patch

2013-04-16 Thread Paul Smith
On Tue, 2013-04-16 at 09:57 +0100, Tim Murphy wrote: > When most rules are a single job this doesn't seem important but when > you're doing anything non trivial it becomes hard to see what is > where. Just to be clear: in this implementation the output from all individual commands in a recipe are

Re: [PATCH 3/4] Compile fix for when not using output-sync

2013-04-16 Thread Paul Smith
On Tue, 2013-04-16 at 13:40 +0100, Ray Donnelly wrote: > Pretty simple, needs little explanation. Maybe not but a patch would be nice :-) :-p ___ Bug-make mailing list Bug-make@gnu.org https://lists.gnu.org/mailman/listinfo/bug-make

[PATCH 4/4] Windows: MSYS Autotools doc disabling hack

2013-04-16 Thread Ray Donnelly
This is just for reference for anyone who wants to build gnumake on Windows. I don't want it to be applied as the real bugs are in Autotools. Best regards, Ray Donnelly. 0004-Windows-MSYS-Autotools-doc-disabling-hack.patch Description: Binary data ___

[PATCH 3/4] Compile fix for when not using output-sync

2013-04-16 Thread Ray Donnelly
Pretty simple, needs little explanation. Best regards, Ray Donnelly. ___ Bug-make mailing list Bug-make@gnu.org https://lists.gnu.org/mailman/listinfo/bug-make

[PATCH 2/4] Windows: Add 'move' to sh_cmds_dos

2013-04-16 Thread Ray Donnelly
'move' is not listed as a cmd.exe builtin when it needs to be. Not sure how this hasn't been spotted and fixed before now! Best regards, Ray Donnelly. 0002-Windows-Add-move-to-sh_cmds_dos.patch Description: Binary data ___ Bug-make mailing list Bu

Re: [bug #33138] .PARLLELSYNC enhancement with patch

2013-04-16 Thread Paul Smith
On Tue, 2013-04-16 at 09:57 +0100, Tim Murphy wrote: > What would be super cool is being able to get make to expand some sort > of variable at the start and another one at the end of the output so > that there was a way to see where one rule ended and the next one > began. Well, the new feature ad

[PATCH 1/4] Windows: Add load.c to build_w32.bat

2013-04-16 Thread Ray Donnelly
Because this modifies a batch file with Windows line endings it must be applied with --keep-cr, e.g.: git am 0001-Windows-Add-load.c-to-build_w32.bat.patch --keep-cr Best regards, Ray Donnelly. 0001-Windows-Add-load.c-to-build_w32.bat.patch Description: Binary data _

Re: feature request: parallel builds feature

2013-04-16 Thread Paul Smith
On Tue, 2013-04-16 at 01:34 -0700, Jim Michaels wrote: > I have been toying with this idea of parallel builds to gain project > compile speed (reducing time to a fraction) for quite a while. Can you explain the difference between what you're suggesting and the existing --jobs (-j) feature availabl

feature request: parallel builds feature

2013-04-16 Thread Jim Michaels
feature request: parallelize make builds. current problem: make is serial in nature. there is room for making it series-parallel. I have been toying with this idea of parallel builds to gain project compile speed (reducing time to a fraction) for quite a while. compiles seem to spend more time

Re: [bug #33138] .PARLLELSYNC enhancement with patch

2013-04-16 Thread Paul Smith
On Tue, 2013-04-16 at 11:30 +0300, Eli Zaretskii wrote: > > Date: Tue, 16 Apr 2013 05:54:13 + > > From: "Paul D. Smith" > > > > I did a little bit of code rearrangement, but I still think this code will > > not > > work on Windows and might possibly not compile on Windows. > > Indeed, it wi

Re: [bug #33138] .PARLLELSYNC enhancement with patch

2013-04-16 Thread Eli Zaretskii
> Date: Tue, 16 Apr 2013 09:56:01 +0100 > From: Tim Murphy > > IMHO, get it in and fix the details later because as it is it's exceedingly > useful. It's already in, that's what Paul's message was about. ___ Bug-make mailing list Bug-make@gnu.org http

Re: [bug #33138] .PARLLELSYNC enhancement with patch

2013-04-16 Thread Tim Murphy
[sorry to Eli for forgetting to replay-all] This is an awesome feature, especially for anyone trying to parse huge parallel build logs with errors in them - used to have this problem where you couldn't work out why X.cpp had that error at line 21 and realised that it was because that error didn't

Re: [bug #33138] .PARLLELSYNC enhancement with patch

2013-04-16 Thread Eli Zaretskii
> Date: Tue, 16 Apr 2013 05:54:13 + > From: "Paul D. Smith" > > I did a little bit of code rearrangement, but I still think this code will not > work on Windows and might possibly not compile on Windows. Indeed, it will not. Some cursory comments below. > Hopefully we can fix that. We sha