[PATCH] output.c: Fix memory stomp when need==fmtbuf.size

2014-01-26 Thread Ray Donnelly
Hi, Git commit 757849cd introduced a memory stomp in get_buffer() in output.c. If "need" is is equal to "fmtbuf.size" then: fmtbuf.buffer[need] = '\0'; .. writes '\0' to a byte 1 beyond the size of the allocated buffer. Please find attached a patch which fixes this. Best regards, Ray Donnelly.

Re: [PATCH] output.c: Fix memory stomp when need==fmtbuf.size

2014-01-26 Thread Ray Donnelly
I missed a few assert cases in the previous patch. Please find a fixed version attached. 0001-output.c-Fix-memory-stomp-when-need-fmtbuf.size.patch Description: Binary data ___ Bug-make mailing list Bug-make@gnu.org https://lists.gnu.org/mailman/listinf

Re: win32 compilation of make 4.0 source code‏

2014-01-26 Thread Mark Brown
That example method is a device to perform this .FEATURES test without inserting it into an existing Makefile. The syntax errors I was seeing were occurring when attempting to insert this test into an existing Makefile, full of Targets and command sequences. If this feature is used it would be a