Re: more GNU make 4.2.90 issues on Solaris 10

2019-08-27 Thread Paul Eggert
Dennis Clarke wrote: This is on a very up to date Oracle M3000 which is on contract support. You've got better hardware than mine, which is a Sun Fire 280R (circa 2005) with two 750 MHz UltraSPARC III CPUs. It was most recently patched three weeks ago so it's reasonably up-to-date. Our test

Re: more GNU make 4.2.90 issues on Solaris 10

2019-08-27 Thread Dennis Clarke
On 8/27/19 4:55 PM, Paul Eggert wrote: Paul Smith wrote: One problem seems to be that some tests assume that 'make check' runs GNU Make instead of /usr/ccs/bin/make, which chatters less. Dear Paul : I am using your patches plus two of my own and GNU Make 4.2.1 that I just built and teste

Re: GNU make 4.2.90 release candidate available

2019-08-27 Thread Dennis Clarke
On 8/27/19 1:46 PM, Paul Smith wrote: Sorry, I didn't mean you needed to explain all these options to me :). I was being overly Canadian and trying to apologize for weird things in my setup and then trying to use "rubber ducky" debugging to explain to myself why I was doing this. In particul

make 4.2.1 does build on Solaris 10 with Oracle Studio 12.6 C99

2019-08-27 Thread Dennis Clarke
I just had to do a quick check on this and the exact same machine that I am using to test 4.2.90 RC with does build 4.2.1 fine onceI apply a few very very small patches. beta$ beta$ uname -a SunOS beta 5.10 Generic_150400-65 sun4u sparc SUNW,SPARC-Enterprise beta$ psrinfo -pv The physical proces

Re: more GNU make 4.2.90 issues on Solaris 10

2019-08-27 Thread Paul Smith
On Tue, 2019-08-27 at 13:55 -0700, Paul Eggert wrote: > Sure, attached (this uses all the patches I've submitted so far). Adding > --disable-posix-spawn fixes some of the tests. The remaining test failures > are > archives, output-sync, vpathplus, shell, and wildcard. Yep, that's pretty definit

Re: more GNU make 4.2.90 issues on Solaris 10

2019-08-27 Thread Dennis Clarke
Me either, that's super strange. Does anyone remember if GNU make 4.2.1's output-sync tests failed this way? I grabbed 4.2.1 and tried it. Those tests fail similarly, so this is not a regression. Logs for 4.2.1 attached as well. Hold on a moment. I have 4.2.1 building and passing all tests

Re: patch to clean up lib/glob.c which may only help readability

2019-08-27 Thread Dennis Clarke
Sorry src/getopt.c was the major eye strain that I fixed there. Dennis ___ Bug-make mailing list Bug-make@gnu.org https://lists.gnu.org/mailman/listinfo/bug-make

patch to clean up lib/glob.c which may only help readability

2019-08-27 Thread Dennis Clarke
I tried reading through lib/glob.c as it lays there today and it was a bit messy. So I ran a chunk through the cb ( C Code Beautifier ) on ye Solaris 10 system with Oracle Studio 12.6 and then went line by line to make it more obvious. I tried to keep lines to 71 chars long. *** ./lib/glob.c.o

Re: more GNU make 4.2.90 issues on Solaris 10

2019-08-27 Thread Paul Eggert
Paul Smith wrote: One problem seems to be that some tests assume that 'make check' runs GNU Make instead of /usr/ccs/bin/make, which chatters less. I don't think (I hope!!) this is not the problem. If any part of the tests don't run GNU make it's a serious fail clearly. Can you expand upon w

Re: [PATCH] Pacify Oracle Studio c99

2019-08-27 Thread Dennis Clarke
On 8/27/19 4:23 PM, Paul Eggert wrote: Paul Smith wrote: I saw this warning on Windows as well.  I seem to recall that this was done on purpose to pack data structures more tightly, which can save a lot of memory on large build systems. However looking at it now I don't think it will actually e

Re: [PATCH] Pacify Oracle Studio c99

2019-08-27 Thread Paul Eggert
Paul Smith wrote: I saw this warning on Windows as well. I seem to recall that this was done on purpose to pack data structures more tightly, which can save a lot of memory on large build systems. However looking at it now I don't think it will actually end up saving any space. I don't either

Re: [PATCH] Pacify Oracle Studio c99

2019-08-27 Thread Paul Smith
On Tue, 2019-08-27 at 12:32 -0700, Paul Eggert wrote: > Use unsigned int, not unsigned short. Without this patch, c99 > complains ‘warning: nonportable bit-field type’. I saw this warning on Windows as well. I seem to recall that this was done on purpose to pack data structures more tightly, whi

[PATCH] Pacify Oracle Studio c99

2019-08-27 Thread Paul Eggert
* src/dep.h (DEP): * src/function.c (struct function_table_entry): Use unsigned int, not unsigned short. Without this patch, c99 complains ‘warning: nonportable bit-field type’. --- src/dep.h | 10 +- src/function.c | 4 ++-- 2 files changed, 7 insertions(+), 7 deletions(-) diff --

Re: more GNU make 4.2.90 issues on Solaris 10

2019-08-27 Thread Paul Smith
On Tue, 2019-08-27 at 12:13 -0700, Paul Eggert wrote: > After applying the patches I recently sent to bug-make, I still see several > tests failing on native Solaris 10 sparc (32-bit), built with Solaris tools > (including Oracle Studio 12.6) instead of with GNU tools. Please see attached > file

more GNU make 4.2.90 issues on Solaris 10

2019-08-27 Thread Paul Eggert
After applying the patches I recently sent to bug-make, I still see several tests failing on native Solaris 10 sparc (32-bit), built with Solaris tools (including Oracle Studio 12.6) instead of with GNU tools. Please see attached files, giving the relevant part of the 'make' output and the *.dif

Re: [PATCH] Pacify Oracle Studio 12.6 in init_switches

2019-08-27 Thread Paul Smith
On Tue, 2019-08-27 at 13:37 -0400, Dennis Clarke wrote: > "src/arscan.c", line 43: warning: tokens ignored at end of directive > line This was addressed by Paul's patch "Pacify Oracle Studio 12.6" > "src/dep.h", line 55: warning: nonportable bit-field type > "src/dep.h", line 64: warning: nonport

Re: GNU make 4.2.90 release candidate available

2019-08-27 Thread Paul Smith
Sorry, I didn't mean you needed to explain all these options to me :). In particular I was wondering about the CPPFLAGS, because attempting to add reserved preprocessor options to the compile line can cause problems in system header files. Also, by adding a new include directory to search, there

Re: GNU make 4.2.90 release candidate available

2019-08-27 Thread Dennis Clarke
On 8/26/19 10:59 PM, Paul Smith wrote: On Mon, 2019-08-26 at 19:33 -0400, Dennis Clarke wrote: I'll dig into this but on RHEL 7.4 x86_64 we see : src/job.c: In function 'reap_children': src/job.c:754:17: error: incompatible type for argument 1 of 'wait' EINTRLOOP (pid, wait (

Re: [PATCH] Pacify Oracle Studio 12.6 in init_switches

2019-08-27 Thread Dennis Clarke
On 8/27/19 3:40 AM, Paul Eggert wrote: * src/main.c (init_switches): Use a cast to convert char const * to char *. Without this patch, the compiler complains ‘"src/main.c", line 2643: warning: assignment type mismatch: Using the c99 compiler with realyl strict CFLAGS I see these : "src/arscan

Re: GNU make 4.2.90 release candidate available

2019-08-27 Thread Dennis Clarke
On 8/27/19 8:33 AM, Paul Smith wrote: > On Tue, 2019-08-27 at 01:21 -0400, Dennis Clarke wrote: >> On 8/26/19 10:59 PM, Paul Smith wrote: >>> On Mon, 2019-08-26 at 19:33 -0400, Dennis Clarke wrote: I'll dig into this but on RHEL 7.4 x86_64 we see : src/job.c: In function 'reap_child

Re: GNU make 4.2.90 release candidate available

2019-08-27 Thread Paul Smith
On Tue, 2019-08-27 at 01:21 -0400, Dennis Clarke wrote: > On 8/26/19 10:59 PM, Paul Smith wrote: > > On Mon, 2019-08-26 at 19:33 -0400, Dennis Clarke wrote: > > > I'll dig into this but on RHEL 7.4 x86_64 we see : > > > > > > src/job.c: In function 'reap_children': > > > src/job.c:754:17: error: i

Re: GNU make 4.2.90 release candidate available

2019-08-27 Thread Andreas Schwab
On Aug 26 2019, Paul Smith wrote: > On Mon, 2019-08-26 at 10:26 -0700, David Boyce wrote: >> Does this mean that the autotools config system will select >> POSIX_SPAWN_USEVFORK? That's not a behavior of GNU make per se. > > Yes, autoconf will detect and use it. I'm not sure I understand the > co

[PATCH] Port grouped_targets test to Solaris 10

2019-08-27 Thread Paul Eggert
* tests/scripts/features/grouped_targets: Use ‘printf ''’ instead of ‘echo -n’, as POSIX says the latter is not portable. --- tests/scripts/features/grouped_targets | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/scripts/features/grouped_targets b/tests/scripts/features/

[PATCH] Remove useless code in eval

2019-08-27 Thread Paul Eggert
* src/read.c (eval): Remove useless code. Without this patch, Oracle Studio 12.6 complains ‘"src/read.c", line 1405: warning: loop not entered at top’. --- src/read.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/src/read.c b/src/read.c index 175d714..546280c 100644 --- a/src/read.c +

[PATCH] Pacify Oracle Studio 12.6 in init_switches

2019-08-27 Thread Paul Eggert
* src/main.c (init_switches): Use a cast to convert char const * to char *. Without this patch, the compiler complains ‘"src/main.c", line 2643: warning: assignment type mismatch: pointer to char "=" pointer to const char’. --- src/main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

[PATCH] Pacify Oracle Studio 12.6

2019-08-27 Thread Paul Eggert
* src/arscan.c [VMS]: Use ‘#if !defined LBR$_HDRTRUNC’ instead of ‘#ifndef LBR$_HDRTRUNC’ to pacify Oracle Studio 12.6, which looks inside unused #if branches for preprocessor syntax errors. Without this patch it complains ‘"src/arscan.c", line 43: warning: tokens ignored at end of directive line’.