[bug #56449] job.c (construct_command_argv_internal): Must use shell if '%' character is present in recipe line

2019-08-30 Thread Christian Eggers
Follow-up Comment #12, bug #56449 (project make): [comment #10 comment #10:] > GNU Make emulates the behavior of the shell as if the user typed the commands at the shell's prompt. It is true that you need to double the % characters in batch files, but GNU Make doesn't behave like batch files do.

[bug #56449] job.c (construct_command_argv_internal): Must use shell if '%' character is present in recipe line

2019-08-30 Thread Eli Zaretskii
Follow-up Comment #10, bug #56449 (project make): GNU Make emulates the behavior of the shell as if the user typed the commands at the shell's prompt. It is true that you need to double the % characters in batch files, but GNU Make doesn't behave like batch files do. So I think this change is fo

[bug #56449] job.c (construct_command_argv_internal): Must use shell if '%' character is present in recipe line

2019-08-30 Thread Eli Zaretskii
Follow-up Comment #11, bug #56449 (project make): > I also remember that using echo is not a good idea for demonstration with make. I also mentioned calling a Windows program with the argument of %%. The program in this case gets the literal two % characters in its argv[] array. If you invoke y

[bug #56449] job.c (construct_command_argv_internal): Must use shell if '%' character is present in recipe line

2019-08-30 Thread Christian Eggers
Follow-up Comment #7, bug #56449 (project make): Hi, I'm the original author of this bug. It's some time ago I wrote this, so maybe I've forgotten some details... [comment #2 comment #2:] > I see that this bug was fixed and closed, but looking at the result, I'm not sure the fix is correct. If I

[bug #56834] PATH not honored when --disable-posix-spawn is not used

2019-08-30 Thread anonymous
URL: Summary: PATH not honored when --disable-posix-spawn is not used Project: make Submitted by: None Submitted on: Fri 30 Aug 2019 12:20:12 PM UTC Severity: 3 - Normal

[bug #56449] job.c (construct_command_argv_internal): Must use shell if '%' character is present in recipe line

2019-08-30 Thread Christian Eggers
Follow-up Comment #9, bug #56449 (project make): [comment #6 comment #6:] > But the result is wrong when %..% doesn't specify a known variable, most probably because we invoke the command through a batch file. The question may be, which of both results is the correct one. So if cmd.exe has someth

[bug #56449] job.c (construct_command_argv_internal): Must use shell if '%' character is present in recipe line

2019-08-30 Thread Christian Eggers
Follow-up Comment #8, bug #56449 (project make): [comment #5 comment #5:] > Sorry, I think there's some confusion. All this patch does is detect if we see a % in the command line and if so we do not take the fast path: instead we take the slow path and invoke command.com. > > So we're not trying

Re: GNU make 4.2.90 release candidate available

2019-08-30 Thread Eli Zaretskii
Ping! Is it OK to push the change I propose below? > Date: Wed, 28 Aug 2019 19:01:39 +0300 > From: Eli Zaretskii > Cc: bug-make@gnu.org > > > From: Paul Smith > > Cc: bug-make@gnu.org > > Date: Wed, 28 Aug 2019 11:25:25 -0400 > > > >$string = `sh -c "$make_path -f null.mk $redir"`; > >