Re: gmake-4.2.90 regression (segmentation fault in sum_up_to_nul )

2019-09-25 Thread Dmitry Goncharov via Bug reports and discussion for GNU make
On Tue, Sep 24, 2019 at 1:01 PM Paul Smith wrote: > The reason for the "special" code here is > performance, and unfortunately the solution proposed will reduce > performance by a measurable amount (not huge but measurable). Paul, is this call to strlen that you are concerned with? It is possible

Re: gmake-4.2.90 regression (segmentation fault in sum_up_to_nul )

2019-09-25 Thread Paul Smith
On Wed, 2019-09-25 at 08:29 +, Edward Welbourne wrote: > > With "normal" systems it's safe to read (only) memory beyond the end > > of an array, at least up to the next word size, which is what this > > code does. > > If you want to be able to rely on this "normal" behaviour, for the sake > of

Re: gmake-4.2.90 regression (segmentation fault in sum_up_to_nul )

2019-09-25 Thread Edward Welbourne
On Tue, 2019-09-03 at 04:14 +, Dmitry Goncharov wrote: >> sum_up_to_nul reads 4 bytes starting from the passed string 'p'. 'p' >> can have fewer than 4 bytes. Usually there more allocated space after >> 'p', which prevents this reading from manifesting itself. Usually malloc aligns its alloca