[bug #48643] Irrelevant targets can confuse make on which pattern rule to select.

2021-10-17 Thread Paul D. Smith
Follow-up Comment #7, bug #48643 (project make): Perhaps your argument is (similar to Boris's argument in bug #17752 ) that the algorithm in the manual is bad and should be changed; in particular the rule 5.3 that says "ought to exist" means "mentioned as a target or a prerequisite" anywhere in th

[bug #48643] Irrelevant targets can confuse make on which pattern rule to select.

2021-10-17 Thread Paul D. Smith
Update of bug #48643 (project make): Status: Fixed => None Open/Closed: Closed => Open ___ Follow-up Comment #6: I'm seeing some failur

Re: [bug #61226] A regression prevents generation of missing included dependency files.

2021-10-17 Thread Britton Kerin
On Sun, Oct 17, 2021 at 4:44 PM Dmitry Goncharov wrote: > > On Sun, Oct 17, 2021 at 3:05 PM Britton Kerin wrote: > > > If I understand right that the idea is a special case for .d files > > The question being discussed is what to do when make cannot include a > makefile. I got that but it sound

Re: [bug #61226] A regression prevents generation of missing included dependency files.

2021-10-17 Thread Dmitry Goncharov via Bug reports and discussion for GNU make
On Sun, Oct 17, 2021 at 3:05 PM Britton Kerin wrote: > If I understand right that the idea is a special case for .d files The question being discussed is what to do when make cannot include a makefile. regards, Dmitry

Re: [bug #61226] A regression prevents generation of missing included dependency files.

2021-10-17 Thread Britton Kerin
On Sun, Oct 17, 2021 at 8:33 AM Dmitry Goncharov wrote: > > Follow-up Comment #8, bug #61226 (project make): > > > > Switching to -include robs the user of a useful message, should there be a > real issue. > > > I'm not sure what this means: in what situation do we lose a useful > message? > > -in

[bug #61042] Enhance implicit rule search logging

2021-10-17 Thread Dmitry Goncharov
Follow-up Comment #8, bug #61042 (project make): Merged master to my branch and resolved the conflict in patch sv_61042_implicit_rule_search_logging2.diff. The same change is also available here g...@github.com:dgoncharov/make.git on branch sv61042_enhance_implicit_search_logging. (file #52115

[bug #61042] Enhance implicit rule search logging

2021-10-17 Thread Dmitry Goncharov
Follow-up Comment #7, bug #61042 (project make): There are 2 situations when implicit rule lookup takes this short cut. 1. hello.tsk: hello.o %.tsk: %.o; touch $@ and 2. hello.tsk: %.tsk: %.o; touch $@ hello.o: There are 2 if branches in implicit.c This branch handles the

[bug #61042] Enhance implicit rule search logging

2021-10-17 Thread Paul D. Smith
Follow-up Comment #6, bug #61042 (project make): I see that I missed a part of the original patch. Hm, there are a number of recent changes to this section of code which are in conflict and the way I originally resolved this was incorrect. I'll need to figure out what's going on. __

[bug #61226] A regression prevents generation of missing included dependency files.

2021-10-17 Thread Dmitry Goncharov
Follow-up Comment #8, bug #61226 (project make): > > Switching to -include robs the user of a useful message, should there be a real issue. > I'm not sure what this means: in what situation do we lose a useful message? -include robs the user of a not readable or corrupted .d file, even though us

[bug #61042] Enhance implicit rule search logging

2021-10-17 Thread Paul D. Smith
Follow-up Comment #5, bug #61042 (project make): Actually that change causes a number of regression tests to fail with incorrect output so I removed it. ___ Reply to this item at: _

[bug #61042] Enhance implicit rule search logging

2021-10-17 Thread Paul D. Smith
Follow-up Comment #4, bug #61042 (project make): Dmitry I'm not sure about this change: @@ -744,15 +752,9 @@ pattern_search (struct file *file, int archive, /* If this prereq is also explicitly mentioned for FILE, skip all tests below since it must be bui

[bug #61226] A regression prevents generation of missing included dependency files.

2021-10-17 Thread Paul D. Smith
Follow-up Comment #7, bug #61226 (project make): Well, we could print one warning per include line rather than one warning per file included. Obviously, that warning would only talk about the first file on the include line but since the suggested solution is to use "-include" maybe that's suffici