Re: Crash in 'find_and_set_default_shell()'

2022-05-10 Thread Gisle Vanem
Paul Smith wrote: ... else (b) make has to parse this string and break it up into words that it can use to call exec() without going through a shell The crash and wild call-stack seems to be caused by an overflow to 'sprintf(sh_path, ..)'. But replacing with 'snprintf()' works w/o any crash:

Re: Archive Members as Targets

2022-05-10 Thread Henrik Carlqvist
On Tue, 10 May 2022 22:05:22 -0400 Dmitry Goncharov wrote: > > But not on the Linux boxes there make always rebuild everything. On all > > machines I am using GNU Make. > ... > > Can anyone confirm that? > > i can confirm that for me on linux the latest make from git as well as > make-4.3 correc

Re: Archive Members as Targets

2022-05-10 Thread Dmitry Goncharov
On Tue, May 10, 2022 at 5:12 PM Michael Lehn wrote: > But not on the Linux boxes there make always rebuild everything. On all > machines I am using GNU Make. ... > Can anyone confirm that? i can confirm that for me on linux the latest make from git as well as make-4.3 correctly detect that libfo

Archive Members as Targets

2022-05-10 Thread Michael Lehn
I have a problem with GNU make when using [Archive Members as Targets](https://www.gnu.org/software/make/manual/html_node/Archive-Members.html#Archive-Members). The problem is that on some machines (e.g. running MacOS, Solaris) it works fine, i.e. builds the library and the next `make` gives `No

Re: Crash in 'find_and_set_default_shell()'

2022-05-10 Thread Eli Zaretskii
> From: Paul Smith > Date: Tue, 10 May 2022 11:05:40 -0400 > > I will say that this does work as expected and doesn't throw an error > with the latest GNU make Git version, on GNU/Linux. On MS-Windows, we can barely _emulate_ Posix, so what might, by sheer luck, work on GNU/Linux, regardless of

Re: Crash in 'find_and_set_default_shell()'

2022-05-10 Thread Paul Smith
On Tue, 2022-05-10 at 15:03 +0200, Gisle Vanem wrote: > SHELL := env "PATH=$(PATH)" /bin/bash Well, I dunno. The problem is that at some point you have to choose which command to use to invoke something. The SHELL variable is intended to contain a shell program that make will exec(). Here you'r

Crash in 'find_and_set_default_shell()'

2022-05-10 Thread Gisle Vanem
Hello list. Some resent (?) change has caused a crash in 'find_and_set_default_shell()' with this minimal Makefile: export PATH := $(PATH):node_modules/.bin SHELL := env "PATH=$(PATH)" /bin/bash all: @echo "Hello" --- Without the 'SHELL ..' line, all is good. Or even a 'SHELL=/