[bug #63157] Unlink temporary files.

2022-10-04 Thread Eli Zaretskii
Follow-up Comment #4, bug #63157 (project make): This should be tested on MS-Windows. A file can only be deleted on MS-Windows if it isn't open by any program, and the patch (AFAICT) doesn't make sure the files are closed before unlinking them. I'm especially worried about the temp_stdin_unlink

Re: .SECONDARY unexpectedly affects rule invocation

2022-10-04 Thread Dmitry Goncharov
On Tuesday, October 4, 2022, Mikhail Pomaznoy wrote: > Martin's snippet indeed recapitulates the behavior resulted in my initial > report. > > As for Dmitry's reply: I don't understand if *make* does what's expected > or not. > > > Works as documented. Even though I am not sure this particular c

Re: .SECONDARY unexpectedly affects rule invocation

2022-10-04 Thread Mikhail Pomaznoy
Martin's snippet indeed recapitulates the behavior resulted in my initial report. As for Dmitry's reply: I don't understand if /make/ does what's expected or not. I believed that A.4 being a prereq of A.4.ind will always trigger the latter being rebuilt if A.4 is newer. As a side note: I use

[bug #63157] Unlink temporary files.

2022-10-04 Thread Dmitry Goncharov
Follow-up Comment #3, bug #63157 (project make): Also, tested presence of PPID variable in ksh, bash, ash, zsh, sh. The only shell that i encountered that lacks PPID is tcsh (likely csh as well). The test uses the default shell. This means that test will likely fail on a system where /bin/sh is cs

Re: .SECONDARY unexpectedly affects rule invocation

2022-10-04 Thread Dmitry Goncharov
On Tue, Oct 4, 2022 at 10:08 PM Martin Dorey wrote: > Isn't this slightly simplified example sufficient to demonstrate the same > behavior... A.4 is a preqreq to T.1 and also a prereq to A.4.ind. A.4.ind is present and that's why make skips building secondary A.4 and keeps A.4.ind intact, while

[bug #63157] Unlink temporary files.

2022-10-04 Thread Dmitry Goncharov
Follow-up Comment #2, bug #63157 (project make): Tested this patch on linux, sun and aix. All 64 bit. This patch adds jobserver_unlink stub on windows. As far as i can visually validate, this stub should compile fine. However, have not tested this on windows.

[bug #63157] Unlink temporary files.

2022-10-04 Thread Dmitry Goncharov
Additional Item Attachment, bug #63157 (project make): File name: sv63157_fix.diff Size:4 KB File name: sv63157_test.diff Size:2 KB

[bug #63157] Unlink temporary files.

2022-10-04 Thread Dmitry Goncharov
Follow-up Comment #1, bug #63157 (project make): Make fails to unlink temporary files upon arrival of a fatal signal. Specifically, the jobserver fifo, output sync lock and the stdin temp file. ___ Reply to this item at:

[bug #63157] Unlink temporary files.

2022-10-04 Thread Dmitry Goncharov
URL: Summary: Unlink temporary files. Project: make Submitter: dgoncharov Submitted: Wed 05 Oct 2022 02:24:38 AM UTC Severity: 3 - Normal Item Group: Bug

Re: .SECONDARY unexpectedly affects rule invocation

2022-10-04 Thread Martin Dorey
> A further note: it's version 4.3 of make Behavior seems the same to me from (at least) 3.81 to 4.3.91 (inclusive). Isn't this slightly simplified example sufficient to demonstrate the same behavior... martind@sirius:~/tmp/Pomaznoy-2022-10-04$ cat Makefile RECIPE = echo "Making $@ from $^" >

[bug #63156] Preserve TMPDIR in test env.

2022-10-04 Thread Dmitry Goncharov
Additional Item Attachment, bug #63156 (project make): File name: sv63156.diff Size:1 KB ___ Reply to this item at:

[bug #63156] Preserve TMPDIR in test env.

2022-10-04 Thread Dmitry Goncharov
Follow-up Comment #1, bug #63156 (project make): Tests which are supposed to test that make removes temporary files succeed whether make removed the file or not. This happens because, test_driver.pl sets TMPDIR in makeENV after setting env for the test. Thus the test env uses the default TMPDIR an

[bug #63156] Preserve TMPDIR in test env.

2022-10-04 Thread Dmitry Goncharov
URL: Summary: Preserve TMPDIR in test env. Project: make Submitter: dgoncharov Submitted: Wed 05 Oct 2022 01:57:44 AM UTC Severity: 3 - Normal Item Group: Bug

Re: .SECONDARY unexpectedly affects rule invocation

2022-10-04 Thread Mikhail Pomaznoy
A further note: it's version 4.3 of make On 10/4/22 14:57, Mikhail Pomaznoy wrote: Greetings, I have encountered weird behavior in make and tried to isolate it.  The software was built from source. I have the following Makefile: |RECIPE = echo "Making $@ from $^" > $@|| ||T.1 : A.4 A.4.ind

Re: [PATCH] Port to 32-bit long + 64-bit time_t

2022-10-04 Thread Paul Eggert
On 10/3/22 12:56, Paul Eggert wrote: In looking through old dev histories it appears Paul pushes changes every now and then, so I'll wait until he's pushed his next batch of changes, which will presumably include some timestamp-related fixes, before looking into this again. Thanks, that merge

Re: Deprecating OS support

2022-10-04 Thread Juan Manuel Guerrero
Am Sat, 01 Oct 2022 21:52:03 +0300 schrieb Eli Zaretskii : > > From: Paul Smith > > Cc: bug-make@gnu.org, Juan Manuel Guerrero > > Date: Sat, 01 Oct 2022 14:48:01 -0400 > > > > On Sat, 2022-10-01 at 20:42 +0300, Eli Zaretskii wrote: > > > The DJGPP project has been routinely porting all versions

.SECONDARY unexpectedly affects rule invocation

2022-10-04 Thread Mikhail Pomaznoy
Greetings, I have encountered weird behavior in make and tried to isolate it.  The software was built from source. I have the following Makefile: |RECIPE = echo "Making $@ from $^" > $@|| ||T.1 : A.4 A.4.ind; $(RECIPE)|| ||A.4 : A.3 A.3.ind || ||    $(RECIPE)|| ||A.2 :|| ||    $(RECIPE)|| ||A

Re: [PATCH] Port to 32-bit long + 64-bit time_t

2022-10-04 Thread Paul Smith
On Tue, 2022-10-04 at 09:06 +0300, Eli Zaretskii wrote: > > From: Paul Smith > > Cc: bug-make@gnu.org > > Date: Mon, 03 Oct 2022 16:14:01 -0400 > > > > I needed another set of changes, since intmax_t is a new type and > > is not available on Windows so we needed to add it to configure.ac > > etc.