[bug #63307] make 4.4 passes ignored SIGPIPE on to children

2022-11-06 Thread Paul D. Smith
Follow-up Comment #10, bug #63307 (project make): I'm not sure how using a semaphore helps here. We would still have to clean up the semaphore with sem_unlink(). The main goal of that change was to allow our cleanup operations to proceed even when SIGPIPE was found, and semaphores still need to

[bug #63315] Test failures with 4.4 on OpenBSD

2022-11-06 Thread Paul D. Smith
Follow-up Comment #6, bug #63315 (project make): I'm not sure what the problem actually is here. It's something weird about the shell; it's doing something strange with SIGTERM. However I modified the helper app to be able to send TERM then replaced the test recipe "kill -TERM && sleep" with a

[bug #63315] Test failures with 4.4 on OpenBSD

2022-11-06 Thread Paul D. Smith
Follow-up Comment #5, bug #63315 (project make): I was looking at it yesterday. Both the kill / cleanup tests (temp_stdin and the one in output-sync) are failing because they are showing the exit code, not the Terminated output. It's not a big problem because the temporary files are cleaned up

[bug #62174] fix test functions/shell on aix.

2022-11-06 Thread Dmitry Goncharov
Follow-up Comment #5, bug #62174 (project make): I can confirm the current code works. Thank you. ___ Reply to this item at: ___ Message sent via

[bug #63307] make 4.4 passes ignored SIGPIPE on to children

2022-11-06 Thread Dmitry Goncharov
Follow-up Comment #9, bug #63307 (project make): On Sat, Nov 5, 2022 at 6:54 PM Philip Guenther wrote: > This is a change in behavior: The root of this change is not sigpipe itself, it is the new synchronisation mechanism which uses temporary files. Paul, i remember we discussed using a semaphore

[bug #63307] make 4.4 passes ignored SIGPIPE on to children

2022-11-06 Thread Dmitry Goncharov
Additional Item Attachment, bug #63307 (project make): File name: sv63307_fix2.diff Size:1 KB File name: sv63307_test2.diff Size:2 KB

[bug #63307] make 4.4 passes ignored SIGPIPE on to children

2022-11-06 Thread anonymous
Follow-up Comment #8, bug #63307 (project make): There may be an even simpler solution than that. There was never any need to ignore SIGPIPE, we just need to make sure temporary files are cleaned up if we get SIGPIPE, it's okay and expected if make dies after that cleanup. There is already a

[bug #63307] make 4.4 passes ignored SIGPIPE on to children

2022-11-06 Thread anonymous
Follow-up Comment #7, bug #63307 (project make): > Other reasons are the desire to avoid complexity in make. I agree with the desire to avoid complexity, but preserving an ignored SIGPIPE on top of your patch needs no more than: if (bsd_signal (SIGPIPE, handle_sigpipe) == SIG_IGN)