Re: [PATCH] Fix integer overflow test in parse_int

On 1/7/24 16:09, Paul Eggert wrote: * src/arscan.c (parse_int): Use intprops.h macros rather than trying to detect integer overflow by hand, and doing it incorrectly. Here is an example of why the old code was incorrect. If val == 3689348814741910323, base == 10, *ptr == '0', UINTMAX_WIDTH == 64,

[PATCH] Fix integer overflow test in parse_int

* src/arscan.c (parse_int): Use intprops.h macros rather than trying to detect integer overflow by hand, and doing it incorrectly. Here is an example of why the old code was incorrect. If val == 3689348814741910323, base == 10, *ptr == '0', UINTMAX_WIDTH == 64, then (val * base) + (*ptr - '0') yiel

[bug #64571] Add option to print targets

Follow-up Comment #13, bug#64571 (group make): It depends on what you mean by "this context". If what we are suggesting is to use this new JSON output format so that we don't need to create an option to print targets, then it's very relevant since the goal of this option is to provide input for t

[bug #64571] Add option to print targets

Follow-up Comment #12, bug#64571 (group make): Wow, that's great stuff from Tim. I was really re-treading his steps there, even with the same flag name `--print-data-base-json`! Definitely valid limitations of nested JSON, very tricky to parse without the right tools. However, in this context, is

[bug #64571] Add option to print targets

Follow-up Comment #11, bug#64571 (group make): Tim Murphy had a proposal and even a patch to generate JSON, posted to bug-make a few weeks ago: https://lists.gnu.org/archive/html/bug-make/2023-12/msg00027.html Overall I like JSON but I'm not convinced it will be as helpful for this situation. Th

[bug #64571] Add option to print targets

Follow-up Comment #10, bug#64571 (group make): @psmith, just missed your comment while I was writing mine :) Seems like we were thinking in a similar direction, I agree the `--format` option is a good fit with how other tools handle this. When I get a chunk of time, I can put in a proposal for th

[bug #64571] Add option to print targets

Follow-up Comment #9, bug#64571 (group make): I had a thought about how this could be approached in a different way. As has been mentioned, we already have a lot of information available about targets (also variables and other info) via the `--print-data-base` flag. It's just that as it currently

[bug #64571] Add option to print targets

Follow-up Comment #8, bug#64571 (group make): Let me just say up-front that my biggest concern with this is going in the direction you suggest: > I guess you can always add flags to refine the behaviour later if necessary Just... no. I won't introduce an entire family of options that tweak and

[bug #65019] Let function segfaults when foreach return empty list

Update of bug#65019 (group make): Status:None => Fixed Open/Closed:Open => Closed Operating System:None => Any Fixed Release:

[bug #65006] Implement second expansion of .EXTRA_PREREQS.

Update of bug#65006 (group make): Status:None => Fixed Open/Closed:Open => Closed Component Version: SCM => 4.3 Fixed Release:

[bug #64428] Document how to simplify debug output.

Update of bug#64428 (group make): Status:None => Duplicate Open/Closed:Open => Closed Operating System:None => Any Triage Status:

[bug #64402] error parsing functions in braces inside ifeq, ifneq

Update of bug#64402 (group make): Status:None => Fixed Assigned to:None => psmith Open/Closed:Open => Closed Fixed Release:

[bug #64339] $(filter) and $(filter-out) interpret "match" in surprising ways

Update of bug#64339 (group make): Item Group:None => Documentation Status:None => Fixed Assigned to:None => psmith Open/Closed: