Re: [PATCH] Fix biased shuffle by avoiding already "struck" elements

2024-06-21 Thread Dmitry Goncharov
On Wed, Jun 19, 2024 at 5:37 PM Sergei Trofimovich wrote: > Glancing at tests/ all the tests exercise user-facing `make` API. What > would be the best way to validate probabilities? For this type of code like shuffle, i like testing the function itself, directly. Just calling the function in a t

Re: [PATCH] Fix biased shuffle by avoiding already "struck" elements

2024-06-21 Thread Paul Smith
On Fri, 2024-06-21 at 09:11 -0400, Dmitry Goncharov wrote: > i hope, Paul approves adding tests of this nature. I have no problems with adding unit tests, as long as we can find a way to integrate it into the test suite in a reasonable way. But this particular thing doesn't really feel like a "te

Re: [PATCH] Fix biased shuffle by avoiding already "struck" elements

2024-06-21 Thread Dmitry Goncharov
On Fri, Jun 21, 2024 at 10:30 AM Paul Smith wrote: > > On Fri, 2024-06-21 at 09:11 -0400, Dmitry Goncharov wrote: > > i hope, Paul approves adding tests of this nature. > > I have no problems with adding unit tests, as long as we can find a way > to integrate it into the test suite in a reasonable