Re: A question about hasing in idutils

2024-03-26 Thread Andreas Schwab
and big endian? It should be easy to fix: swap the bytes in sum_get_unaligned_32. -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different."

[bug #64818] patsubst shorthand documentation bug?

2023-10-26 Thread Andreas Schwab
Follow-up Comment #4, bug #64818 (project make): You are missing the %. $(patsubst %World,Earth,$(STR)) ___ Reply to this item at: ___ Message sent via

[bug #64818] patsubst shorthand documentation bug?

2023-10-26 Thread Andreas Schwab
Follow-up Comment #2, bug #64818 (project make): The difference is that pattern contains a % bug suffix does not. This is explained in #Substitution-Refs. ___ Reply to this item at: _

Re: wildcard and globstar

2023-07-17 Thread Andreas Schwab
*/*.mk > $(MAKEFILEDIR)/*/*/*.mk) $(wildcard $(addprefix $(MAKEFILEDIR)/, *.mk */*.mk */*/*.mk)) -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different."

Re: 4.4.1 breaks recursive invocation with --print-directory [when adding to MAKEFLAGS]

2023-03-01 Thread Andreas Schwab
notation - contributing to this issue. > > And the reason we use the order '-j8 ${MAKEFLAGS}' is so that we have the > following behavior': You need to write it as MAKEFLAGS="-j1 -${MAKEFLAGS}", so that the short options at the start of the old value of MAKEFLAGS become a proper options string. -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different."

[bug #63307] make 4.4 passes ignored SIGPIPE on to children

2022-11-08 Thread Andreas Schwab
Follow-up Comment #14, bug #63307 (project make): The SIGPIPE failure only happens when the process actually produces output to the broken pipe. But it is equally likely that a recipe doesn't actually produce any output on stdout. ___ Rep

[PATCH] [SV 63307] Reset SIGPIPE in spawned children

2022-11-02 Thread Andreas Schwab
ds us SIGPIPE. */ #ifdef SIGPIPE - bsd_signal (SIGPIPE, SIG_IGN); + sigpipe_ignored = bsd_signal (SIGPIPE, SIG_IGN) == SIG_IGN; #endif #ifdef HAVE_ATEXIT -- 2.38.1 -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "A

[PATCH] [SV 63307] Unignore SIGPIPE in spawned children

2022-11-02 Thread Andreas Schwab
goto cleanup; +flags |= POSIX_SPAWN_SETSIGDEF; + } +#endif + /* USEVFORK can give significant speedup on systems where it's available. */ #ifdef POSIX_SPAWN_USEVFORK flags |= POSIX_SPAWN_USEVFORK; -- 2.38.1 -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8

Re: [bug #63248] Ignore sigpipe.

2022-11-02 Thread Andreas Schwab
On Nov 02 2022, Paul D. Smith wrote: > Make should not pass the ignore to children; if it does that's a bug in make > and should be reported. I don't see anything that unignores SIGPIPE. -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE

[PATCH] [SV 63111] Set osync handle to noinherit

2022-09-27 Thread Andreas Schwab
open output sync mutex %s: %s"), osync_tmpfile, strerror (errno)); + fd_noinherit (osync_handle); + return 1; } -- 2.37.3 -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different."

[PATCH] [SV 63111] Clean up output sync before re-executing

2022-09-27 Thread Andreas Schwab
) fflush (stdout); fflush (stderr); + osync_clear (); + /* The exec'd "child" will be another make, of course. */ jobserver_pre_child(1); -- 2.37.3 -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8 1CE9

[bug #63111] Regression. make runs out of file descriptors.

2022-09-27 Thread Andreas Schwab
Follow-up Comment #2, bug #63111 (project make): Note that dtc has already fixed the problematic pattern rule (see commit 98a0700). ___ Reply to this item at: _

Re: Make 4.3.90 breaks makefile of dtc

2022-09-26 Thread Andreas Schwab
On Sep 23 2022, Dmitry Goncharov wrote: > The latest make from master (same as 4.3.90) builds dtc-1.6.1 Try building it with make -O -j4 V=1, and watch /tmp filling with Gm* files, and the make process growing its file table. -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerpr

Re: Make 4.3.90 breaks makefile of dtc

2022-09-26 Thread Andreas Schwab
On Sep 22 2022, Dmitry Goncharov wrote: > On Thu, Sep 22, 2022 at 4:39 AM Andreas Schwab wrote: > ... >> Interestingly, this eventually runs out of file >> descriptors, because, due to -O, make keeps opening new pipes for >> synchronizing the output without closing any.

Re: Make 4.3.90 breaks makefile of dtc

2022-09-26 Thread Andreas Schwab
On Sep 22 2022, Paul Smith wrote: > Just to be clear when you say "the issue is" do you mean, if you remove > the unnecessary %.output pattern you don't see the error anymore? Yes. -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE

Re: Make 4.3.90 breaks makefile of dtc

2022-09-22 Thread Andreas Schwab
The issue is that the bison rule says it creates a %.output file, but doesn't actually do that. %.tab.c %.tab.h %.output: %.y @$(VECHO) BISON $@ $(BISON) -b $(basename $(basename $@)) -d $< Note that no target actually depends on any *.output file. -- Andreas Schwab, S

Make 4.3.90 breaks makefile of dtc

2022-09-22 Thread Andreas Schwab
-unwind-tables -fstack-clash-protection -Werror=return-type -flto=auto -g" There is some misbehaviour that creates an infinite loop trying to run the bison rule. Interestingly, this eventually runs out of file descriptors, because, due to -O, make keeps opening new pipes for synchronizing the output without closing any. Without -O, this would probably go on forever. With make 4.3 this runs to completion without issues. -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different."

[bug #62162] patsubst not working in prerequisites under .SECONDEXPANSION

2022-03-10 Thread Andreas Schwab
Follow-up Comment #1, bug #62162 (project make): The replacement of % by the stem happens before the secondary expansion is performed. ___ Reply to this item at: ___

Re: [PATCH 3/3] Introduce $(compare ...) for numerical comparison

2021-12-06 Thread Andreas Schwab
wrong in any > standards-conforming implementation of C. This is wrong. These are *minimum* limits. Andreas. -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different."

Re: [bug #60841] misleading statement in the manual

2021-06-28 Thread Andreas Schwab
On Jun 27 2021, Dmitry Goncharov wrote: > The manual states in 6.10 Title: "Variables from the Environment". > "When make runs a recipe, variables defined in the makefile are placed into > the environment of each shell." Please also read the rest of the paragraph.

Re: [bug #60798] Make does not compile with GCC 11.1.0

2021-06-21 Thread Andreas Schwab
ell the compiler that eval_strings->idx is always > 0, which is pretty hard for the compiler to deduce. Andreas. -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different."

Re: export vs $(origin )

2020-07-06 Thread Andreas Schwab
commands) if it doesn't have a value yet. Andreas. -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different."

Re: [bug #57674] regression in make 4.3 with makefile from stdin

2020-04-01 Thread Andreas Schwab
t; execvp() does. There is also posix_spawnp. Andreas. -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different."

[bug #57781] make broken on MIPS big-endian if posix_spawn() is used

2020-02-10 Thread Andreas Schwab
Follow-up Comment #1, bug #57781 (project make): ___ Reply to this item at: ___ Message sent vi

Re: [PATCH] Port functions/shell to Solaris 10

2019-10-14 Thread Andreas Schwab
; signal numbers and exit statuses are shoehorned into the 'int' status > updated by waitpid; apps are supposed to use WEXITSTATUS etc. to retrieve > the info from that 'int'. I think that Perl tries to standardize this so > that Perl apps just one way to shoehorn.

Re: [PATCH] Add the --nice argument to make

2019-09-17 Thread Andreas Schwab
) == nice(arg_nice)) It is unspecified which operand is evaluated first. Andreas. -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different." _

Re: vpathplus test 2 patch

2019-09-16 Thread Andreas Schwab
On Sep 16 2019, Paul Smith wrote: > On Thu, 2019-09-12 at 09:33 +0200, Andreas Schwab wrote: >> On Sep 11 2019, Dmitry Goncharov wrote: >> > On Wed, Sep 11, 2019 at 2:51 AM Andreas Schwab wrote: >> > > > The new hashing mechanism hashes differently

Re: patch locale settings

2019-09-16 Thread Andreas Schwab
full "de_DE.UTF-8", then it isn't recognized and > I get the default. ru_RU (or de_DE) is just another locale that you can install (in glibc, it uses ISO-8859-5 as the codeset, or ISO-8859-1 for the de_DE locale). Andreas. -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerpr

Re: vpathplus test 2 patch

2019-09-12 Thread Andreas Schwab
On Sep 11 2019, Dmitry Goncharov wrote: > On Wed, Sep 11, 2019 at 2:51 AM Andreas Schwab wrote: >> >> > The new hashing mechanism hashes differently on big vs little endian. >> >> Should this be considered as a bug? > > I don't think the order or remo

Re: vpathplus test 2 patch

2019-09-10 Thread Andreas Schwab
On Sep 10 2019, Dmitry Goncharov via Bug reports and discussion for GNU make wrote: > The new hashing mechanism hashes differently on big vs little endian. Should this be considered as a bug? Andreas. -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1

Re: Make error messages

2019-09-10 Thread Andreas Schwab
"Makefile" is at best ambiguous. But isn't that the same situation as with any other error message in a recursive make, which Emacs already handles correctly (with the help of make --print-directory)? Andreas. -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 019

[bug #56875] subst failure for "$" character

2019-09-09 Thread Andreas Schwab
Follow-up Comment #1, bug #56875 (project make): If you want to quote $ use $$. \$ only matches \$, nothing else. CVS_BASE_TAG_NAME = $(filter-out ame: ame $$,$(subst -,.,$Name: v1-1-1beta-1 $)) ___ Reply to this item at:

Re: GNU make 4.2.90 release candidate available

2019-08-28 Thread Andreas Schwab
On Aug 27 2019, Dennis Clarke wrote: > (1) -std=9899:1999This is the same as c99 and it merely means that > GCC *should* make every reasonable attempt to comply with the C99 code > specification. This also disables every extension over C, especially POSIX. Andreas. -- Andre

Re: GNU make 4.2.90 release candidate available

2019-08-27 Thread Andreas Schwab
x27;m not sure I understand the > comment. I think that item should be moved to the developer news. Andreas. -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different."

Re: How to disable Guile?

2019-07-22 Thread Andreas Schwab
) and > you don't have pkg-config installed so those autoconf macros were not > expanded. Most likely that happend because of messed-up time stamps. Andreas. -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748

[bug #54816] $(wildcard ...) function does not report dangling symlinks

2018-10-10 Thread Andreas Schwab
Follow-up Comment #2, bug #54816 (project make): See glibc bug 866 which was only fixed recently. ___ Reply to this item at: __

Re: [bug #54703] Incorrection expansion of := accumulator under $(eval …)

2018-09-26 Thread Andreas Schwab
On Sep 25 2018, "Paul D. Smith" wrote: > It's a shame that autoconf doesn't give an error when it can't find a macro > but I guess it doesn't know the difference between a macro and some shell > commands. You can use m4_pattern_forbid to make that an err

Re: [Newbie] Getting involved

2018-09-20 Thread Andreas Schwab
hat you want with Gnu Make, already, though. > See 'Rebuilding when CPPFLAGS changes' in "Gnu Make Unleashed". See also how the Linux kernel makefiles do that. Andreas. -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E

Re: [bug #54529] [Makefile:5: foobar] Segmentation fault

2018-08-21 Thread Andreas Schwab
On Aug 21 2018, Mark Galeck wrote: > Then why does the error say "make: ***" ? Because it's the messenger. Andreas. -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for somethi

Re: [bug #54529] [Makefile:5: foobar] Segmentation fault

2018-08-20 Thread Andreas Schwab
RY_PATH as set above. Nothing to do with make. Andreas. -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different." ___ Bug-make mail

Re: ENOEXEC from exec*() functions...?

2018-07-30 Thread Andreas Schwab
char *)0); Andreas. -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different." ___ Bug-make mailing list Bug-make@gnu.org https://lists.gnu.org/mailman/listinfo/bug-make

Re: question about autotools within GNU make itself

2018-01-22 Thread Andreas Schwab
pt to re-run those tools and > regenerate their output. This fails if you don't have them installed. If you use AM_MAINTAINER_MODE then this rebuild will only happen when configured with --enable-maintainer-mode. Andreas. -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint =

Re: mention if a=b make = make a=b

2017-11-21 Thread Andreas Schwab
On Nov 21 2017, Edward Welbourne wrote: > I can't remember what happens if you use += in the make-file: I'm fairly > sure it extends whatever you had in the environment, but I can't > remember whether it extends a value set on the command-line. It doesn't. Andre

Re: INTERNAL: Exiting with 2 jobserver tokens available; should be 5!

2016-11-10 Thread Andreas Schwab
On Nov 09 2016, Jaak Ristioja wrote: > Is this some known GNU Make bug on ARM? Works fine here: https://build.opensuse.org/project/show/openSUSE:Factory:ARM Andreas. -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 &

Re: [PATCH 3/5] use jhash for STRING_N_HASH

2016-11-03 Thread Andreas Schwab
gt; +(r) += val; \ > + } while(0); That should use a fixed-size type. Andreas. -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different."

Re: features/output-sync always times out

2016-05-30 Thread Andreas Schwab
Paul Smith writes: > On Mon, 2016-05-23 at 12:31 +0200, Andreas Schwab wrote: >> What does it mean that the features/output-sync test always times out? > > I don't know.  It never does that for me.  Can you give me more details > about your system? It always fails

features/output-sync always times out

2016-05-23 Thread Andreas Schwab
se.2Mon May 23 10:05:59 2016 --- work/features/output-sync.log.2 Mon May 23 10:05:00 2016 *** *** 2,8 sleep 1 ; /home/abuild/rpmbuild/BUILD/make-4.2/tests/../make -C bar bar: start bar: end - foo: start - foo: end - baz: start - baz: end --- 2,4 Andreas. --

[bug #45728] .VARIABLES not updated after undefine

2016-03-14 Thread Andreas Schwab
Follow-up Comment #3, bug #45728 (project make): Why do the two variables have different types? +static unsigned int variable_changenum; + static unsigned long last_changenum = 0; ___ Reply to this item at:

[bug #45728] .VARIABLES not updated after undefine

2015-09-03 Thread Andreas Schwab
Additional Item Attachment, bug #45728 (project make): File name: 0001-SV-45728-Force-recomputing-.VARIABLES-when-a-variabl.patch Size:2 KB ___ Reply to this item at: __

[bug #45728] .VARIABLES not updated after undefine

2015-08-10 Thread Andreas Schwab
URL: Summary: .VARIABLES not updated after undefine Project: make Submitted by: schwab Submitted on: Mo 10 Aug 2015 15:23:58 CEST Severity: 3 - Normal Item Group: Bug

.VARIABLES not updated after undefine

2015-07-14 Thread Andreas Schwab
Makefile.variables MY Variables = MY_one MY_two Andreas. -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different." ___ Bug-make mailing list Bug-ma

Re: timestamp bug when files are created just before make is run

2012-12-10 Thread Andreas Schwab
Mikulas Patocka writes: > BTW. on Linux, high precision timestamps have really kernel-tick > precision, not nanosecond precision. The precision is as high as what the best hardware timer provides, independent of the configured value of HZ. Andreas. -- Andreas Schwab, SUSE Lab

Re: make 3.82 fails on powerpc defconfig update [was: Linux 2.6.35]

2010-08-02 Thread Andreas Schwab
Sam Ravnborg writes: > +bootwrapper_install Missing colon. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." ___

Re: make 3.60: BS/NL mishandled with non-default SHELL

2006-08-30 Thread Andreas Schwab
Eli Zaretskii <[EMAIL PROTECTED]> writes: >> From: Andreas Schwab <[EMAIL PROTECTED]> >> Date: Mon, 28 Aug 2006 16:07:37 +0200 >> Cc: [EMAIL PROTECTED] >> >> The following makefile causes a syntax error, but works correctly when the >> first line

make 3.60: BS/NL mishandled with non-default SHELL

2006-08-28 Thread Andreas Schwab
pected end of file /bin/sh: line 1::; \: command not found /bin/sh: -c: line 2: syntax error near unexpected token `fi' /bin/sh: -c: line 2: `fi' make: *** [all] Error 2 Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL PROTECTED] SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 N