[bug #57602] read.c file has double slash comment in 2344 string

2020-01-15 Thread Paul D. Smith
=> SCM ___ Follow-up Comment #1: This has already been fixed. If you like you can try a pre-release of the next release of GNU make, here: https://alpha.gnu.org/gnu/make/make-4.2.93.tar.gz Thanks for yo

[bug #57602] read.c file has double slash comment in 2344 string

2020-01-15 Thread Dmitri Stepanov
URL: <https://savannah.gnu.org/bugs/?57602> Summary: read.c file has double slash comment in 2344 string Project: make Submitted by: dstep Submitted on: Wed 15 Jan 2020 10:21:47 AM UTC Severity: 3 -

filedef.h comment about file_timestamp_sprintf of by 10

2014-07-03 Thread Rob Franken
before -999 or after wouldn't be a real problem I just used the 19 that was mentioned in the comment. While that is perhaps not the best idea to do I later found out that this 19 was of by 10 since the nanoseconds were added. (Also my gut feeling to add 1 just in case the \0 end byte w

[bug #40801] $(info), $(warning), $(error) are evaluated in a comment in a define

2014-01-06 Thread Paul D. Smith
Update of bug #40801 (project make): Status:None => Not A Bug Open/Closed:Open => Closed ___ Follow-up Comment #1: This isn't

[bug #40801] $(info), $(warning), $(error) are evaluated in a comment in a define

2013-12-04 Thread anonymous
URL: <http://savannah.gnu.org/bugs/?40801> Summary: $(info), $(warning), $(error) are evaluated in a comment in a define Project: make Submitted by: None Submitted on: Wed 04 Dec 2013 10:26:31 AM UTC Severity: 3 -

Fix for comment typo

2011-07-12 Thread Reuben Thomas
Below, a patch for a comment fix in variable.c. The original was sufficiently obscure that you'll want to check my rewrite does in fact have the correct meaning: ---cut here--- Index: variable.c === RCS file: /sources/make

Re: Bug with comment parsing and variable expansion

2010-11-09 Thread Rafaël Carré
ake and netbsd 'pmake' > > > > A-$(X) isn't expanded to "A-1" because of the comment on the line > > where X is set, although X is set to "1" > > X is not set to "1". It's set to "1 " (note trailing space). This

Re: Bug with comment parsing and variable expansion

2010-11-09 Thread Paul Smith
On Tue, 2010-11-09 at 15:47 +0100, Rafaël Carré wrote: > Hello, > > I believe I've found a bug in make 3.81, or at least some confusing > behaviour. > > Here is a comparison of GNU make and netbsd 'pmake' > > A-$(X) isn't expanded to "A-1&quo

Re: Bug with comment parsing and variable expansion

2010-11-09 Thread Rafaël Carré
On Tue, 9 Nov 2010 15:47:36 +0100 Rafaël Carré wrote: > % make -v > GNU Make 3.81 Problem still exists in 3.82 -- ✍ Rafaël Carré ☺ signature.asc Description: PGP signature ___ Bug-make mailing list Bug-make@gnu.org http://lists.gnu.org/mailman/list

Bug with comment parsing and variable expansion

2010-11-09 Thread Rafaël Carré
Hello, I believe I've found a bug in make 3.81, or at least some confusing behaviour. Here is a comparison of GNU make and netbsd 'pmake' A-$(X) isn't expanded to "A-1" because of the comment on the line where X is set, although X is set to "1" % cat Mak

Re: bug? $(warning)/$(error) evaluated from inside a comment in a 'define'?

2007-06-20 Thread Stephan Beal
On Wednesday 20 June 2007, Paul Smith wrote: > the variable being defined. In fact nothing is parsed inside a > define. I'm not sure, from your message, if this is what you feel is > the surprising behavior; Right - that's what surprised me. i assumed that comments were skipped during the init

Re: bug? $(warning)/$(error) evaluated from inside a comment in a 'define'?

2007-06-20 Thread Stephan Beal
On Wednesday 20 June 2007, Philip Guenther wrote: > On 6/19/07, Stephan Beal <[EMAIL PROTECTED]> wrote: > Okay, so you've defined a variable, 'bogo', whose value consists of > two lines, the first of which has a '#' as its first non-whitespace > charact

Re: bug? $(warning)/$(error) evaluated from inside a comment in a 'define'?

2007-06-20 Thread Paul Smith
On Tue, 2007-06-19 at 20:50 +0200, Stephan Beal wrote: > When a $(warning) or $(error) is inside a 'define', it is evaluated > even if it is part of a comment. Others have responded with all the info but I'm not sure everyone understood it. There are two factors at work he

Re: bug? $(warning)/$(error) evaluated from inside a comment in a 'define'?

2007-06-20 Thread Sam Ravnborg
or $(error) is inside a 'define', it is evaluated even > if it is part of a comment. A demonstration: > > [EMAIL PROTECTED]:~/cvs/www.t5$ make --version > GNU Make 3.81 > ... > > Input file to reproduce problem: > #!/usr/bin/make -f > #

Re: bug? $(warning)/$(error) evaluated from inside a comment in a 'define'?

2007-06-19 Thread Philip Guenther
al $(call bogo,foo)) in that file, you wouldn't get a warning because the $(warning) wouldn't be expanded before the eval, and in the eval it would be in a comment. Also, $(info ...) and its families seem to evaluate "too early" according to my vague impression. Like all vari

Re: bug? $(warning)/$(error) evaluated from inside a comment in a 'define'?

2007-06-19 Thread Philip Guenther
On 6/19/07, Stephan Beal <[EMAIL PROTECTED]> wrote: ... When a $(warning) or $(error) is inside a 'define', it is evaluated even if it is part of a comment. The above statement is nonsensical. If something is inside a define, is not inside a comment. define bogo # $(war

Re: bug? $(warning)/$(error) evaluated from inside a comment in a 'define'?

2007-06-19 Thread Agent Zhang
On 6/20/07, Stephan Beal <[EMAIL PROTECTED]> wrote: When a $(warning) or $(error) is inside a 'define', it is evaluated even if it is part of a comment. A demonstration: I think the test case to demonstrate this bug can be simplified as: define bogo # $(warning this s

bug? $(warning)/$(error) evaluated from inside a comment in a 'define'?

2007-06-19 Thread Stephan Beal
Hi, Makers! i just discovered a Make behaviour which really surprises me. While that in itself is nothing new ;), this one certainly violates the principal of least astonishment: When a $(warning) or $(error) is inside a 'define', it is evaluated even if it is part of a

$(comment)

2006-11-16 Thread Dan Jacobson
Gentlemen, I have discovered an excellent way to comment out parts of lines in makefiles. Be sure you document it somewhere. All one needs to do is wrap a $( . ) around the code to be commented: gp:timez1 echo 'set xdata time;set timefmt "%s";$(set format x "

Re: Comment on documentation for GNU make

2002-09-12 Thread Paul D. Smith
%% "VomLehn, David" <[EMAIL PROTECTED]> writes: vd> I have been reading the single HTML page version of the GNU make vd> documentation and have found what appears to be a small vd> omission. I could find no mention of the use of the plus character vd> (+) in the beginning of command lines

Comment on documentation for GNU make

2002-09-12 Thread VomLehn, David
I have been reading the single HTML page version of the GNU make documentation and have found what appears to be a small omission. I could find no mention of the use of the plus character (+) in the beginning of command lines to indicate that the command is to be executed even if the -n flag

Re: \ at the end of a comment is not ignored.

2002-08-02 Thread Sanjeeb Sahoo
y, August 02, 2002 3:02 PM Subject: Re: \ at the end of a comment is not ignored. > %% "Sanjeeb Sahoo" <[EMAIL PROTECTED]> writes: > > ss> Looks like the '\' character at the end of a comment continues to > ss> have the same special meaning. Please r

Re: \ at the end of a comment is not ignored.

2002-08-02 Thread Paul D. Smith
%% "Sanjeeb Sahoo" <[EMAIL PROTECTED]> writes: ss> Looks like the '\' character at the end of a comment continues to ss> have the same special meaning. Please refer to the 3 liner ss> makefile attached here with. when I invoke make, I get the

\ at the end of a comment is not ignored.

2002-08-01 Thread Sanjeeb Sahoo
Hi, Looks like the '\' character at the end of a comment continues to have the same special meaning. Please refer to the 3 liner makefile attached here with. when I invoke make, I get the following error... Makefile:3: *** commands commence before first target. Stop. When I remove

Re: make: # in quotes is still treated as comment character

2002-04-14 Thread John Alvord
I've used a simple circumvention for years. _POUND = \# and then use $(_POUND) in the command rules. which are interpreted by shells after substitution. Of course not using # in filenames helps!! john alvord On Fri, 12 Apr 2002 19:46:22 -0500, Manoj Srivastava <[EMAIL PROTECTED]> wrote: >Hi,

Re: make: # in quotes is still treated as comment character

2002-04-13 Thread Paul D. Smith
c ms> Pounds work Hm. This might not work with other shells; the rules about when the shell treats a # as a comment and when it doesn't are sometimes subtlely different between shells. ms> cc-c -o dollar$file.o dollar$file.c ms> cc: dollar.c: No such file or directory Righ

make: # in quotes is still treated as comment character

2002-04-12 Thread Manoj Srivastava
Hi, [Please retain the CC to [EMAIL PROTECTED] and [EMAIL PROTECTED] so that the Debian Bug Tracking system can record your input] The following problems were reported by debian developers. I am not sure they are related, but they seem to deal with quoting of