Re: [PATCH] Improve “missing separator” error when reading spaces

2016-11-24 Thread Paul Smith
On Sat, 2016-11-19 at 18:49 +0100, Michael Stapelberg wrote: > With this change, users who have their editor misconfigured when writing > Makefiles without using 8 spaces for one TAB character will also get a > friendly error message. I'm not a fan of this change. Make's "missing separator" is re

Re: [PATCH] Improve “missing separator” error when reading spaces

2016-11-21 Thread Edward Welbourne
Michael Stapelberg's patch: diff --git a/read.c b/read.c index b870aa8..3c67e55 100644 --- a/read.c +++ b/read.c @@ -1122,6 +1122,8 @@ eval (struct ebuffer *ebuf, int set_default) one of the most common bugs found in makefiles... */ if (cmd_prefix == '\t' && strneq (

[PATCH] Improve “missing separator” error when reading spaces

2016-11-19 Thread Michael Stapelberg
With this change, users who have their editor misconfigured when writing Makefiles without using 8 spaces for one TAB character will also get a friendly error message. I used the following 3 test cases: echo -e "foo:\n echo bar" > broken.make echo -e "foo:\necho bar" > broken.8.make

[PATCH] Improve “missing separator” error when reading spaces

2016-11-19 Thread Michael Stapelberg
With this change, users who have their editor misconfigured when writing Makefiles without using 8 spaces for one TAB character will also get a friendly error message. I used the following 3 test cases: echo -e "foo:\n echo bar" > broken.make echo -e "foo:\necho bar" > broken.8.make