Re: [PATCH 2/2] job.c: implementing child_execute_job() using posix_spawn(), and use it if present

2018-08-06 Thread Barath Aron
On 08/05/2018 02:50 PM, Paul Smith wrote: I pushed these changes to Git yesterday. Please verify it works in your environment. Commit that I used: a1bb739165a944769cbb4a6e4f027ac9c2587122 Threos libc does not support the write of 'environ'. Thus, I had to add minor changes. Some part of it

Re: [PATCH 2/2] job.c: implementing child_execute_job() using posix_spawn(), and use it if present

2018-08-05 Thread Paul Smith
On Mon, 2018-07-30 at 12:30 +0200, Barath Aron wrote: > > I also added a configure --disable-posix-spawn option for those who > > want to continue to use fork()/vfork() even when posix_spawn() is > > available. > > Perfect. I can't wait to try it. :) I pushed these changes to Git yesterday. Plea

Re: [PATCH 2/2] job.c: implementing child_execute_job() using posix_spawn(), and use it if present

2018-07-30 Thread Barath Aron
On 07/30/2018 12:21 PM, Paul Smith wrote: This weekend I reworked the handling of failures in child_execute_job() so that it behaves properly even when the child failure happens in the current process (e.g., the fork() or posix_spawn()). It needs a bit of cleanup--in particular writing a test is

Re: [PATCH 2/2] job.c: implementing child_execute_job() using posix_spawn(), and use it if present

2018-07-30 Thread Paul Smith
On Mon, 2018-07-23 at 07:10 +0200, Barath Aron wrote: > On 07/22/2018 09:58 PM, Paul Smith wrote: > > On Mon, 2018-07-09 at 09:05 +0200, Aron Barath wrote: > > > --- > > > > Thanks for the work you put into this! > > You're welcome! :) > > Unfortunately this change reveals some deeper problems th

Re: [PATCH 2/2] job.c: implementing child_execute_job() using posix_spawn(), and use it if present

2018-07-22 Thread Barath Aron
On 07/22/2018 09:58 PM, Paul Smith wrote: On Mon, 2018-07-09 at 09:05 +0200, Aron Barath wrote: --- Thanks for the work you put into this! You're welcome! :) Unfortunately this change reveals some deeper problems that I will need to address. Basically, the old code never really expected fork

Re: [PATCH 2/2] job.c: implementing child_execute_job() using posix_spawn(), and use it if present

2018-07-22 Thread Paul Smith
On Mon, 2018-07-09 at 09:05 +0200, Aron Barath wrote: > --- Thanks for the work you put into this! Unfortunately this change reveals some deeper problems that I will need to address. Basically, the old code never really expected fork() to fail: if it did we intended to just give up completely.

[PATCH 2/2] job.c: implementing child_execute_job() using posix_spawn(), and use it if present

2018-07-09 Thread Aron Barath
--- src/job.c | 166 ++ 1 file changed, 166 insertions(+) diff --git a/src/job.c b/src/job.c index 47ce73d..1c94d4a 100644 --- a/src/job.c +++ b/src/job.c @@ -137,6 +137,10 @@ extern int wait3 (); # endif /* Have wait3. */ #endif /* Have wait